Fixed AncestorIds and applied review comments

4 files changed, 48 insertions, 144 deletions

diff --git a/Jellyfin.Data/Entities/AncestorId.cs b/Jellyfin.Data/Entities/AncestorId.cs
index 54e938347..941a8eb2e 100644
--- a/Jellyfin.Data/Entities/AncestorId.cs
+++ b/Jellyfin.Data/Entities/AncestorId.cs
@@ -1,19 +1,19 @@
 using System;
-using System.Collections.Generic;
-using System.ComponentModel.DataAnnotations;
-using System.ComponentModel.DataAnnotations.Schema;
 
 namespace Jellyfin.Data.Entities;
 
-#pragma warning disable CA1708 // Identifiers should differ by more than case
-#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
+/// <summary>
+/// Represents the relational informations for an <see cref="BaseItemEntity"/>.
+/// </summary>
 public class AncestorId
 {
-    public Guid Id { get; set; }
+    /// <summary>
+    /// Gets or Sets the AncestorId that may or may not be an database managed Item or an materialised local item.
+    /// </summary>
+    public required Guid ParentItemId { get; set; }
 
+    /// <summary>
+    /// Gets or Sets the related that may or may not be an database managed Item or an materialised local item.
+    /// </summary>
     public required Guid ItemId { get; set; }
-
-    public required BaseItemEntity Item { get; set; }
-
-    public string? AncestorIdText { get; set; }
 }
diff --git a/Jellyfin.Data/Entities/MediaStreamInfo.cs b/Jellyfin.Data/Entities/MediaStreamInfo.cs
index 1198026e7..28037de9d 100644
--- a/Jellyfin.Data/Entities/MediaStreamInfo.cs
+++ b/Jellyfin.Data/Entities/MediaStreamInfo.cs
@@ -12,7 +12,7 @@ public class MediaStreamInfo
 
     public int StreamIndex { get; set; }
 
-    public string? StreamType { get; set; }
+    public MediaStreamTypeEntity? StreamType { get; set; }
 
     public string? Codec { get; set; }
 
diff --git a/Jellyfin.Data/Entities/MediaStreamTypeEntity.cs b/Jellyfin.Data/Entities/MediaStreamTypeEntity.cs
new file mode 100644
index 000000000..d1f6f1b18
--- /dev/null
+++ b/Jellyfin.Data/Entities/MediaStreamTypeEntity.cs
@@ -0,0 +1,37 @@
+namespace Jellyfin.Data.Entities;
+
+/// <summary>
+/// Enum MediaStreamType.
+/// </summary>
+public enum MediaStreamTypeEntity
+{
+    /// <summary>
+    /// The audio.
+    /// </summary>
+    Audio,
+
+    /// <summary>
+    /// The video.
+    /// </summary>
+    Video,
+
+    /// <summary>
+    /// The subtitle.
+    /// </summary>
+    Subtitle,
+
+    /// <summary>
+    /// The embedded image.
+    /// </summary>
+    EmbeddedImage,
+
+    /// <summary>
+    /// The data.
+    /// </summary>
+    Data,
+
+    /// <summary>
+    /// The lyric.
+    /// </summary>
+    Lyric
+}
diff --git a/Jellyfin.Data/Entities/PeopleKind.cs b/Jellyfin.Data/Entities/PeopleKind.cs
deleted file mode 100644
index 967f7c11f..000000000
--- a/Jellyfin.Data/Entities/PeopleKind.cs
+++ /dev/null
@@ -1,133 +0,0 @@
-namespace Jellyfin.Data.Entities;
-
-/// <summary>
-/// The person kind.
-/// </summary>
-public enum PeopleKind
-{
-    /// <summary>
-    /// An unknown person kind.
-    /// </summary>
-    Unknown,
-
-    /// <summary>
-    /// A person whose profession is acting on the stage, in films, or on television.
-    /// </summary>
-    Actor,
-
-    /// <summary>
-    /// A person who supervises the actors and other staff in a film, play, or similar production.
-    /// </summary>
-    Director,
-
-    /// <summary>
-    /// A person who writes music, especially as a professional occupation.
-    /// </summary>
-    Composer,
-
-    /// <summary>
-    /// A writer of a book, article, or document. Can also be used as a generic term for music writer if there is a lack of specificity.
-    /// </summary>
-    Writer,
-
-    /// <summary>
-    /// A well-known actor or other performer who appears in a work in which they do not have a regular role.
-    /// </summary>
-    GuestStar,
-
-    /// <summary>
-    /// A person responsible for the financial and managerial aspects of the making of a film or broadcast or for staging a play, opera, etc.
-    /// </summary>
-    Producer,
-
-    /// <summary>
-    /// A person who directs the performance of an orchestra or choir.
-    /// </summary>
-    Conductor,
-
-    /// <summary>
-    /// A person who writes the words to a song or musical.
-    /// </summary>
-    Lyricist,
-
-    /// <summary>
-    /// A person who adapts a musical composition for performance.
-    /// </summary>
-    Arranger,
-
-    /// <summary>
-    /// An audio engineer who performed a general engineering role.
-    /// </summary>
-    Engineer,
-
-    /// <summary>
-    /// An engineer responsible for using a mixing console to mix a recorded track into a single piece of music suitable for release.
-    /// </summary>
-    Mixer,
-
-    /// <summary>
-    /// A person who remixed a recording by taking one or more other tracks, substantially altering them and mixing them together with other material.
-    /// </summary>
-    Remixer,
-
-    /// <summary>
-    /// A person who created the material.
-    /// </summary>
-    Creator,
-
-    /// <summary>
-    /// A person who was the artist.
-    /// </summary>
-    Artist,
-
-    /// <summary>
-    /// A person who was the album artist.
-    /// </summary>
-    AlbumArtist,
-
-    /// <summary>
-    /// A person who was the author.
-    /// </summary>
-    Author,
-
-    /// <summary>
-    /// A person who was the illustrator.
-    /// </summary>
-    Illustrator,
-
-    /// <summary>
-    /// A person responsible for drawing the art.
-    /// </summary>
-    Penciller,
-
-    /// <summary>
-    /// A person responsible for inking the pencil art.
-    /// </summary>
-    Inker,
-
-    /// <summary>
-    /// A person responsible for applying color to drawings.
-    /// </summary>
-    Colorist,
-
-    /// <summary>
-    /// A person responsible for drawing text and speech bubbles.
-    /// </summary>
-    Letterer,
-
-    /// <summary>
-    /// A person responsible for drawing the cover art.
-    /// </summary>
-    CoverArtist,
-
-    /// <summary>
-    /// A person contributing to a resource by revising or elucidating the content, e.g., adding an introduction, notes, or other critical matter.
-    /// An editor may also prepare a resource for production, publication, or distribution.
-    /// </summary>
-    Editor,
-
-    /// <summary>
-    /// A person who renders a text from one language into another.
-    /// </summary>
-    Translator
-}