From 2955f2f56275fca01cd3f586b3475dcdfbea78ed Mon Sep 17 00:00:00 2001 From: JPVenson Date: Wed, 9 Oct 2024 23:19:24 +0000 Subject: Fixed AncestorIds and applied review comments --- Jellyfin.Data/Entities/AncestorId.cs | 20 ++-- Jellyfin.Data/Entities/MediaStreamInfo.cs | 2 +- Jellyfin.Data/Entities/MediaStreamTypeEntity.cs | 37 +++++++ Jellyfin.Data/Entities/PeopleKind.cs | 133 ------------------------ 4 files changed, 48 insertions(+), 144 deletions(-) create mode 100644 Jellyfin.Data/Entities/MediaStreamTypeEntity.cs delete mode 100644 Jellyfin.Data/Entities/PeopleKind.cs (limited to 'Jellyfin.Data') diff --git a/Jellyfin.Data/Entities/AncestorId.cs b/Jellyfin.Data/Entities/AncestorId.cs index 54e938347..941a8eb2e 100644 --- a/Jellyfin.Data/Entities/AncestorId.cs +++ b/Jellyfin.Data/Entities/AncestorId.cs @@ -1,19 +1,19 @@ using System; -using System.Collections.Generic; -using System.ComponentModel.DataAnnotations; -using System.ComponentModel.DataAnnotations.Schema; namespace Jellyfin.Data.Entities; -#pragma warning disable CA1708 // Identifiers should differ by more than case -#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member +/// +/// Represents the relational informations for an . +/// public class AncestorId { - public Guid Id { get; set; } + /// + /// Gets or Sets the AncestorId that may or may not be an database managed Item or an materialised local item. + /// + public required Guid ParentItemId { get; set; } + /// + /// Gets or Sets the related that may or may not be an database managed Item or an materialised local item. + /// public required Guid ItemId { get; set; } - - public required BaseItemEntity Item { get; set; } - - public string? AncestorIdText { get; set; } } diff --git a/Jellyfin.Data/Entities/MediaStreamInfo.cs b/Jellyfin.Data/Entities/MediaStreamInfo.cs index 1198026e7..28037de9d 100644 --- a/Jellyfin.Data/Entities/MediaStreamInfo.cs +++ b/Jellyfin.Data/Entities/MediaStreamInfo.cs @@ -12,7 +12,7 @@ public class MediaStreamInfo public int StreamIndex { get; set; } - public string? StreamType { get; set; } + public MediaStreamTypeEntity? StreamType { get; set; } public string? Codec { get; set; } diff --git a/Jellyfin.Data/Entities/MediaStreamTypeEntity.cs b/Jellyfin.Data/Entities/MediaStreamTypeEntity.cs new file mode 100644 index 000000000..d1f6f1b18 --- /dev/null +++ b/Jellyfin.Data/Entities/MediaStreamTypeEntity.cs @@ -0,0 +1,37 @@ +namespace Jellyfin.Data.Entities; + +/// +/// Enum MediaStreamType. +/// +public enum MediaStreamTypeEntity +{ + /// + /// The audio. + /// + Audio, + + /// + /// The video. + /// + Video, + + /// + /// The subtitle. + /// + Subtitle, + + /// + /// The embedded image. + /// + EmbeddedImage, + + /// + /// The data. + /// + Data, + + /// + /// The lyric. + /// + Lyric +} diff --git a/Jellyfin.Data/Entities/PeopleKind.cs b/Jellyfin.Data/Entities/PeopleKind.cs deleted file mode 100644 index 967f7c11f..000000000 --- a/Jellyfin.Data/Entities/PeopleKind.cs +++ /dev/null @@ -1,133 +0,0 @@ -namespace Jellyfin.Data.Entities; - -/// -/// The person kind. -/// -public enum PeopleKind -{ - /// - /// An unknown person kind. - /// - Unknown, - - /// - /// A person whose profession is acting on the stage, in films, or on television. - /// - Actor, - - /// - /// A person who supervises the actors and other staff in a film, play, or similar production. - /// - Director, - - /// - /// A person who writes music, especially as a professional occupation. - /// - Composer, - - /// - /// A writer of a book, article, or document. Can also be used as a generic term for music writer if there is a lack of specificity. - /// - Writer, - - /// - /// A well-known actor or other performer who appears in a work in which they do not have a regular role. - /// - GuestStar, - - /// - /// A person responsible for the financial and managerial aspects of the making of a film or broadcast or for staging a play, opera, etc. - /// - Producer, - - /// - /// A person who directs the performance of an orchestra or choir. - /// - Conductor, - - /// - /// A person who writes the words to a song or musical. - /// - Lyricist, - - /// - /// A person who adapts a musical composition for performance. - /// - Arranger, - - /// - /// An audio engineer who performed a general engineering role. - /// - Engineer, - - /// - /// An engineer responsible for using a mixing console to mix a recorded track into a single piece of music suitable for release. - /// - Mixer, - - /// - /// A person who remixed a recording by taking one or more other tracks, substantially altering them and mixing them together with other material. - /// - Remixer, - - /// - /// A person who created the material. - /// - Creator, - - /// - /// A person who was the artist. - /// - Artist, - - /// - /// A person who was the album artist. - /// - AlbumArtist, - - /// - /// A person who was the author. - /// - Author, - - /// - /// A person who was the illustrator. - /// - Illustrator, - - /// - /// A person responsible for drawing the art. - /// - Penciller, - - /// - /// A person responsible for inking the pencil art. - /// - Inker, - - /// - /// A person responsible for applying color to drawings. - /// - Colorist, - - /// - /// A person responsible for drawing text and speech bubbles. - /// - Letterer, - - /// - /// A person responsible for drawing the cover art. - /// - CoverArtist, - - /// - /// A person contributing to a resource by revising or elucidating the content, e.g., adding an introduction, notes, or other critical matter. - /// An editor may also prepare a resource for production, publication, or distribution. - /// - Editor, - - /// - /// A person who renders a text from one language into another. - /// - Translator -} -- cgit v1.2.3