1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
|
using System;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Jellyfin.Database.Implementations;
using Jellyfin.Database.Implementations.Entities;
using Jellyfin.Database.Implementations.Locking;
using Jellyfin.Database.Providers.Sqlite;
using Jellyfin.Server.Implementations.Item;
using Jellyfin.Server.Migrations.Routines;
using Jellyfin.Server.ServerSetupApp;
using MediaBrowser.Common.Configuration;
using MediaBrowser.Controller.Entities;
using Microsoft.Data.Sqlite;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using Xunit;
namespace Jellyfin.Server.Tests.Migrations;
public sealed class HarmonizeConflictingUserDataTests : IDisposable
{
private readonly SqliteConnection _connection;
private readonly DbContextOptions<JellyfinDbContext> _dbOptions;
private readonly Guid _userId = Guid.Parse("11111111-1111-1111-1111-111111111111");
private readonly Guid _itemId = Guid.Parse("aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa");
private readonly Guid _untouchedId = Guid.Parse("bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb");
public HarmonizeConflictingUserDataTests()
{
_connection = new SqliteConnection("Data Source=:memory:");
_connection.Open();
_dbOptions = new DbContextOptionsBuilder<JellyfinDbContext>()
.UseSqlite(_connection)
.Options;
using var context = CreateDbContext();
context.Database.EnsureCreated();
}
public void Dispose() => _connection.Dispose();
[Fact]
public async Task Perform_ConflictingRows_CollapsesToMostRecentPlay()
{
using (var ctx = CreateDbContext())
{
ctx.Users.Add(new User("user", "auth-provider", "reset-provider") { Id = _userId });
ctx.BaseItems.Add(new BaseItemEntity { Id = _itemId, Type = typeof(Folder).FullName! });
ctx.BaseItems.Add(new BaseItemEntity { Id = _untouchedId, Type = typeof(Folder).FullName! });
// One item holding rows from two different eras of itself...
ctx.UserData.Add(Row(_itemId, "497698", new DateTime(2023, 8, 14, 0, 0, 0, DateTimeKind.Utc), playCount: 9, positionTicks: 0, played: true));
ctx.UserData.Add(Row(_itemId, "tt3480822", new DateTime(2021, 12, 31, 0, 0, 0, DateTimeKind.Utc), playCount: 7, positionTicks: 490));
// ...and one whose rows already agree.
ctx.UserData.Add(Row(_untouchedId, "121", new DateTime(2022, 1, 1, 0, 0, 0, DateTimeKind.Utc), playCount: 2, positionTicks: 77));
ctx.UserData.Add(Row(_untouchedId, "tt0167261", new DateTime(2022, 1, 1, 0, 0, 0, DateTimeKind.Utc), playCount: 2, positionTicks: 77));
await ctx.SaveChangesAsync(TestContext.Current.CancellationToken);
}
await CreateMigration().PerformAsync(TestContext.Current.CancellationToken);
using (var ctx = CreateDbContext())
{
var rows = ctx.UserData.Where(e => e.ItemId.Equals(_itemId)).ToList();
Assert.Equal(2, rows.Count);
Assert.All(rows, row =>
{
Assert.True(row.Played);
Assert.Equal(0, row.PlaybackPositionTicks);
Assert.Equal(9, row.PlayCount);
});
Assert.All(ctx.UserData.Where(e => e.ItemId.Equals(_untouchedId)), row => Assert.Equal(77, row.PlaybackPositionTicks));
}
}
[Fact]
public async Task Perform_DetachedRows_AreLeftAlone()
{
using (var ctx = CreateDbContext())
{
ctx.Users.Add(new User("user", "auth-provider", "reset-provider") { Id = _userId });
// Detached rows belong to no item, so they are not a conflict and must keep their state
// for the next item that claims one of their keys.
ctx.UserData.Add(Row(BaseItemRepository.PlaceholderId, "497698", new DateTime(2023, 8, 14, 0, 0, 0, DateTimeKind.Utc), playCount: 9, positionTicks: 0, played: true));
ctx.UserData.Add(Row(BaseItemRepository.PlaceholderId, "tt3480822", new DateTime(2021, 12, 31, 0, 0, 0, DateTimeKind.Utc), playCount: 7, positionTicks: 490));
await ctx.SaveChangesAsync(TestContext.Current.CancellationToken);
}
await CreateMigration().PerformAsync(TestContext.Current.CancellationToken);
using (var ctx = CreateDbContext())
{
var rows = ctx.UserData.Where(e => e.ItemId.Equals(BaseItemRepository.PlaceholderId)).OrderBy(e => e.CustomDataKey).ToList();
Assert.Equal(0, rows[0].PlaybackPositionTicks);
Assert.Equal(490, rows[1].PlaybackPositionTicks);
}
}
private UserData Row(Guid itemId, string key, DateTime lastPlayed, int playCount, long positionTicks, bool played = false)
{
return new UserData
{
ItemId = itemId,
Item = null,
UserId = _userId,
User = null,
CustomDataKey = key,
LastPlayedDate = lastPlayed,
PlayCount = playCount,
PlaybackPositionTicks = positionTicks,
Played = played
};
}
private JellyfinDbContext CreateDbContext() => new(
_dbOptions,
NullLogger<JellyfinDbContext>.Instance,
new SqliteDatabaseProvider(new Mock<IApplicationPaths>().Object, NullLogger<SqliteDatabaseProvider>.Instance),
new NoLockBehavior(NullLogger<NoLockBehavior>.Instance));
private HarmonizeConflictingUserData CreateMigration()
{
var factory = new Mock<IDbContextFactory<JellyfinDbContext>>();
factory.Setup(f => f.CreateDbContextAsync(It.IsAny<CancellationToken>())).ReturnsAsync(CreateDbContext);
return new HarmonizeConflictingUserData(
new StartupLogger<HarmonizeConflictingUserData>(NullLogger<HarmonizeConflictingUserData>.Instance),
factory.Object);
}
}
|
