1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
|
using System;
using System.Linq;
using Emby.Server.Implementations.Data;
using Jellyfin.Data.Enums;
using Jellyfin.Database.Implementations;
using Jellyfin.Database.Implementations.Entities;
using Jellyfin.Server.Implementations.Item;
using MediaBrowser.Controller.Entities;
using MediaBrowser.Controller.Persistence;
using Moq;
using Xunit;
using BaseItemKind = Jellyfin.Data.Enums.BaseItemKind;
namespace Jellyfin.Server.Implementations.Tests.Item;
public sealed class PeopleRepositoryUpdatePeopleTests : SqliteDbTestFixture
{
private static readonly Guid _itemId = Guid.Parse("aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa");
private readonly PeopleRepository _repository;
public PeopleRepositoryUpdatePeopleTests()
{
var itemTypeLookup = new ItemTypeLookup();
using (var ctx = CreateDbContext())
{
ctx.BaseItems.Add(new BaseItemEntity
{
Id = _itemId,
Type = itemTypeLookup.BaseItemKindNames[BaseItemKind.Movie],
Name = "Movie",
MediaType = "Video",
IsMovie = true,
IsFolder = false,
IsVirtualItem = false
});
ctx.SaveChanges();
}
_repository = new PeopleRepository(
CreateDbContextFactory(),
itemTypeLookup,
new Mock<IItemQueryHelpers>().Object);
}
[Fact]
public void UpdatePeople_SamePersonAndTypeWithDifferentRoles_KeepsEveryCredit()
{
_repository.UpdatePeople(_itemId, [
CreatePerson("Person A", PersonKind.Writer, "Novel"),
CreatePerson("Person A", PersonKind.Writer, "Screenplay")
]);
using var ctx = CreateDbContext();
Assert.Single(ctx.Peoples);
Assert.Equal(
["Novel", "Screenplay"],
ctx.PeopleBaseItemMap.OrderBy(e => e.ListOrder).Select(e => e.Role ?? string.Empty).ToArray());
}
[Fact]
public void UpdatePeople_CreditsDifferingOnlyInCase_AreDeduped()
{
_repository.UpdatePeople(_itemId, [
CreatePerson("Person A", PersonKind.Actor, "Hero"),
CreatePerson("person a", PersonKind.Actor, "hero")
]);
using var ctx = CreateDbContext();
Assert.Single(ctx.Peoples);
var map = Assert.Single(ctx.PeopleBaseItemMap);
Assert.Equal("Hero", map.Role);
}
[Fact]
public void UpdatePeople_SamePersonAsDifferentTypes_CreatesOnePersonPerType()
{
_repository.UpdatePeople(_itemId, [
CreatePerson("Person A", PersonKind.Actor, "Hero"),
CreatePerson("Person A", PersonKind.Director, string.Empty)
]);
using var ctx = CreateDbContext();
Assert.Equal(2, ctx.Peoples.Count());
Assert.Equal(2, ctx.PeopleBaseItemMap.Count());
}
[Fact]
public void UpdatePeople_RepeatedUpdate_ReusesMappingsAndRefreshesOrder()
{
_repository.UpdatePeople(_itemId, [
CreatePerson("Person A", PersonKind.Actor, "Hero"),
CreatePerson("Person B", PersonKind.Actor, "Sidekick")
]);
Guid[] peopleIdsBefore;
using (var ctx = CreateDbContext())
{
peopleIdsBefore = ctx.Peoples.Select(e => e.Id).OrderBy(e => e).ToArray();
}
// Reversed order, so the list order of both mappings has to be rewritten.
_repository.UpdatePeople(_itemId, [
CreatePerson("Person B", PersonKind.Actor, "Sidekick"),
CreatePerson("Person A", PersonKind.Actor, "Hero")
]);
using var after = CreateDbContext();
Assert.Equal(peopleIdsBefore, after.Peoples.Select(e => e.Id).OrderBy(e => e).ToArray());
Assert.Equal(
["Sidekick", "Hero"],
after.PeopleBaseItemMap.OrderBy(e => e.ListOrder).Select(e => e.Role ?? string.Empty).ToArray());
}
[Fact]
public void UpdatePeople_CreditRemoved_DropsOnlyThatMapping()
{
_repository.UpdatePeople(_itemId, [
CreatePerson("Person A", PersonKind.Writer, "Novel"),
CreatePerson("Person A", PersonKind.Writer, "Screenplay")
]);
_repository.UpdatePeople(_itemId, [
CreatePerson("Person A", PersonKind.Writer, "Novel")
]);
using var ctx = CreateDbContext();
var map = Assert.Single(ctx.PeopleBaseItemMap);
Assert.Equal("Novel", map.Role);
}
[Fact]
public void UpdatePeople_RoleCaseChanged_KeepsExistingMapping()
{
_repository.UpdatePeople(_itemId, [CreatePerson("Person A", PersonKind.Actor, "Hero")]);
_repository.UpdatePeople(_itemId, [CreatePerson("Person A", PersonKind.Actor, "HERO")]);
using var ctx = CreateDbContext();
var map = Assert.Single(ctx.PeopleBaseItemMap);
Assert.Equal("Hero", map.Role);
}
[Fact]
public void UpdatePeople_CreditDroppedByTheProvider_LeavesNoCreditRowBehind()
{
_repository.UpdatePeople(_itemId, [
CreatePerson("Person A", PersonKind.Actor, "Hero"),
CreatePerson("Person B", PersonKind.Actor, "Villain")
]);
_repository.UpdatePeople(_itemId, [CreatePerson("Person A", PersonKind.Actor, "Hero")]);
using var ctx = CreateDbContext();
Assert.Equal(["Person A"], ctx.Peoples.Select(e => e.Name).ToArray());
}
[Fact]
public void UpdatePeople_CreditStillHeldByAnotherItem_IsKept()
{
_repository.UpdatePeople(_itemId, [CreatePerson("Person A", PersonKind.Actor, "Hero")]);
_repository.UpdatePeople(AddMovie("Other Movie"), [CreatePerson("Person A", PersonKind.Actor, "Hero")]);
_repository.UpdatePeople(_itemId, []);
using var after = CreateDbContext();
Assert.Single(after.Peoples);
Assert.Single(after.PeopleBaseItemMap);
}
[Fact]
public void DeleteOrphanedCredits_CreditNoItemMapsTo_IsDeleted()
{
_repository.UpdatePeople(_itemId, [CreatePerson("Person A", PersonKind.Actor, "Hero")]);
using (var ctx = CreateDbContext())
{
// The state a credit was left in before UpdatePeople cleaned up after itself.
ctx.PeopleBaseItemMap.RemoveRange(ctx.PeopleBaseItemMap);
ctx.SaveChanges();
}
Assert.Equal(1, _repository.DeleteOrphanedCredits());
using var after = CreateDbContext();
Assert.Empty(after.Peoples);
}
[Fact]
public void DeleteOrphanedCredits_CreditAnItemMapsTo_IsKept()
{
_repository.UpdatePeople(_itemId, [CreatePerson("Person A", PersonKind.Actor, "Hero")]);
Assert.Equal(0, _repository.DeleteOrphanedCredits());
using var after = CreateDbContext();
Assert.Single(after.Peoples);
}
private Guid AddMovie(string name)
{
var id = Guid.NewGuid();
using var ctx = CreateDbContext();
ctx.BaseItems.Add(new BaseItemEntity
{
Id = id,
Type = new ItemTypeLookup().BaseItemKindNames[BaseItemKind.Movie],
Name = name,
MediaType = "Video",
IsMovie = true,
IsFolder = false,
IsVirtualItem = false
});
ctx.SaveChanges();
return id;
}
private static PersonInfo CreatePerson(string name, PersonKind type, string role)
{
return new PersonInfo
{
Name = name,
Type = type,
Role = role
};
}
}
|
