1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
|
using System;
using System.Collections.Generic;
using System.IO;
using Jellyfin.Data.Enums;
using MediaBrowser.Common.Configuration;
using MediaBrowser.Controller.IO;
using MediaBrowser.Controller.Library;
using MediaBrowser.Controller.MediaEncoding;
using MediaBrowser.Controller.Streaming;
using MediaBrowser.Model.Configuration;
using MediaBrowser.Model.Dlna;
using MediaBrowser.Model.Dto;
using MediaBrowser.Model.Entities;
using Moq;
using Xunit;
using IConfiguration = Microsoft.Extensions.Configuration.IConfiguration;
namespace Jellyfin.Controller.Tests.MediaEncoding;
public class EncodingHelperTests
{
[Fact]
public void GetMapArgs_NoSubtitle_ExcludesAllSubs()
{
var state = BuildState(subtitle: null, deliveryMethod: null);
var args = CreateHelper().GetMapArgs(state);
Assert.Contains("-map -0:s", args, StringComparison.Ordinal);
Assert.DoesNotContain("-map 1:", args, StringComparison.Ordinal);
}
[Fact]
public void GetMapArgs_InternalSrt_MapsFromPrimaryInput()
{
var sub = new MediaStream { Index = 2, Type = MediaStreamType.Subtitle, Codec = "srt" };
var state = BuildState(sub, SubtitleDeliveryMethod.Embed);
var args = CreateHelper().GetMapArgs(state);
Assert.Contains("-map 0:2", args, StringComparison.Ordinal);
Assert.DoesNotContain("-map 1:", args, StringComparison.Ordinal);
}
[Fact]
public void GetMapArgs_InternalSubAtHigherIndex_MapsCorrectIndex()
{
var sub0 = new MediaStream { Index = 2, Type = MediaStreamType.Subtitle, Codec = "srt" };
var sub1 = new MediaStream { Index = 3, Type = MediaStreamType.Subtitle, Codec = "ass" };
var state = BuildState(sub1, SubtitleDeliveryMethod.Embed, additionalStreams: [sub0, sub1]);
var args = CreateHelper().GetMapArgs(state);
Assert.Contains("-map 0:3", args, StringComparison.Ordinal);
}
[Fact]
public void GetMapArgs_ExternalSrt_MapsFirstStreamFromInput1()
{
var sub = new MediaStream
{
Index = 2,
Type = MediaStreamType.Subtitle,
Codec = "srt",
IsExternal = true,
SupportsExternalStream = true,
Path = "/media/movie.en.srt"
};
var state = BuildState(sub, SubtitleDeliveryMethod.Embed);
var args = CreateHelper().GetMapArgs(state);
Assert.Contains("-map 1:0", args, StringComparison.Ordinal);
}
[Fact]
public void GetMapArgs_SecondExternalSrt_StillMaps1Colon0()
{
// Two separate .srt files — selecting the second one still maps 1:0
// because Jellyfin feeds only the selected file as ffmpeg input 1.
var ext1 = new MediaStream
{
Index = 2,
Type = MediaStreamType.Subtitle,
Codec = "srt",
IsExternal = true,
SupportsExternalStream = true,
Path = "/media/movie.en.srt"
};
var ext2 = new MediaStream
{
Index = 3,
Type = MediaStreamType.Subtitle,
Codec = "srt",
IsExternal = true,
SupportsExternalStream = true,
Path = "/media/movie.fr.srt"
};
var state = BuildState(ext2, SubtitleDeliveryMethod.Embed, additionalStreams: [ext1, ext2]);
var args = CreateHelper().GetMapArgs(state);
Assert.Contains("-map 1:0", args, StringComparison.Ordinal);
}
[Fact]
public void GetMapArgs_MksFirstTrack_MapsInFileIndex0()
{
var mks0 = new MediaStream
{
Index = 2,
Type = MediaStreamType.Subtitle,
Codec = "subrip",
IsExternal = true,
SupportsExternalStream = true,
Path = "/media/movie.mks"
};
var mks1 = new MediaStream
{
Index = 3,
Type = MediaStreamType.Subtitle,
Codec = "ass",
IsExternal = true,
SupportsExternalStream = true,
Path = "/media/movie.mks"
};
var state = BuildState(mks0, SubtitleDeliveryMethod.Embed, additionalStreams: [mks0, mks1]);
var args = CreateHelper().GetMapArgs(state);
Assert.Contains("-map 1:0", args, StringComparison.Ordinal);
}
[Fact]
public void GetMapArgs_MksSecondTrack_MapsInFileIndex1()
{
var mks0 = new MediaStream
{
Index = 2,
Type = MediaStreamType.Subtitle,
Codec = "subrip",
IsExternal = true,
SupportsExternalStream = true,
Path = "/media/movie.mks"
};
var mks1 = new MediaStream
{
Index = 3,
Type = MediaStreamType.Subtitle,
Codec = "ass",
IsExternal = true,
SupportsExternalStream = true,
Path = "/media/movie.mks"
};
var mks2 = new MediaStream
{
Index = 4,
Type = MediaStreamType.Subtitle,
Codec = "subrip",
IsExternal = true,
SupportsExternalStream = true,
Path = "/media/movie.mks"
};
var state = BuildState(mks1, SubtitleDeliveryMethod.Embed, additionalStreams: [mks0, mks1, mks2]);
var args = CreateHelper().GetMapArgs(state);
Assert.Contains("-map 1:1", args, StringComparison.Ordinal);
}
[Theory]
[InlineData(SubtitleDeliveryMethod.Embed, true, "movie.idx")]
[InlineData(SubtitleDeliveryMethod.Encode, true, "movie.idx")]
[InlineData(SubtitleDeliveryMethod.Embed, false, "movie.sub")]
[InlineData(SubtitleDeliveryMethod.Encode, false, "movie.sub")]
public void GetInputArgument_VobSub_UsesCorrectPath(
SubtitleDeliveryMethod deliveryMethod,
bool createIdxFile,
string expectedFilename)
{
var tempDir = Directory.CreateTempSubdirectory("jellyfin-test-");
try
{
var subFile = Path.Combine(tempDir.FullName, "movie.sub");
File.WriteAllText(subFile, "dummy");
if (createIdxFile)
{
File.WriteAllText(Path.Combine(tempDir.FullName, "movie.idx"), "dummy");
}
var sub = new MediaStream
{
Index = 2,
Type = MediaStreamType.Subtitle,
Codec = "dvdsub",
IsExternal = true,
SupportsExternalStream = true,
Path = subFile
};
var state = BuildState(sub, deliveryMethod);
var inputArgs = CreateHelper().GetInputArgument(state, new EncodingOptions(), null);
Assert.Contains(expectedFilename, inputArgs, StringComparison.Ordinal);
}
finally
{
tempDir.Delete(true);
}
}
private static EncodingJobInfo BuildState(
MediaStream? subtitle,
SubtitleDeliveryMethod? deliveryMethod,
MediaStream[]? additionalStreams = null)
{
var video = new MediaStream { Index = 0, Type = MediaStreamType.Video, Codec = "h264" };
var audio = new MediaStream { Index = 1, Type = MediaStreamType.Audio, Codec = "aac" };
var streams = new List<MediaStream> { video, audio };
if (additionalStreams is not null)
{
streams.AddRange(additionalStreams);
}
else if (subtitle is not null)
{
streams.Add(subtitle);
}
return new EncodingJobInfo(TranscodingJobType.Progressive)
{
MediaSource = new MediaSourceInfo
{
Container = "mkv",
MediaStreams = streams,
},
VideoStream = video,
AudioStream = audio,
SubtitleStream = subtitle,
SubtitleDeliveryMethod = deliveryMethod ?? SubtitleDeliveryMethod.Drop,
BaseRequest = new VideoRequestDto(),
IsVideoRequest = true,
IsInputVideo = true,
};
}
private static EncodingHelper CreateHelper()
{
var appPaths = Mock.Of<IApplicationPaths>();
var mediaEncoder = new Mock<IMediaEncoder>();
var subtitleEncoder = new Mock<ISubtitleEncoder>();
var config = new Mock<IConfiguration>();
var configurationManager = new Mock<IConfigurationManager>();
var pathManager = new Mock<IPathManager>();
return new EncodingHelper(
appPaths,
mediaEncoder.Object,
subtitleEncoder.Object,
config.Object,
configurationManager.Object,
pathManager.Object);
}
}
|
