tests/Jellyfin.Controller.Tests/ClientEventLoggerTests.cs


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44

using System;
using System.IO;
using System.Text;
using System.Threading.Tasks;
using MediaBrowser.Controller;
using MediaBrowser.Controller.ClientEvent;
using Moq;
using Xunit;

namespace Jellyfin.Controller.Tests
{
    public class ClientEventLoggerTests
    {
        [Theory]
        [InlineData("../../../../etc/passwd", "1.0")]
        [InlineData("..\\..\\windows\\system32", "1.0")]
        [InlineData("normal-client", "../../../etc/passwd")]
        [InlineData("/absolute/path", "1.0")]
        public async Task WriteDocumentAsync_TraversalInput_StaysInsideLogDirectory(string clientName, string clientVersion)
        {
            var logDir = Path.Combine(Path.GetTempPath(), "jellyfin-clientlog-test-" + Path.GetRandomFileName());
            Directory.CreateDirectory(logDir);
            try
            {
                var paths = new Mock<IServerApplicationPaths>();
                paths.Setup(p => p.LogDirectoryPath).Returns(logDir);

                var logger = new ClientEventLogger(paths.Object);
                using var contents = new MemoryStream(Encoding.UTF8.GetBytes("payload"));

                var fileName = await logger.WriteDocumentAsync(clientName, clientVersion, contents);

                var resolved = Path.GetFullPath(Path.Combine(logDir, fileName));
                var rootWithSep = Path.GetFullPath(logDir) + Path.DirectorySeparatorChar;
                Assert.StartsWith(rootWithSep, resolved, StringComparison.Ordinal);
                Assert.True(File.Exists(resolved));
            }
            finally
            {
                Directory.Delete(logDir, recursive: true);
            }
        }
    }
}