aboutsummaryrefslogtreecommitdiff
path: root/MediaBrowser.MediaEncoding/Attachments
AgeCommit message (Collapse)Author
2026-11-01Always extract attachments individuallyHoshino Lina
Since e627c723, attachments can be extracted by filename in one ffmpeg command. This makes the auto-filename codepath redundant. Letting ffmpeg extract all attachments is broken in ffmpeg upstream. This was worked around in jellyfin/jellyfin-ffmpeg#720 but affects distributions that do not use jellyfin-ffmpeg. Since there is no good reason to keep this codepath, just delete it. This obsoletes the above ffmpeg patch and should be more robust in the future, since Jellyfin no longer depends on guessing exactly what behavior ffmpeg has when constructing, allowing, or denying attachment filenames.
2026-08-20Normalize fix, apply in more placesCody Robibero
2026-07-21Apply review suggestionsShadowghost
2026-07-17Sanitize media attachment and lyric paths against traversalShadowghost
2026-05-23Extract attachments in one ffmpeg command when dumpingShadowghost
2026-05-21Run tree-wide dotnet formatjakobkukla
2026-05-12Safeguard against invalid GUIDs (#16813)Tim Eisele
Safeguard against invalid GUIDs
2026-03-29Fix attachment extraction of files without video or audio stream (#16312)Tim Eisele
* Fix attachment extraction of files without video or audio stream * Apply review suggestions
2025-05-04Cleanup file related code (#14023)Bond-009
2025-04-26Optimize migrations (#13855)Tim Eisele
2025-04-03Cleanup extracted files (#13760)Tim Eisele
* Cleanup extracted files * Pagination and fixes * Add migration for attachments to MigrateLibraryDb * Unify attachment handling * Don't extract again if files were already extracted * Fix MKS attachment extraction * Always run full extraction on mks * Don't try to extract mjpeg streams as attachments * Fallback to check if attachments were extracted to cache folder * Fixup
2024-09-07Backport pull request #12575 from jellyfin/release-10.9.zdmitrylyzo
Fix subtitle and attachment extraction when input path contains quotes Original-merge: 3c3ebe834462bbb7630ca4fc0c106cc51ca80e50 Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-08-25Backport pull request #12443 from jellyfin/release-10.9.zgnattu
Check attachment path for null before use Original-merge: 122da8f4473483353767e325539737f05a044527 Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-01Backport pull request #11812 from jellyfin/release-10.9.zgnattu
Extract media attachment one by one if the filename appears to be a path Original-merge: 45e8872cc086fe2b086e209a08839b3ff689ecf3 Merged-by: crobibero <cody@robibe.ro> Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-05Clean up synchronization (#11458)Mark Cilia Vincenti
2024-03-08Specify file as concat when extracting attachmentsCody Robibero
2024-03-03Extract and cache all media attachments in bulk (#11029)Attila Szakacs
Similar to https://github.com/jellyfin/jellyfin/pull/10884 --- Jellyfin clients need fonts for subtitles, and each font is a separate attachment, which causes a lot of re-reads of the file. Certain contents, like anime in a lot of cases, contain 50-80 different attachments. Spawning 80 ffmpeg processes at the same time on the same file might cause swapping on slower HDDs and can bring disk subsystem to a crawl. (For more info, see https://github.com/jellyfin/jellyfin/3215) This change helps a lot in this scenario. Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
2024-01-03AsyncKeyedLock migrationMark Cilia Vincenti
2023-10-10Use Process.WaitForExitAsync added in .NET 5Bond_009
2023-10-06Reduce string allocationsBond_009
Some simple changes to reduce the number of allocated strings
2023-04-06Remove redundant 'else' keywordsStepan Goremykin
2023-04-06Fix duplicate properties in message template warningStepan Goremykin
2023-03-09Backport pull request #9178 from jellyfin/release-10.8.zRóbert Örn Ketilsson
Escape the path to pass as a command line argument Original-merge: 09f1c7f535653e99dbc22ace7cd166ce4c457a83 Merged-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com> Backported-by: crobibero <cody@robibe.ro>
2022-12-07Use ArgumentException.ThrowIfNullOrEmptyBond_009
2022-12-05Replace == null with is nullBond_009
2022-10-06Use ArgumentNullException.ThrowIfNull helper methodBond_009
Did a simple search/replace on the whole repo (except the RSSDP project) This reduces LOC and should improve performance (methods containing a throw statement don't get inlined) ``` if \((\w+) == null\) \s+\{ \s+throw new ArgumentNullException\((.*)\); \s+\} ``` ``` ArgumentNullException.ThrowIfNull($1); ```
2022-03-22Fix releasing lockNils Fürniß
2022-03-22Improve codeNils Fürniß
2022-03-22 add extracting attachments from external subsNils Fürniß
2022-02-10add extracting attachments for ffmpeg to burn subsNils Fürniß
2021-12-27Remove more warningsCody Robibero
2021-11-09Fix some warningsBond_009
down to 580
2021-09-02Use async FileStreams where it makes senseBond_009
2021-05-20Enable nullable reference types for MediaBrowser.MediaEncoding.SubtitlesBond_009
2020-12-01Merge pull request #4169 from stanionascu/bdiso-playbackJoshua M. Boniface
Playback (direct-stream/transcode) of BDISO/BDAV containers
2020-11-13Fix nullability errors in MediaBrowser.MediaEncodingcrobibero
2020-10-01Remove PlayableStreamFileNames as unusedStanislav Ionascu
Since ffmpeg can play and transcode ISO files and BDMV folders directly, there's no use of that property.
2020-10-01Add probe / direct-stream / transcoding support for BluRaysStanislav Ionascu
This commit (and ffmpeg built with libbluray support), adds support for playback of bluray images (bd-iso) and bluray folders.
2020-08-20Make MediaBrowser.MediaEncoding warnings freeBond_009
2020-08-04Enable TreatWarningsAsErrors for MediaBrowser.MediaEncodingBond-009
2020-06-15fix SA1508telans
2020-06-05Use typed logger where possiblecrobibero
2020-04-11Fix style issuesMark Monteiro
2020-04-11Use a separate line for each property initializerMark Monteiro
2020-04-03Merge remote-tracking branch 'upstream/master' into remove-common-processMark Monteiro
2020-04-03Add missing call to ConfigureAwait()Mark Monteiro
2020-03-27Dispose of process correctly in AttachmentExtractorMark Monteiro
2020-03-27Use WaitForExitAsync extension method in AttachmentExtractorMark Monteiro
2020-03-24Remove unused usingsBond_009
2020-01-11Fix buildBond_009