aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
Diffstat (limited to 'tests')
-rw-r--r--tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs41
-rw-r--r--tests/Jellyfin.Providers.Tests/MediaInfo/AudioResolverTests.cs177
-rw-r--r--tests/Jellyfin.Providers.Tests/MediaInfo/SubtitleResolverTests.cs203
-rw-r--r--tests/Jellyfin.Providers.Tests/Test Data/Video/My.Video.mkv0
4 files changed, 314 insertions, 107 deletions
diff --git a/tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs b/tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs
deleted file mode 100644
index 2446660f3..000000000
--- a/tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs
+++ /dev/null
@@ -1,41 +0,0 @@
-using Emby.Naming.Common;
-using Emby.Naming.Subtitles;
-using Xunit;
-
-namespace Jellyfin.Naming.Tests.Subtitles
-{
- public class SubtitleParserTests
- {
- private readonly NamingOptions _namingOptions = new NamingOptions();
-
- [Theory]
- [InlineData("The Skin I Live In (2011).srt", null, false, false)]
- [InlineData("The Skin I Live In (2011).eng.srt", "eng", false, false)]
- [InlineData("The Skin I Live In (2011).eng.default.srt", "eng", true, false)]
- [InlineData("The Skin I Live In (2011).eng.forced.srt", "eng", false, true)]
- [InlineData("The Skin I Live In (2011).eng.foreign.srt", "eng", false, true)]
- [InlineData("The Skin I Live In (2011).eng.default.foreign.srt", "eng", true, true)]
- [InlineData("The Skin I Live In (2011).default.foreign.eng.srt", "eng", true, true)]
- public void SubtitleParser_ValidFileName_Parses(string input, string language, bool isDefault, bool isForced)
- {
- var parser = new SubtitleParser(_namingOptions);
-
- var result = parser.ParseFile(input);
-
- Assert.Equal(language, result?.Language, true);
- Assert.Equal(isDefault, result?.IsDefault);
- Assert.Equal(isForced, result?.IsForced);
- Assert.Equal(input, result?.Path);
- }
-
- [Theory]
- [InlineData("The Skin I Live In (2011).mp4")]
- [InlineData("")]
- public void SubtitleParser_InvalidFileName_ReturnsNull(string input)
- {
- var parser = new SubtitleParser(_namingOptions);
-
- Assert.Null(parser.ParseFile(input));
- }
- }
-}
diff --git a/tests/Jellyfin.Providers.Tests/MediaInfo/AudioResolverTests.cs b/tests/Jellyfin.Providers.Tests/MediaInfo/AudioResolverTests.cs
new file mode 100644
index 000000000..69f10d670
--- /dev/null
+++ b/tests/Jellyfin.Providers.Tests/MediaInfo/AudioResolverTests.cs
@@ -0,0 +1,177 @@
+using System;
+using System.Collections.Generic;
+using System.Text.RegularExpressions;
+using System.Threading;
+using System.Threading.Tasks;
+using Emby.Naming.Common;
+using MediaBrowser.Controller.Entities;
+using MediaBrowser.Controller.Library;
+using MediaBrowser.Controller.MediaEncoding;
+using MediaBrowser.Controller.Providers;
+using MediaBrowser.Model.Entities;
+using MediaBrowser.Model.Globalization;
+using MediaBrowser.Providers.MediaInfo;
+using Moq;
+using Xunit;
+
+namespace Jellyfin.Providers.Tests.MediaInfo
+{
+ public class AudioResolverTests
+ {
+ private const string VideoDirectoryPath = "Test Data/Video";
+ private const string MetadataDirectoryPath = "Test Data/Metadata";
+ private readonly AudioResolver _audioResolver;
+
+ public AudioResolverTests()
+ {
+ var englishCultureDto = new CultureDto("English", "English", "en", new[] { "eng" });
+
+ var localizationManager = new Mock<ILocalizationManager>(MockBehavior.Loose);
+ localizationManager.Setup(lm => lm.FindLanguageInfo(It.IsRegex(@"en.*", RegexOptions.IgnoreCase)))
+ .Returns(englishCultureDto);
+
+ var mediaEncoder = new Mock<IMediaEncoder>(MockBehavior.Strict);
+ mediaEncoder.Setup(me => me.GetMediaInfo(It.IsAny<MediaInfoRequest>(), It.IsAny<CancellationToken>()))
+ .Returns<MediaInfoRequest, CancellationToken>((_, _) => Task.FromResult(new MediaBrowser.Model.MediaInfo.MediaInfo
+ {
+ MediaStreams = new List<MediaStream>
+ {
+ new()
+ }
+ }));
+
+ _audioResolver = new AudioResolver(localizationManager.Object, mediaEncoder.Object, new NamingOptions());
+ }
+
+ [Fact]
+ public async void AddExternalStreamsAsync_GivenMixedFilenames_ReturnsValidSubtitles()
+ {
+ var startIndex = 0;
+ var index = startIndex;
+ var files = new[]
+ {
+ VideoDirectoryPath + "/MyVideo.en.aac",
+ VideoDirectoryPath + "/MyVideo.en.forced.default.dts",
+ VideoDirectoryPath + "/My.Video.mp3",
+ VideoDirectoryPath + "/Some.Other.Video.mp3",
+ VideoDirectoryPath + "/My.Video.png",
+ VideoDirectoryPath + "/My.Video.srt",
+ VideoDirectoryPath + "/My.Video.txt",
+ VideoDirectoryPath + "/My.Video.vtt",
+ VideoDirectoryPath + "/My.Video.ass",
+ VideoDirectoryPath + "/My.Video.sub",
+ VideoDirectoryPath + "/My.Video.ssa",
+ VideoDirectoryPath + "/My.Video.smi",
+ VideoDirectoryPath + "/My.Video.sami",
+ VideoDirectoryPath + "/My.Video.en.mp3",
+ VideoDirectoryPath + "/My.Video.en.forced.mp3",
+ VideoDirectoryPath + "/My.Video.en.default.forced.aac",
+ VideoDirectoryPath + "/My.Video.Label.mp3",
+ VideoDirectoryPath + "/My.Video.With Additional Garbage.en.aac",
+ VideoDirectoryPath + "/My.Video.With.Additional.Garbage.en.mp3"
+ };
+ var metadataFiles = new[]
+ {
+ MetadataDirectoryPath + "/My.Video.en.aac"
+ };
+ var expectedResult = new[]
+ {
+ CreateMediaStream(VideoDirectoryPath + "/MyVideo.en.aac", "eng", null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/MyVideo.en.forced.default.dts", "eng", null, index++, isDefault: true, isForced: true),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.mp3", null, null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.en.mp3", "eng", null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.en.forced.mp3", "eng", null, index++, isDefault: false, isForced: true),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.en.default.forced.aac", "eng", null, index++, isDefault: true, isForced: true),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.Label.mp3", null, "Label", index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.With Additional Garbage.en.aac", "eng", "With Additional Garbage", index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.With.Additional.Garbage.en.mp3", "eng", "With.Additional.Garbage", index++),
+ CreateMediaStream(MetadataDirectoryPath + "/My.Video.en.aac", "eng", null, index)
+ };
+
+ BaseItem.MediaSourceManager = Mock.Of<IMediaSourceManager>();
+
+ var video = new Mock<Video>();
+ video.CallBase = true;
+ video.Setup(moq => moq.Path).Returns(VideoDirectoryPath + "/My.Video.mkv");
+ video.Setup(moq => moq.GetInternalMetadataPath()).Returns(MetadataDirectoryPath);
+
+ var directoryService = new Mock<IDirectoryService>(MockBehavior.Strict);
+ directoryService.Setup(ds => ds.GetFilePaths(It.IsRegex(@"Test Data[/\\]Video"), It.IsAny<bool>(), It.IsAny<bool>()))
+ .Returns(files);
+ directoryService.Setup(ds => ds.GetFilePaths(It.IsRegex(@"Test Data[/\\]Metadata"), It.IsAny<bool>(), It.IsAny<bool>()))
+ .Returns(metadataFiles);
+
+ var streams = await _audioResolver.GetExternalStreamsAsync(video.Object, startIndex, directoryService.Object, false, CancellationToken.None);
+
+ Assert.Equal(expectedResult.Length, streams.Count);
+ for (var i = 0; i < expectedResult.Length; i++)
+ {
+ var expected = expectedResult[i];
+ var actual = streams[i];
+
+ Assert.Equal(expected.Index, actual.Index);
+ Assert.Equal(expected.Type, actual.Type);
+ Assert.Equal(expected.IsExternal, actual.IsExternal);
+ Assert.Equal(expected.Path, actual.Path);
+ Assert.Equal(expected.Language, actual.Language);
+ Assert.Equal(expected.Title, actual.Title);
+ }
+ }
+
+ [Theory]
+ [InlineData("MyVideo.en.aac", "eng", null, false, false)]
+ [InlineData("MyVideo.en.forced.default.dts", "eng", null, true, true)]
+ [InlineData("My.Video.mp3", null, null, false, false)]
+ [InlineData("My.Video.English.mp3", "eng", null, false, false)]
+ [InlineData("My.Video.Title.mp3", null, "Title", false, false)]
+ [InlineData("My.Video.forced.English.mp3", "eng", null, true, false)]
+ [InlineData("My.Video.default.English.mp3", "eng", null, false, true)]
+ [InlineData("My.Video.English.forced.default.Title.mp3", "eng", "Title", true, true)]
+ public async void AddExternalStreamsAsync_GivenSingleFile_ReturnsExpectedStream(string file, string? language, string? title, bool isForced, bool isDefault)
+ {
+ BaseItem.MediaSourceManager = Mock.Of<IMediaSourceManager>();
+
+ var video = new Mock<Video>();
+ video.CallBase = true;
+ video.Setup(moq => moq.Path).Returns(VideoDirectoryPath + "/My.Video.mkv");
+ video.Setup(moq => moq.GetInternalMetadataPath()).Returns(MetadataDirectoryPath);
+
+ var directoryService = new Mock<IDirectoryService>(MockBehavior.Strict);
+ directoryService.Setup(ds => ds.GetFilePaths(It.IsRegex(@"Test Data[/\\]Video"), It.IsAny<bool>(), It.IsAny<bool>()))
+ .Returns(new[] { VideoDirectoryPath + "/" + file });
+ directoryService.Setup(ds => ds.GetFilePaths(It.IsRegex(@"Test Data[/\\]Metadata"), It.IsAny<bool>(), It.IsAny<bool>()))
+ .Returns(Array.Empty<string>());
+
+ var streams = await _audioResolver.GetExternalStreamsAsync(video.Object, 0, directoryService.Object, false, CancellationToken.None);
+
+ Assert.Single(streams);
+
+ var actual = streams[0];
+
+ var expected = CreateMediaStream(VideoDirectoryPath + "/" + file, language, title, 0, isForced, isDefault);
+ Assert.Equal(expected.Index, actual.Index);
+ Assert.Equal(expected.Type, actual.Type);
+ Assert.Equal(expected.IsExternal, actual.IsExternal);
+ Assert.Equal(expected.Path, actual.Path);
+ Assert.Equal(expected.Language, actual.Language);
+ Assert.Equal(expected.Title, actual.Title);
+ Assert.Equal(expected.IsDefault, actual.IsDefault);
+ Assert.Equal(expected.IsForced, actual.IsForced);
+ }
+
+ private static MediaStream CreateMediaStream(string path, string? language, string? title, int index, bool isForced = false, bool isDefault = false)
+ {
+ return new()
+ {
+ Index = index,
+ Type = MediaStreamType.Audio,
+ IsExternal = true,
+ Path = path,
+ Language = language,
+ Title = title,
+ IsForced = isForced,
+ IsDefault = isDefault
+ };
+ }
+ }
+}
diff --git a/tests/Jellyfin.Providers.Tests/MediaInfo/SubtitleResolverTests.cs b/tests/Jellyfin.Providers.Tests/MediaInfo/SubtitleResolverTests.cs
index 040ea5d1d..2532d8926 100644
--- a/tests/Jellyfin.Providers.Tests/MediaInfo/SubtitleResolverTests.cs
+++ b/tests/Jellyfin.Providers.Tests/MediaInfo/SubtitleResolverTests.cs
@@ -1,6 +1,13 @@
-#pragma warning disable CA1002 // Do not expose generic lists
-
+using System;
using System.Collections.Generic;
+using System.Text.RegularExpressions;
+using System.Threading;
+using System.Threading.Tasks;
+using Emby.Naming.Common;
+using MediaBrowser.Controller.Entities;
+using MediaBrowser.Controller.Library;
+using MediaBrowser.Controller.MediaEncoding;
+using MediaBrowser.Controller.Providers;
using MediaBrowser.Model.Entities;
using MediaBrowser.Model.Globalization;
using MediaBrowser.Providers.MediaInfo;
@@ -11,58 +18,103 @@ namespace Jellyfin.Providers.Tests.MediaInfo
{
public class SubtitleResolverTests
{
- public static TheoryData<List<MediaStream>, string, int, string[], MediaStream[]> AddExternalSubtitleStreams_GivenMixedFilenames_ReturnsValidSubtitles_TestData()
+ private const string VideoDirectoryPath = "Test Data/Video";
+ private const string MetadataDirectoryPath = "Test Data/Metadata";
+ private readonly SubtitleResolver _subtitleResolver;
+
+ public SubtitleResolverTests()
{
- var data = new TheoryData<List<MediaStream>, string, int, string[], MediaStream[]>();
-
- var index = 0;
- data.Add(
- new List<MediaStream>(),
- "/video/My.Video.mkv",
- index,
- new[]
- {
- "/video/My.Video.mp3",
- "/video/My.Video.png",
- "/video/My.Video.srt",
- "/video/My.Video.txt",
- "/video/My.Video.vtt",
- "/video/My.Video.ass",
- "/video/My.Video.sub",
- "/video/My.Video.ssa",
- "/video/My.Video.smi",
- "/video/My.Video.sami",
- "/video/My.Video.en.srt",
- "/video/My.Video.default.en.srt",
- "/video/My.Video.default.forced.en.srt",
- "/video/My.Video.en.default.forced.srt",
- "/video/My.Video.With.Additional.Garbage.en.srt",
- "/video/My.Video With Additional Garbage.srt"
- },
- new[]
+ var englishCultureDto = new CultureDto("English", "English", "en", new[] { "eng" });
+ var frenchCultureDto = new CultureDto("French", "French", "fr", new[] { "fre", "fra" });
+
+ var localizationManager = new Mock<ILocalizationManager>(MockBehavior.Loose);
+ localizationManager.Setup(lm => lm.FindLanguageInfo(It.IsRegex(@"en.*", RegexOptions.IgnoreCase)))
+ .Returns(englishCultureDto);
+ localizationManager.Setup(lm => lm.FindLanguageInfo(It.IsRegex(@"fr.*", RegexOptions.IgnoreCase)))
+ .Returns(frenchCultureDto);
+
+ var mediaEncoder = new Mock<IMediaEncoder>(MockBehavior.Strict);
+ mediaEncoder.Setup(me => me.GetMediaInfo(It.IsAny<MediaInfoRequest>(), It.IsAny<CancellationToken>()))
+ .Returns<MediaInfoRequest, CancellationToken>((_, _) => Task.FromResult(new MediaBrowser.Model.MediaInfo.MediaInfo
{
- CreateMediaStream("/video/My.Video.srt", "srt", null, index++),
- CreateMediaStream("/video/My.Video.vtt", "vtt", null, index++),
- CreateMediaStream("/video/My.Video.ass", "ass", null, index++),
- CreateMediaStream("/video/My.Video.sub", "sub", null, index++),
- CreateMediaStream("/video/My.Video.ssa", "ssa", null, index++),
- CreateMediaStream("/video/My.Video.smi", "smi", null, index++),
- CreateMediaStream("/video/My.Video.sami", "sami", null, index++),
- CreateMediaStream("/video/My.Video.en.srt", "srt", "en", index++),
- CreateMediaStream("/video/My.Video.default.en.srt", "srt", "en", index++, isDefault: true),
- CreateMediaStream("/video/My.Video.default.forced.en.srt", "srt", "en", index++, isForced: true, isDefault: true),
- CreateMediaStream("/video/My.Video.en.default.forced.srt", "srt", "en", index++, isForced: true, isDefault: true),
- CreateMediaStream("/video/My.Video.With.Additional.Garbage.en.srt", "srt", "en", index),
- });
-
- return data;
+ MediaStreams = new List<MediaStream>
+ {
+ new()
+ }
+ }));
+
+ _subtitleResolver = new SubtitleResolver(localizationManager.Object, mediaEncoder.Object, new NamingOptions());
}
- [Theory]
- [MemberData(nameof(AddExternalSubtitleStreams_GivenMixedFilenames_ReturnsValidSubtitles_TestData))]
- public void AddExternalSubtitleStreams_GivenMixedFilenames_ReturnsValidSubtitles(List<MediaStream> streams, string videoPath, int startIndex, string[] files, MediaStream[] expectedResult)
+ [Fact]
+ public async void AddExternalStreamsAsync_GivenMixedFilenames_ReturnsValidSubtitles()
{
- new SubtitleResolver(Mock.Of<ILocalizationManager>()).AddExternalSubtitleStreams(streams, videoPath, startIndex, files);
+ var startIndex = 0;
+ var index = startIndex;
+ var files = new[]
+ {
+ VideoDirectoryPath + "/MyVideo.en.srt",
+ VideoDirectoryPath + "/MyVideo.en.forced.default.sub",
+ VideoDirectoryPath + "/My.Video.mp3",
+ VideoDirectoryPath + "/My.Video.png",
+ VideoDirectoryPath + "/My.Video.srt",
+ VideoDirectoryPath + "/My.Video.txt",
+ VideoDirectoryPath + "/My.Video.vtt",
+ VideoDirectoryPath + "/My.Video.ass",
+ VideoDirectoryPath + "/My.Video.sub",
+ VideoDirectoryPath + "/My.Video.ssa",
+ VideoDirectoryPath + "/My.Video.smi",
+ VideoDirectoryPath + "/My.Video.sami",
+ VideoDirectoryPath + "/My.Video.mks",
+ VideoDirectoryPath + "/My.Video.en.srt",
+ VideoDirectoryPath + "/My.Video.default.en.srt",
+ VideoDirectoryPath + "/My.Video.default.forced.en.srt",
+ VideoDirectoryPath + "/My.Video.en.default.forced.srt",
+ VideoDirectoryPath + "/My.Video.en.With Additional Garbage.sub",
+ VideoDirectoryPath + "/My.Video.With Additional Garbage.English.sub",
+ VideoDirectoryPath + "/My.Video.With.Additional.Garbage.en.srt",
+ VideoDirectoryPath + "/Some.Other.Video.srt"
+ };
+ var metadataFiles = new[]
+ {
+ MetadataDirectoryPath + "/My.Video.en.srt"
+ };
+ var expectedResult = new[]
+ {
+ CreateMediaStream(VideoDirectoryPath + "/MyVideo.en.srt", "srt", "eng", null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/MyVideo.en.forced.default.sub", "sub", "eng", null, index++, isDefault: true, isForced: true),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.srt", "srt", null, null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.vtt", "vtt", null, null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.ass", "ass", null, null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.sub", "sub", null, null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.ssa", "ssa", null, null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.smi", "smi", null, null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.sami", "sami", null, null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.mks", "mks", null, null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.en.srt", "srt", "eng", null, index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.default.en.srt", "srt", "eng", null, index++, isDefault: true),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.default.forced.en.srt", "srt", "eng", null, index++, isForced: true, isDefault: true),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.en.default.forced.srt", "srt", "eng", null, index++, isForced: true, isDefault: true),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.en.With Additional Garbage.sub", "sub", "eng", "With Additional Garbage", index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.With Additional Garbage.English.sub", "sub", "eng", "With Additional Garbage", index++),
+ CreateMediaStream(VideoDirectoryPath + "/My.Video.With.Additional.Garbage.en.srt", "srt", "eng", "With.Additional.Garbage", index++),
+ CreateMediaStream(MetadataDirectoryPath + "/My.Video.en.srt", "srt", "eng", null, index)
+ };
+
+ BaseItem.MediaSourceManager = Mock.Of<IMediaSourceManager>();
+
+ var video = new Mock<Video>();
+ video.CallBase = true;
+ video.Setup(moq => moq.Path).Returns(VideoDirectoryPath + "/My.Video.mkv");
+ video.Setup(moq => moq.GetInternalMetadataPath()).Returns(MetadataDirectoryPath);
+
+ var directoryService = new Mock<IDirectoryService>(MockBehavior.Strict);
+ directoryService.Setup(ds => ds.GetFilePaths(It.IsRegex(@"Test Data[/\\]Video"), It.IsAny<bool>(), It.IsAny<bool>()))
+ .Returns(files);
+ directoryService.Setup(ds => ds.GetFilePaths(It.IsRegex(@"Test Data[/\\]Metadata"), It.IsAny<bool>(), It.IsAny<bool>()))
+ .Returns(metadataFiles);
+
+ var streams = await _subtitleResolver.GetExternalStreamsAsync(video.Object, startIndex, directoryService.Object, false, CancellationToken.None);
Assert.Equal(expectedResult.Length, streams.Count);
for (var i = 0; i < expectedResult.Length; i++)
@@ -77,31 +129,48 @@ namespace Jellyfin.Providers.Tests.MediaInfo
Assert.Equal(expected.IsDefault, actual.IsDefault);
Assert.Equal(expected.IsForced, actual.IsForced);
Assert.Equal(expected.Language, actual.Language);
+ Assert.Equal(expected.Title, actual.Title);
}
}
[Theory]
- [InlineData("/video/My Video.mkv", "/video/My Video.srt", "srt", null, false, false)]
- [InlineData("/video/My.Video.mkv", "/video/My.Video.srt", "srt", null, false, false)]
- [InlineData("/video/My.Video.mkv", "/video/My.Video.foreign.srt", "srt", null, true, false)]
- [InlineData("/video/My Video.mkv", "/video/My Video.forced.srt", "srt", null, true, false)]
- [InlineData("/video/My.Video.mkv", "/video/My.Video.default.srt", "srt", null, false, true)]
- [InlineData("/video/My.Video.mkv", "/video/My.Video.forced.default.srt", "srt", null, true, true)]
- [InlineData("/video/My.Video.mkv", "/video/My.Video.en.srt", "srt", "en", false, false)]
- [InlineData("/video/My.Video.mkv", "/video/My.Video.default.en.srt", "srt", "en", false, true)]
- [InlineData("/video/My.Video.mkv", "/video/My.Video.default.forced.en.srt", "srt", "en", true, true)]
- [InlineData("/video/My.Video.mkv", "/video/My.Video.en.default.forced.srt", "srt", "en", true, true)]
- public void AddExternalSubtitleStreams_GivenSingleFile_ReturnsExpectedSubtitle(string videoPath, string file, string codec, string? language, bool isForced, bool isDefault)
+ [InlineData("MyVideo.en.srt", "srt", "eng", null, false, false)]
+ [InlineData("MyVideo.en.forced.default.srt", "srt", "eng", null, true, true)]
+ [InlineData("My.Video.srt", "srt", null, null, false, false)]
+ [InlineData("My.Video.foreign.srt", "srt", null, null, true, false)]
+ [InlineData("My.Video.default.srt", "srt", null, null, false, true)]
+ [InlineData("My.Video.forced.default.srt", "srt", null, null, true, true)]
+ [InlineData("My.Video.en.srt", "srt", "eng", null, false, false)]
+ [InlineData("My.Video.fr.en.srt", "srt", "eng", "fr", false, false)]
+ [InlineData("My.Video.en.fr.srt", "srt", "fre", "en", false, false)]
+ [InlineData("My.Video.default.en.srt", "srt", "eng", null, false, true)]
+ [InlineData("My.Video.default.forced.en.srt", "srt", "eng", null, true, true)]
+ [InlineData("My.Video.en.default.forced.srt", "srt", "eng", null, true, true)]
+ [InlineData("My.Video.Track Label.srt", "srt", null, "Track Label", false, false)]
+ [InlineData("My.Video.Track.Label.srt", "srt", null, "Track.Label", false, false)]
+ [InlineData("My.Video.Track Label.en.default.forced.srt", "srt", "eng", "Track Label", true, true)]
+ [InlineData("My.Video.en.default.forced.Track Label.srt", "srt", "eng", "Track Label", true, true)]
+ public async void AddExternalStreamsAsync_GivenSingleFile_ReturnsExpectedSubtitle(string file, string codec, string? language, string? title, bool isForced, bool isDefault)
{
- var streams = new List<MediaStream>();
- var expected = CreateMediaStream(file, codec, language, 0, isForced, isDefault);
+ BaseItem.MediaSourceManager = Mock.Of<IMediaSourceManager>();
- new SubtitleResolver(Mock.Of<ILocalizationManager>()).AddExternalSubtitleStreams(streams, videoPath, 0, new[] { file });
+ var video = new Mock<Video>();
+ video.CallBase = true;
+ video.Setup(moq => moq.Path).Returns(VideoDirectoryPath + "/My.Video.mkv");
+ video.Setup(moq => moq.GetInternalMetadataPath()).Returns(MetadataDirectoryPath);
- Assert.Single(streams);
+ var directoryService = new Mock<IDirectoryService>(MockBehavior.Strict);
+ directoryService.Setup(ds => ds.GetFilePaths(It.IsRegex(@"Test Data[/\\]Video"), It.IsAny<bool>(), It.IsAny<bool>()))
+ .Returns(new[] { VideoDirectoryPath + "/" + file });
+ directoryService.Setup(ds => ds.GetFilePaths(It.IsRegex(@"Test Data[/\\]Metadata"), It.IsAny<bool>(), It.IsAny<bool>()))
+ .Returns(Array.Empty<string>());
+ var streams = await _subtitleResolver.GetExternalStreamsAsync(video.Object, 0, directoryService.Object, false, CancellationToken.None);
+
+ Assert.Single(streams);
var actual = streams[0];
+ var expected = CreateMediaStream(VideoDirectoryPath + "/" + file, codec, language, title, 0, isForced, isDefault);
Assert.Equal(expected.Index, actual.Index);
Assert.Equal(expected.Type, actual.Type);
Assert.Equal(expected.IsExternal, actual.IsExternal);
@@ -109,9 +178,10 @@ namespace Jellyfin.Providers.Tests.MediaInfo
Assert.Equal(expected.IsDefault, actual.IsDefault);
Assert.Equal(expected.IsForced, actual.IsForced);
Assert.Equal(expected.Language, actual.Language);
+ Assert.Equal(expected.Title, actual.Title);
}
- private static MediaStream CreateMediaStream(string path, string codec, string? language, int index, bool isForced = false, bool isDefault = false)
+ private static MediaStream CreateMediaStream(string path, string codec, string? language, string? title, int index, bool isForced = false, bool isDefault = false)
{
return new()
{
@@ -122,7 +192,8 @@ namespace Jellyfin.Providers.Tests.MediaInfo
Path = path,
IsDefault = isDefault,
IsForced = isForced,
- Language = language
+ Language = language,
+ Title = title
};
}
}
diff --git a/tests/Jellyfin.Providers.Tests/Test Data/Video/My.Video.mkv b/tests/Jellyfin.Providers.Tests/Test Data/Video/My.Video.mkv
new file mode 100644
index 000000000..e69de29bb
--- /dev/null
+++ b/tests/Jellyfin.Providers.Tests/Test Data/Video/My.Video.mkv