Stop user updates from orphaning permission and preference rows (#17645)

* Stop user updates from orphaning permission and preference rows

* Make UserId non-nullable

* Remove unnecessary ToList

* Update Jellyfin.Server.Implementations/Users/UserManager.cs

Co-authored-by: Claus Vium <cvium@users.noreply.github.com>

---------

Co-authored-by: Claus Vium <cvium@users.noreply.github.com>

1 files changed, 0 insertions, 23 deletions

diff --git a/tests/Jellyfin.Server.Implementations.Tests/Users/UserManagerProfileImageTests.cs b/tests/Jellyfin.Server.Implementations.Tests/Users/UserManagerProfileImageTests.cs
index 778b888735..cb714a4014 100644
--- a/tests/Jellyfin.Server.Implementations.Tests/Users/UserManagerProfileImageTests.cs
+++ b/tests/Jellyfin.Server.Implementations.Tests/Users/UserManagerProfileImageTests.cs
@@ -1,6 +1,5 @@
 using System;
 using System.IO;
-using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using Jellyfin.Database.Implementations;
@@ -93,28 +92,6 @@ namespace Jellyfin.Server.Implementations.Tests.Users
         }
 
         [Fact]
-        public async Task UpdateUserAsync_DoesNotLeaveOrphanedPermissionsOrPreferences()
-        {
-            var user = await _userManager.CreateUserAsync("updateduser");
-            var permissionCount = user.Permissions.Count;
-            var preferenceCount = user.Preferences.Count;
-
-            user.LastActivityDate = DateTime.UtcNow;
-            await _userManager.UpdateUserAsync(user);
-            await _userManager.UpdateUserAsync(user);
-
-            await using var context = CreateDbContext();
-            Assert.Empty(await context.Permissions
-                .Where(permission => !permission.UserId.HasValue)
-                .ToListAsync(TestContext.Current.CancellationToken));
-            Assert.Empty(await context.Preferences
-                .Where(preference => !preference.UserId.HasValue)
-                .ToListAsync(TestContext.Current.CancellationToken));
-            Assert.Equal(permissionCount, await context.Permissions.CountAsync(TestContext.Current.CancellationToken));
-            Assert.Equal(preferenceCount, await context.Preferences.CountAsync(TestContext.Current.CancellationToken));
-        }
-
-        [Fact]
         public async Task ClearProfileImageAsync_WhenInMemoryImageHasTemporaryKey_RemovesPersistedImage()
         {
             var user = await _userManager.CreateUserAsync("profileimageuser");