aboutsummaryrefslogtreecommitdiff
path: root/tests/Jellyfin.Controller.Tests/Library
diff options
context:
space:
mode:
authorShadowghost <Ghost_of_Stone@web.de>2026-06-19 21:51:57 +0200
committerShadowghost <Ghost_of_Stone@web.de>2026-06-19 21:51:57 +0200
commit0fb042b7403ebd7578b696aba35ba0c582ccf6ba (patch)
treed7e46069c8500ecf5680283748448fc465b3ec6f /tests/Jellyfin.Controller.Tests/Library
parenta5706c2fa6b09019828b2a9c5c6822f5bfa3327f (diff)
Surface the played version for resume
Diffstat (limited to 'tests/Jellyfin.Controller.Tests/Library')
-rw-r--r--tests/Jellyfin.Controller.Tests/Library/VersionResumeDataTests.cs30
1 files changed, 17 insertions, 13 deletions
diff --git a/tests/Jellyfin.Controller.Tests/Library/VersionResumeDataTests.cs b/tests/Jellyfin.Controller.Tests/Library/VersionResumeDataTests.cs
index 5b0f003019..8642ab07f8 100644
--- a/tests/Jellyfin.Controller.Tests/Library/VersionResumeDataTests.cs
+++ b/tests/Jellyfin.Controller.Tests/Library/VersionResumeDataTests.cs
@@ -9,36 +9,40 @@ namespace Jellyfin.Controller.Tests.Library;
public class VersionResumeDataTests
{
[Fact]
- public void ApplyTo_OverridesResumeFieldsAndPercentage()
+ public void ApplyTo_PropagatesCompletionButNotPosition()
{
var lastPlayed = new DateTime(2026, 1, 2, 0, 0, 0, DateTimeKind.Utc);
var resume = new VersionResumeData(
- new UserItemData { Key = "version", PlaybackPositionTicks = 25, Played = true, LastPlayedDate = lastPlayed },
- RunTimeTicks: 100);
+ new UserItemData { Key = "version", PlaybackPositionTicks = 25, Played = true, LastPlayedDate = lastPlayed });
var dto = new UserItemDataDto { Key = "primary", PlaybackPositionTicks = 1, Played = false, PlayedPercentage = 1 };
resume.ApplyTo(dto);
- Assert.Equal(25, dto.PlaybackPositionTicks);
+ // Completion state propagates to the primary...
Assert.True(dto.Played);
Assert.Equal(lastPlayed, dto.LastPlayedDate);
- // The percentage is based on the resume version's own runtime, not the primary's.
- Assert.NotNull(dto.PlayedPercentage);
- Assert.Equal(25.0, dto.PlayedPercentage.Value, 5);
+ // ...but the in-progress resume position stays on the version that owns it.
+ Assert.Equal(1, dto.PlaybackPositionTicks);
+ Assert.Equal(1.0, dto.PlayedPercentage);
}
[Fact]
- public void ApplyTo_WithoutRuntime_LeavesPercentageUntouched()
+ public void ApplyTo_DoesNotUnsetExistingPlayedOrRegressLastPlayed()
{
- var resume = new VersionResumeData(new UserItemData { Key = "version", PlaybackPositionTicks = 25 }, null);
- var dto = new UserItemDataDto { Key = "primary", PlayedPercentage = 42 };
+ var primaryLastPlayed = new DateTime(2026, 1, 5, 0, 0, 0, DateTimeKind.Utc);
+ var versionLastPlayed = new DateTime(2026, 1, 2, 0, 0, 0, DateTimeKind.Utc);
+ var resume = new VersionResumeData(
+ new UserItemData { Key = "version", Played = false, LastPlayedDate = versionLastPlayed });
+
+ var dto = new UserItemDataDto { Key = "primary", Played = true, LastPlayedDate = primaryLastPlayed };
resume.ApplyTo(dto);
- Assert.Equal(25, dto.PlaybackPositionTicks);
- Assert.NotNull(dto.PlayedPercentage);
- Assert.Equal(42.0, dto.PlayedPercentage.Value, 5);
+ // A not-yet-completed version must not clear the primary's own completion, and the more recent
+ // LastPlayedDate is kept.
+ Assert.True(dto.Played);
+ Assert.Equal(primaryLastPlayed, dto.LastPlayedDate);
}
}