aboutsummaryrefslogtreecommitdiff
path: root/src/Jellyfin.Networking
diff options
context:
space:
mode:
authorAlexander Gramiak <agrambot@gmail.com>2024-10-05 14:54:26 -0600
committerAlexander Gramiak <agrambot@gmail.com>2024-10-05 15:28:30 -0600
commit76ac1e614395a711099ef8d000a9605794053ac3 (patch)
tree175c00e9d9dd1893689babaad194390fdc275b41 /src/Jellyfin.Networking
parentb5d89a67e8ef9acac7195515587e4ae4e4cf7e45 (diff)
NetworkManager: Use MemberNotNull attribute
Added in .NET 5, this attribute allows for the compiler to recognize that InitializeLan (and by extension, UpdateSettings) will initialize the specified fields.
Diffstat (limited to 'src/Jellyfin.Networking')
-rw-r--r--src/Jellyfin.Networking/Manager/NetworkManager.cs4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/Jellyfin.Networking/Manager/NetworkManager.cs b/src/Jellyfin.Networking/Manager/NetworkManager.cs
index b285b836b..5a13cc417 100644
--- a/src/Jellyfin.Networking/Manager/NetworkManager.cs
+++ b/src/Jellyfin.Networking/Manager/NetworkManager.cs
@@ -81,7 +81,6 @@ public class NetworkManager : INetworkManager, IDisposable
/// <param name="configurationManager">The <see cref="IConfigurationManager"/> instance.</param>
/// <param name="startupConfig">The <see cref="IConfiguration"/> instance holding startup parameters.</param>
/// <param name="logger">Logger to use for messages.</param>
-#pragma warning disable CS8618 // Non-nullable field is uninitialized. : Values are set in UpdateSettings function. Compiler doesn't yet recognise this.
public NetworkManager(IConfigurationManager configurationManager, IConfiguration startupConfig, ILogger<NetworkManager> logger)
{
ArgumentNullException.ThrowIfNull(logger);
@@ -109,7 +108,6 @@ public class NetworkManager : INetworkManager, IDisposable
_configurationManager.NamedConfigurationUpdated += ConfigurationUpdated;
}
-#pragma warning restore CS8618 // Non-nullable field is uninitialized.
/// <summary>
/// Event triggered on network changes.
@@ -312,6 +310,7 @@ public class NetworkManager : INetworkManager, IDisposable
/// <summary>
/// Initializes internal LAN cache.
/// </summary>
+ [MemberNotNull(nameof(_lanSubnets), nameof(_excludedSubnets))]
private void InitializeLan(NetworkConfiguration config)
{
lock (_initLock)
@@ -591,6 +590,7 @@ public class NetworkManager : INetworkManager, IDisposable
/// Reloads all settings and re-Initializes the instance.
/// </summary>
/// <param name="configuration">The <see cref="NetworkConfiguration"/> to use.</param>
+ [MemberNotNull(nameof(_lanSubnets), nameof(_excludedSubnets))]
public void UpdateSettings(object configuration)
{
ArgumentNullException.ThrowIfNull(configuration);