sync updates

2 files changed, 58 insertions, 45 deletions

diff --git a/MediaBrowser.Server.Implementations/Sync/MediaSync.cs b/MediaBrowser.Server.Implementations/Sync/MediaSync.cs
index cac0e1554..befddabd8 100644
--- a/MediaBrowser.Server.Implementations/Sync/MediaSync.cs
+++ b/MediaBrowser.Server.Implementations/Sync/MediaSync.cs
@@ -215,6 +215,13 @@ namespace MediaBrowser.Server.Implementations.Sync
                     var remotePath = GetRemoteSubtitlePath(localItem, mediaStream, provider, target);
                     var sendFileResult = await SendFile(provider, mediaStream.Path, remotePath, target, new Progress<double>(), cancellationToken).ConfigureAwait(false);
 
+                    // This is the path that will be used when talking to the provider
+                    mediaStream.ExternalId = remotePath;
+
+                    // Keep track of all additional files for cleanup later.
+                    localItem.AdditionalFiles.Add(remotePath);
+
+                    // This is the public path clients will use
                     mediaStream.Path = sendFileResult.Path;
                     requiresSave = true;
                 }
@@ -280,13 +287,14 @@ namespace MediaBrowser.Server.Implementations.Sync
 
             foreach (var localItem in localItems)
             {
-                var files = await GetFiles(provider, localItem, target, cancellationToken);
+                var files = localItem.AdditionalFiles.ToList();
+                files.Insert(0, localItem.LocalPath);
 
                 foreach (var file in files)
                 {
-                    _logger.Debug("Removing {0} from {1}.", file.Path, target.Name);
+                    _logger.Debug("Removing {0} from {1}.", file, target.Name);
 
-                    await provider.DeleteFile(file.Path, target, cancellationToken).ConfigureAwait(false);
+                    await provider.DeleteFile(file, target, cancellationToken).ConfigureAwait(false);
                 }
 
                 await dataProvider.Delete(target, localItem.Id).ConfigureAwait(false);
@@ -417,43 +425,5 @@ namespace MediaBrowser.Server.Implementations.Sync
             // We can always add this method to the sync provider if it's really needed
             return _fileSystem.GetValidFilename(filename);
         }
-
-        private async Task<List<ItemFileInfo>> GetFiles(IServerSyncProvider provider, LocalItem item, SyncTarget target, CancellationToken cancellationToken)
-        {
-            var path = item.LocalPath;
-            path = provider.GetParentDirectoryPath(path, target);
-
-            var list = await provider.GetFileSystemEntries(path, target, cancellationToken).ConfigureAwait(false);
-
-            var itemFiles = new List<ItemFileInfo>();
-
-            var name = Path.GetFileNameWithoutExtension(item.LocalPath);
-
-            foreach (var file in list.Where(f => f.Name.IndexOf(name, StringComparison.OrdinalIgnoreCase) != -1))
-            {
-                var itemFile = new ItemFileInfo
-                {
-                    Path = file.Path,
-                    Name = file.Name
-                };
-
-                if (IsSubtitleFile(file.Name))
-                {
-                    itemFile.Type = ItemFileType.Subtitles;
-                }
-
-                itemFiles.Add(itemFile);
-            }
-
-            return itemFiles;
-        }
-
-        private static readonly string[] SupportedSubtitleExtensions = { ".srt", ".vtt" };
-        private bool IsSubtitleFile(string path)
-        {
-            var ext = Path.GetExtension(path) ?? string.Empty;
-
-            return SupportedSubtitleExtensions.Contains(ext, StringComparer.OrdinalIgnoreCase);
-        }
     }
 }
diff --git a/MediaBrowser.Server.Implementations/Sync/SyncedMediaSourceProvider.cs b/MediaBrowser.Server.Implementations/Sync/SyncedMediaSourceProvider.cs
index 893b16b14..e7e1d1c63 100644
--- a/MediaBrowser.Server.Implementations/Sync/SyncedMediaSourceProvider.cs
+++ b/MediaBrowser.Server.Implementations/Sync/SyncedMediaSourceProvider.cs
@@ -3,6 +3,7 @@ using MediaBrowser.Controller.Entities;
 using MediaBrowser.Controller.Library;
 using MediaBrowser.Controller.Sync;
 using MediaBrowser.Model.Dto;
+using MediaBrowser.Model.Logging;
 using MediaBrowser.Model.Sync;
 using System;
 using System.Collections.Generic;
@@ -16,10 +17,12 @@ namespace MediaBrowser.Server.Implementations.Sync
     {
         private readonly SyncManager _syncManager;
         private readonly IServerApplicationHost _appHost;
+        private readonly ILogger _logger;
 
-        public SyncedMediaSourceProvider(ISyncManager syncManager, IServerApplicationHost appHost)
+        public SyncedMediaSourceProvider(ISyncManager syncManager, IServerApplicationHost appHost, ILogger logger)
         {
             _appHost = appHost;
+            _logger = logger;
             _syncManager = (SyncManager)syncManager;
         }
 
@@ -28,7 +31,7 @@ namespace MediaBrowser.Server.Implementations.Sync
             var jobItemResult = _syncManager.GetJobItems(new SyncJobItemQuery
             {
                 AddMetadata = false,
-                Statuses = new SyncJobItemStatus[] { SyncJobItemStatus.Synced },
+                Statuses = new[] { SyncJobItemStatus.Synced },
                 ItemId = item.Id.ToString("N")
             });
 
@@ -49,14 +52,17 @@ namespace MediaBrowser.Server.Implementations.Sync
                     if (targetTuple != null)
                     {
                         var syncTarget = targetTuple.Item2;
-
+                        var syncProvider = targetTuple.Item1;
                         var dataProvider = _syncManager.GetDataProvider(targetTuple.Item1, syncTarget);
 
                         var localItems = await dataProvider.GetCachedItems(syncTarget, serverId, item.Id.ToString("N")).ConfigureAwait(false);
 
                         foreach (var localItem in localItems)
                         {
-                            list.AddRange(localItem.Item.MediaSources);
+                            foreach (var mediaSource in localItem.Item.MediaSources)
+                            {
+                                await TryAddMediaSource(list, localItem, mediaSource, syncProvider, syncTarget, cancellationToken).ConfigureAwait(false);
+                            }
                         }
                     }
                 }
@@ -64,5 +70,42 @@ namespace MediaBrowser.Server.Implementations.Sync
 
             return list;
         }
+
+        private async Task TryAddMediaSource(List<MediaSourceInfo> list,
+            LocalItem item,
+            MediaSourceInfo mediaSource,
+            IServerSyncProvider provider,
+            SyncTarget target,
+            CancellationToken cancellationToken)
+        {
+            var requiresDynamicAccess = provider as IRequiresDynamicAccess;
+
+            if (requiresDynamicAccess == null)
+            {
+                list.Add(mediaSource);
+                return;
+            }
+
+            try
+            {
+                var dynamicInfo = await requiresDynamicAccess.GetFileInfo(item.LocalPath, target, cancellationToken).ConfigureAwait(false);
+
+                foreach (var stream in mediaSource.MediaStreams)
+                {
+                    var dynamicStreamInfo = await requiresDynamicAccess.GetFileInfo(stream.ExternalId, target, cancellationToken).ConfigureAwait(false);
+
+                    stream.Path = dynamicStreamInfo.Path;
+                }
+
+                mediaSource.Path = dynamicInfo.Path;
+                mediaSource.Protocol = dynamicInfo.Protocol;
+
+                list.Add(mediaSource);
+            }
+            catch (Exception ex)
+            {
+                _logger.ErrorException("Error getting dynamic media source info", ex);
+            }
+        }
     }
 }