Merge pull request #2516 from MediaBrowser/beta

Beta

1 files changed, 11 insertions, 6 deletions

diff --git a/MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs b/MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs
index ca22dac2d..4a1bf5305 100644
--- a/MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs
+++ b/MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs
@@ -734,6 +734,16 @@ namespace MediaBrowser.MediaEncoding.Subtitles
                 }
             }
 
+            var charsetFromLanguage = string.IsNullOrWhiteSpace(language)
+                ? null
+                : GetSubtitleFileCharacterSetFromLanguage(language);
+
+            // This assumption should only be made for external subtitles
+            if (!string.IsNullOrWhiteSpace(charsetFromLanguage) && !string.Equals(charsetFromLanguage, "windows-1252", StringComparison.OrdinalIgnoreCase))
+            {
+                return charsetFromLanguage;
+            }
+
             var charset = await DetectCharset(path, language, protocol, cancellationToken).ConfigureAwait(false);
 
             if (!string.IsNullOrWhiteSpace(charset))
@@ -746,12 +756,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
                 return charset;
             }
 
-            if (!string.IsNullOrWhiteSpace(language))
-            {
-                return GetSubtitleFileCharacterSetFromLanguage(language);
-            }
-
-            return null;
+            return charsetFromLanguage;
         }
 
         public string GetSubtitleFileCharacterSetFromLanguage(string language)