Backport pull request #17881 from jellyfin/release-12.z

Fix /UserViews exhausting memory and reporting random child counts

Original-merge: a838a06aa51eac388a76e9e6421f1a80873c417b

Merged-by: crobibero <cody@robibe.ro>

Backported-by: Cody Robibero <cody@robibe.ro>

2 files changed, 46 insertions, 33 deletions

diff --git a/MediaBrowser.Controller/Entities/Movies/BoxSet.cs b/MediaBrowser.Controller/Entities/Movies/BoxSet.cs
index 8216937cad..d7f9102be9 100644
--- a/MediaBrowser.Controller/Entities/Movies/BoxSet.cs
+++ b/MediaBrowser.Controller/Entities/Movies/BoxSet.cs
@@ -168,14 +168,21 @@ namespace MediaBrowser.Controller.Entities.Movies
                 return true;
             }
 
-            var userLibraryFolderIds = GetLibraryFolderIds(user);
-            var libraryFolderIds = LibraryFolderIds ?? GetLibraryFolderIds();
+            List<BaseItem> linkedItems = null;
+            var libraryFolderIds = LibraryFolderIds;
+            if (libraryFolderIds is null)
+            {
+                linkedItems = GetLinkedChildren();
+                libraryFolderIds = GetLibraryFolderIds(linkedItems);
+            }
 
             if (libraryFolderIds.Length == 0)
             {
                 return true;
             }
 
+            var userLibraryFolderIds = GetLibraryFolderIds(user);
+
             if (!userLibraryFolderIds.Any(i => libraryFolderIds.Contains(i)))
             {
                 return false;
@@ -184,7 +191,7 @@ namespace MediaBrowser.Controller.Entities.Movies
             // If user has parental controls, hide the BoxSet when all children are restricted
             if (user.MaxParentalRatingScore.HasValue)
             {
-                var linkedItems = GetLinkedChildren();
+                linkedItems ??= GetLinkedChildren();
                 if (linkedItems.Count > 0 && linkedItems.All(child => !child.IsParentalAllowed(user, true)))
                 {
                     return false;
@@ -241,10 +248,19 @@ namespace MediaBrowser.Controller.Entities.Movies
 
         public Guid[] GetLibraryFolderIds()
         {
-            var expandedFolders = new List<Guid>();
+            return GetLibraryFolderIds(GetLinkedChildren());
+        }
+
+        private Guid[] GetLibraryFolderIds(IEnumerable<BaseItem> linkedChildren)
+        {
+            // Seeded with this box set so a cycle through a nested collection terminates.
+            var expandedFolders = new List<Guid> { Id };
+
+            // The user root children are the same for every item.
+            var rootChildren = LibraryManager.GetUserRootFolder().Children.OfType<Folder>().ToList();
 
-            return FlattenItems(this, expandedFolders)
-                .SelectMany(LibraryManager.GetCollectionFolders)
+            return FlattenItems(linkedChildren, expandedFolders)
+                .SelectMany(i => LibraryManager.GetCollectionFolders(i, rootChildren))
                 .Select(i => i.Id)
                 .Distinct()
                 .ToArray();
diff --git a/MediaBrowser.Controller/Entities/UserViewBuilder.cs b/MediaBrowser.Controller/Entities/UserViewBuilder.cs
index f9ad2d86e6..82256cd964 100644
--- a/MediaBrowser.Controller/Entities/UserViewBuilder.cs
+++ b/MediaBrowser.Controller/Entities/UserViewBuilder.cs
@@ -455,25 +455,34 @@ namespace MediaBrowser.Controller.Entities
             {
                 var itemList = filtered.ToList();
                 var folderIds = itemList.OfType<Folder>().Select(f => f.Id).ToList();
+                var leaves = itemList.Where(i => i is not Folder).ToList();
+                var isPlayedValue = query.IsPlayed.Value;
 
-                if (folderIds.Count > 0)
-                {
-                    var counts = libraryManager.GetPlayedAndTotalCountBatch(folderIds, user);
-                    var isPlayedValue = query.IsPlayed.Value;
+                var counts = folderIds.Count > 0
+                    ? libraryManager.GetPlayedAndTotalCountBatch(folderIds, user)
+                    : null;
+
+                // A movie held as several files is watched once any of its versions is watched.
+                var resumeData = leaves.Count > 0
+                    ? userDataManager.GetResumeUserDataBatch(leaves, user)
+                    : null;
 
-                    return itemList.Where(item =>
+                return itemList.Where(item =>
+                {
+                    if (item is Folder)
                     {
-                        if (item is Folder)
-                        {
-                            var itemCount = counts.GetValueOrDefault(item.Id);
-                            return (itemCount.Played >= itemCount.Total) == isPlayedValue;
-                        }
+                        var itemCount = counts?.GetValueOrDefault(item.Id) ?? default;
+                        return (itemCount.Played >= itemCount.Total) == isPlayedValue;
+                    }
 
-                        return true;
-                    });
-                }
+                    var played = userDataManager.GetUserData(user, item)?.Played ?? false;
+                    if (!played && resumeData is not null && resumeData.TryGetValue(item.Id, out var versionData))
+                    {
+                        played = versionData.UserData.Played;
+                    }
 
-                return itemList;
+                    return played == isPlayedValue;
+                });
             }
 
             return filtered;
@@ -606,19 +615,7 @@ namespace MediaBrowser.Controller.Entities
                 }
             }
 
-            if (query.IsPlayed.HasValue)
-            {
-                // Folder.IsPlayed() hits the DB per-item (N+1 queries).
-                // Folders are batch-filtered by the collection Filter() overload.
-                if (!item.IsFolder)
-                {
-                    userData ??= userDataManager.GetUserData(user, item);
-                    if (item.IsPlayed(user, userData) != query.IsPlayed.Value)
-                    {
-                        return false;
-                    }
-                }
-            }
+            // IsPlayed is answered by the collection Filter() overload for folders and leaves alike.
 
             if (query.IsLocked.HasValue)
             {