Merge pull request #8511 from Bond-009/isnull

10 files changed, 32 insertions, 32 deletions

diff --git a/Jellyfin.Server.Implementations/Devices/DeviceManager.cs b/Jellyfin.Server.Implementations/Devices/DeviceManager.cs
index eeb958c620..bbe33be389 100644
--- a/Jellyfin.Server.Implementations/Devices/DeviceManager.cs
+++ b/Jellyfin.Server.Implementations/Devices/DeviceManager.cs
@@ -55,7 +55,7 @@ namespace Jellyfin.Server.Implementations.Devices
             await using (dbContext.ConfigureAwait(false))
             {
                 deviceOptions = await dbContext.DeviceOptions.AsQueryable().FirstOrDefaultAsync(dev => dev.DeviceId == deviceId).ConfigureAwait(false);
-                if (deviceOptions == null)
+                if (deviceOptions is null)
                 {
                     deviceOptions = new DeviceOptions(deviceId);
                     dbContext.DeviceOptions.Add(deviceOptions);
@@ -121,7 +121,7 @@ namespace Jellyfin.Server.Implementations.Devices
                     .ConfigureAwait(false);
             }
 
-            var deviceInfo = device == null ? null : ToDeviceInfo(device);
+            var deviceInfo = device is null ? null : ToDeviceInfo(device);
 
             return deviceInfo;
         }
@@ -139,12 +139,12 @@ namespace Jellyfin.Server.Implementations.Devices
                     devices = devices.Where(device => device.UserId.Equals(query.UserId.Value));
                 }
 
-                if (query.DeviceId != null)
+                if (query.DeviceId is not null)
                 {
                     devices = devices.Where(device => device.DeviceId == query.DeviceId);
                 }
 
-                if (query.AccessToken != null)
+                if (query.AccessToken is not null)
                 {
                     devices = devices.Where(device => device.AccessToken == query.AccessToken);
                 }
diff --git a/Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStartLogger.cs b/Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStartLogger.cs
index aa6015caae..aeb62e814c 100644
--- a/Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStartLogger.cs
+++ b/Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStartLogger.cs
@@ -38,13 +38,13 @@ namespace Jellyfin.Server.Implementations.Events.Consumers.Session
         /// <inheritdoc />
         public async Task OnEvent(PlaybackStartEventArgs eventArgs)
         {
-            if (eventArgs.MediaInfo == null)
+            if (eventArgs.MediaInfo is null)
             {
                 _logger.LogWarning("PlaybackStart reported with null media info.");
                 return;
             }
 
-            if (eventArgs.Item != null && eventArgs.Item.IsThemeMedia)
+            if (eventArgs.Item is not null && eventArgs.Item.IsThemeMedia)
             {
                 // Don't report theme song or local trailer playback
                 return;
@@ -78,7 +78,7 @@ namespace Jellyfin.Server.Implementations.Events.Consumers.Session
                 name = item.SeriesName + " - " + name;
             }
 
-            if (item.Artists != null && item.Artists.Count > 0)
+            if (item.Artists is not null && item.Artists.Count > 0)
             {
                 name = item.Artists[0] + " - " + name;
             }
diff --git a/Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStopLogger.cs b/Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStopLogger.cs
index 1648b1b475..dd7290fb84 100644
--- a/Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStopLogger.cs
+++ b/Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStopLogger.cs
@@ -40,13 +40,13 @@ namespace Jellyfin.Server.Implementations.Events.Consumers.Session
         {
             var item = eventArgs.MediaInfo;
 
-            if (item == null)
+            if (item is null)
             {
                 _logger.LogWarning("PlaybackStopped reported with null media info.");
                 return;
             }
 
-            if (eventArgs.Item != null && eventArgs.Item.IsThemeMedia)
+            if (eventArgs.Item is not null && eventArgs.Item.IsThemeMedia)
             {
                 // Don't report theme song or local trailer playback
                 return;
@@ -60,7 +60,7 @@ namespace Jellyfin.Server.Implementations.Events.Consumers.Session
             var user = eventArgs.Users[0];
 
             var notificationType = GetPlaybackStoppedNotificationType(item.MediaType);
-            if (notificationType == null)
+            if (notificationType is null)
             {
                 return;
             }
@@ -86,7 +86,7 @@ namespace Jellyfin.Server.Implementations.Events.Consumers.Session
                 name = item.SeriesName + " - " + name;
             }
 
-            if (item.Artists != null && item.Artists.Count > 0)
+            if (item.Artists is not null && item.Artists.Count > 0)
             {
                 name = item.Artists[0] + " - " + name;
             }
diff --git a/Jellyfin.Server.Implementations/Events/EventManager.cs b/Jellyfin.Server.Implementations/Events/EventManager.cs
index 7f7c4750d8..f49ae8e27a 100644
--- a/Jellyfin.Server.Implementations/Events/EventManager.cs
+++ b/Jellyfin.Server.Implementations/Events/EventManager.cs
@@ -44,7 +44,7 @@ namespace Jellyfin.Server.Implementations.Events
             where T : EventArgs
         {
             using var scope = _appHost.ServiceProvider?.CreateScope();
-            if (scope == null)
+            if (scope is null)
             {
                 return;
             }
diff --git a/Jellyfin.Server.Implementations/Extensions/ServiceCollectionExtensions.cs b/Jellyfin.Server.Implementations/Extensions/ServiceCollectionExtensions.cs
index f98a0aede8..05c6229316 100644
--- a/Jellyfin.Server.Implementations/Extensions/ServiceCollectionExtensions.cs
+++ b/Jellyfin.Server.Implementations/Extensions/ServiceCollectionExtensions.cs
@@ -27,7 +27,7 @@ public static class ServiceCollectionExtensions
                 .UseCacheKeyPrefix("EF_")
                 // Don't cache null values. Remove this optional setting if it's not necessary.
                 .SkipCachingResults(result =>
-                    result.Value == null || (result.Value is EFTableRows rows && rows.RowsCount == 0)));
+                    result.Value is null || (result.Value is EFTableRows rows && rows.RowsCount == 0)));
 
         serviceCollection.AddPooledDbContextFactory<JellyfinDb>((serviceProvider, opt) =>
         {
diff --git a/Jellyfin.Server.Implementations/Security/AuthenticationManager.cs b/Jellyfin.Server.Implementations/Security/AuthenticationManager.cs
index 33c08c8c29..810e578075 100644
--- a/Jellyfin.Server.Implementations/Security/AuthenticationManager.cs
+++ b/Jellyfin.Server.Implementations/Security/AuthenticationManager.cs
@@ -65,7 +65,7 @@ namespace Jellyfin.Server.Implementations.Security
                     .FirstOrDefaultAsync()
                     .ConfigureAwait(false);
 
-                if (key == null)
+                if (key is null)
                 {
                     return;
                 }
diff --git a/Jellyfin.Server.Implementations/Security/AuthorizationContext.cs b/Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
index 4d1a1b3cf8..ec5742bab0 100644
--- a/Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
+++ b/Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
@@ -32,7 +32,7 @@ namespace Jellyfin.Server.Implementations.Security
 
         public Task<AuthorizationInfo> GetAuthorizationInfo(HttpContext requestContext)
         {
-            if (requestContext.Request.HttpContext.Items.TryGetValue("AuthorizationInfo", out var cached) && cached != null)
+            if (requestContext.Request.HttpContext.Items.TryGetValue("AuthorizationInfo", out var cached) && cached is not null)
             {
                 return Task.FromResult((AuthorizationInfo)cached); // Cache should never contain null
             }
@@ -72,7 +72,7 @@ namespace Jellyfin.Server.Implementations.Security
             string? version = null;
             string? token = null;
 
-            if (auth != null)
+            if (auth is not null)
             {
                 auth.TryGetValue("DeviceId", out deviceId);
                 auth.TryGetValue("Device", out deviceName);
@@ -127,7 +127,7 @@ namespace Jellyfin.Server.Implementations.Security
             {
                 var device = await dbContext.Devices.FirstOrDefaultAsync(d => d.AccessToken == token).ConfigureAwait(false);
 
-                if (device != null)
+                if (device is not null)
                 {
                     authInfo.IsAuthenticated = true;
                     var updateToken = false;
@@ -189,7 +189,7 @@ namespace Jellyfin.Server.Implementations.Security
                 else
                 {
                     var key = await dbContext.ApiKeys.FirstOrDefaultAsync(apiKey => apiKey.AccessToken == token).ConfigureAwait(false);
-                    if (key != null)
+                    if (key is not null)
                     {
                         authInfo.IsAuthenticated = true;
                         authInfo.Client = key.Name;
diff --git a/Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs b/Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
index 7480a05c25..72f3d6e8ec 100644
--- a/Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
+++ b/Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
@@ -41,7 +41,7 @@ namespace Jellyfin.Server.Implementations.Users
         // This is the version that we need to use for local users. Because reasons.
         public Task<ProviderAuthenticationResult> Authenticate(string username, string password, User resolvedUser)
         {
-            if (resolvedUser == null)
+            if (resolvedUser is null)
             {
                 throw new AuthenticationException("Specified user does not exist.");
             }
@@ -58,7 +58,7 @@ namespace Jellyfin.Server.Implementations.Users
             }
 
             // Handle the case when the stored password is null, but the user tried to login with a password
-            if (resolvedUser.Password == null)
+            if (resolvedUser.Password is null)
             {
                 throw new AuthenticationException("Invalid username or password");
             }
diff --git a/Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs b/Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs
index 87babc05c8..fddad1c4f9 100644
--- a/Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs
+++ b/Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs
@@ -34,7 +34,7 @@ namespace Jellyfin.Server.Implementations.Users
                 .FirstOrDefault(pref =>
                     pref.UserId.Equals(userId) && string.Equals(pref.Client, client) && pref.ItemId.Equals(itemId));
 
-            if (prefs == null)
+            if (prefs is null)
             {
                 prefs = new DisplayPreferences(userId, itemId, client);
                 _dbContext.DisplayPreferences.Add(prefs);
@@ -49,7 +49,7 @@ namespace Jellyfin.Server.Implementations.Users
             var prefs = _dbContext.ItemDisplayPreferences
                 .FirstOrDefault(pref => pref.UserId.Equals(userId) && pref.ItemId.Equals(itemId) && string.Equals(pref.Client, client));
 
-            if (prefs == null)
+            if (prefs is null)
             {
                 prefs = new ItemDisplayPreferences(userId, Guid.Empty, client);
                 _dbContext.ItemDisplayPreferences.Add(prefs);
diff --git a/Jellyfin.Server.Implementations/Users/UserManager.cs b/Jellyfin.Server.Implementations/Users/UserManager.cs
index 25560707ac..ae3fcad29b 100644
--- a/Jellyfin.Server.Implementations/Users/UserManager.cs
+++ b/Jellyfin.Server.Implementations/Users/UserManager.cs
@@ -286,7 +286,7 @@ namespace Jellyfin.Server.Implementations.Users
         /// <inheritdoc/>
         public async Task ChangeEasyPassword(User user, string newPassword, string? newPasswordSha1)
         {
-            if (newPassword != null)
+            if (newPassword is not null)
             {
                 newPasswordSha1 = _cryptoProvider.CreatePasswordHash(newPassword).ToString();
             }
@@ -317,7 +317,7 @@ namespace Jellyfin.Server.Implementations.Users
                 EnableAutoLogin = user.EnableAutoLogin,
                 LastLoginDate = user.LastLoginDate,
                 LastActivityDate = user.LastActivityDate,
-                PrimaryImageTag = user.ProfileImage != null ? _imageProcessor.GetImageCacheTag(user) : null,
+                PrimaryImageTag = user.ProfileImage is not null ? _imageProcessor.GetImageCacheTag(user) : null,
                 Configuration = new UserConfiguration
                 {
                     SubtitleMode = user.SubtitleMode,
@@ -401,12 +401,12 @@ namespace Jellyfin.Server.Implementations.Users
             var authenticationProvider = authResult.AuthenticationProvider;
             var success = authResult.Success;
 
-            if (user == null)
+            if (user is null)
             {
                 string updatedUsername = authResult.Username;
 
                 if (success
-                    && authenticationProvider != null
+                    && authenticationProvider is not null
                     && authenticationProvider is not DefaultAuthenticationProvider)
                 {
                     // Trust the username returned by the authentication provider
@@ -416,25 +416,25 @@ namespace Jellyfin.Server.Implementations.Users
                     // the authentication provider might have created it
                     user = Users.FirstOrDefault(i => string.Equals(username, i.Username, StringComparison.OrdinalIgnoreCase));
 
-                    if (authenticationProvider is IHasNewUserPolicy hasNewUserPolicy && user != null)
+                    if (authenticationProvider is IHasNewUserPolicy hasNewUserPolicy && user is not null)
                     {
                         await UpdatePolicyAsync(user.Id, hasNewUserPolicy.GetNewUserPolicy()).ConfigureAwait(false);
                     }
                 }
             }
 
-            if (success && user != null && authenticationProvider != null)
+            if (success && user is not null && authenticationProvider is not null)
             {
                 var providerId = authenticationProvider.GetType().FullName;
 
-                if (providerId != null && !string.Equals(providerId, user.AuthenticationProviderId, StringComparison.OrdinalIgnoreCase))
+                if (providerId is not null && !string.Equals(providerId, user.AuthenticationProviderId, StringComparison.OrdinalIgnoreCase))
                 {
                     user.AuthenticationProviderId = providerId;
                     await UpdateUserAsync(user).ConfigureAwait(false);
                 }
             }
 
-            if (user == null)
+            if (user is null)
             {
                 _logger.LogInformation(
                     "Authentication request for {UserName} has been denied (IP: {IP}).",
@@ -501,7 +501,7 @@ namespace Jellyfin.Server.Implementations.Users
         {
             var user = string.IsNullOrWhiteSpace(enteredUsername) ? null : GetUserByName(enteredUsername);
 
-            if (user != null && isInNetwork)
+            if (user is not null && isInNetwork)
             {
                 var passwordResetProvider = GetPasswordResetProvider(user);
                 var result = await passwordResetProvider
@@ -708,7 +708,7 @@ namespace Jellyfin.Server.Implementations.Users
         /// <inheritdoc/>
         public async Task ClearProfileImageAsync(User user)
         {
-            if (user.ProfileImage == null)
+            if (user.ProfileImage is null)
             {
                 return;
             }