aboutsummaryrefslogtreecommitdiff
path: root/Jellyfin.Api/Controllers/UniversalAudioController.cs
diff options
context:
space:
mode:
authorSzymon Acedański <accek@mimuw.edu.pl>2021-03-24 20:26:01 +0100
committerSzymon Acedański <accek@mimuw.edu.pl>2021-03-24 20:43:54 +0100
commit136136dea95321a1b691d3d5cafeac4f946aaf50 (patch)
tree294102baf8eb0e4e8b30b80ad1a5ce12c6c215e9 /Jellyfin.Api/Controllers/UniversalAudioController.cs
parent8410a9a26601d754e3c8bed36641c990f1d0e22b (diff)
Fix incorrect responses for HEAD /audio/<id>/stream
Without this fix my Samsung Soundbar (HW-Q80R) fails to play using DLNA and returns "Error: Resource not found (716)" instead. I had a look on tcpdump network logs between Jellyfin and the soundbar and noticed that the device performs a HEAD request for the media before responding to the DLNA UPNP control request from Jellyfin (or BubbleUPNP Android App). Jellyfin retuns 204 No Content response, which is unusual. Common web servers generally return 200 OK if the GET would return content, and this is not-very-clearly suggested [in HTTP spec](https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.1) The other patch is to ensure, that invalid Content-Length: 0 is not returned with the HEAD response in the streaming case. I think in both cases we still don't return the same headers with HEAD as with GET (e.g. Content-Length or Accept-Ranges), but at least we don't return anything misleading.
Diffstat (limited to 'Jellyfin.Api/Controllers/UniversalAudioController.cs')
0 files changed, 0 insertions, 0 deletions