diff options
| author | Bruce Coelho <bruce.coelho93@gmail.com> | 2020-04-25 21:41:56 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-25 21:41:56 +0100 |
| commit | 5aced0ea0f4bca17aee392698351d54b0ad50e26 (patch) | |
| tree | 974983e494e4dd8a3ae55afa30b937c00734042e /Jellyfin.Api/Controllers/PackageController.cs | |
| parent | f66714561e0fef18ba25c36abdf97ee62ccda007 (diff) | |
Apply suggestions from code review
Co-Authored-By: Cody Robibero <cody@robibe.ro>
Diffstat (limited to 'Jellyfin.Api/Controllers/PackageController.cs')
| -rw-r--r-- | Jellyfin.Api/Controllers/PackageController.cs | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/Jellyfin.Api/Controllers/PackageController.cs b/Jellyfin.Api/Controllers/PackageController.cs index ab4d20458..1da5ac0e9 100644 --- a/Jellyfin.Api/Controllers/PackageController.cs +++ b/Jellyfin.Api/Controllers/PackageController.cs @@ -39,11 +39,11 @@ namespace Jellyfin.Api.Controllers /// <returns>Package info.</returns> [HttpGet("/{Name}")] [ProducesResponseType(typeof(PackageInfo), StatusCodes.Status200OK)] - public ActionResult<PackageInfo> GetPackageInfo( + public async Task<ActionResult<PackageInfo>> GetPackageInfo( [FromRoute] [Required] string name, [FromQuery] string? assemblyGuid) { - var packages = _installationManager.GetAvailablePackages().GetAwaiter().GetResult(); + var packages = await _installationManager.GetAvailablePackages().ConfigureAwait(false); var result = _installationManager.FilterPackages( packages, name, @@ -58,11 +58,11 @@ namespace Jellyfin.Api.Controllers /// <returns>Packages information.</returns> [HttpGet] [ProducesResponseType(typeof(PackageInfo[]), StatusCodes.Status200OK)] - public async Task<ActionResult<PackageInfo[]>> GetPackages() + public async Task<IEnumerable<PackageInfo>> GetPackages() { IEnumerable<PackageInfo> packages = await _installationManager.GetAvailablePackages().ConfigureAwait(false); - return Ok(packages.ToArray()); + return packages; } /// <summary> @@ -75,6 +75,7 @@ namespace Jellyfin.Api.Controllers [HttpPost("/Installed/{Name}")] [ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status404NotFound)] + [Authorize(Policy = Policies.RequiresElevation)] public async Task<ActionResult> InstallPackage( [FromRoute] [Required] string name, [FromQuery] string assemblyGuid, |