aboutsummaryrefslogtreecommitdiff
path: root/Jellyfin.Api/Controllers/ItemsController.cs
diff options
context:
space:
mode:
authorPatrick Barron <18354464+barronpm@users.noreply.github.com>2020-07-11 15:48:52 +0000
committerGitHub <noreply@github.com>2020-07-11 15:48:52 +0000
commitf7c7b1e7e15678bb8ba92f082b9bc2882c87baae (patch)
tree405408d5cd266b25fc3182951592ce912b0286fd /Jellyfin.Api/Controllers/ItemsController.cs
parent2eef7d49131d717a0752cf3dcab1922637e2ef98 (diff)
parent5d34b07d1ff7239c7961381fc71559d377e7a96b (diff)
Merge pull request #3524 from crobibero/api-migration-nullable
Make query parameters nullable or set default value
Diffstat (limited to 'Jellyfin.Api/Controllers/ItemsController.cs')
-rw-r--r--Jellyfin.Api/Controllers/ItemsController.cs10
1 files changed, 6 insertions, 4 deletions
diff --git a/Jellyfin.Api/Controllers/ItemsController.cs b/Jellyfin.Api/Controllers/ItemsController.cs
index e1dd4af10..41fe47db1 100644
--- a/Jellyfin.Api/Controllers/ItemsController.cs
+++ b/Jellyfin.Api/Controllers/ItemsController.cs
@@ -143,8 +143,8 @@ namespace Jellyfin.Api.Controllers
[HttpGet("/Users/{uId}/Items")]
[ProducesResponseType(StatusCodes.Status200OK)]
public ActionResult<QueryResult<BaseItemDto>> GetItems(
- [FromRoute] Guid uId,
- [FromQuery] Guid userId,
+ [FromRoute] Guid? uId,
+ [FromQuery] Guid? userId,
[FromQuery] string? maxOfficialRating,
[FromQuery] bool? hasThemeSong,
[FromQuery] bool? hasThemeVideo,
@@ -226,9 +226,11 @@ namespace Jellyfin.Api.Controllers
[FromQuery] bool? enableImages = true)
{
// use user id route parameter over query parameter
- userId = (uId != null) ? uId : userId;
+ userId = uId ?? userId;
- var user = userId.Equals(Guid.Empty) ? null : _userManager.GetUserById(userId);
+ var user = userId.HasValue && !userId.Equals(Guid.Empty)
+ ? _userManager.GetUserById(userId.Value)
+ : null;
var dtoOptions = new DtoOptions()
.AddItemFields(fields)
.AddClientFields(Request)