Mayor code cleanup

Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.

9 files changed, 31 insertions, 51 deletions

diff --git a/Emby.Server.Implementations/TextEncoding/NLangDetect/Extensions/CharExtensions.cs b/Emby.Server.Implementations/TextEncoding/NLangDetect/Extensions/CharExtensions.cs
index 59076bd66..cd77a30eb 100644
--- a/Emby.Server.Implementations/TextEncoding/NLangDetect/Extensions/CharExtensions.cs
+++ b/Emby.Server.Implementations/TextEncoding/NLangDetect/Extensions/CharExtensions.cs
@@ -333,7 +333,7 @@ namespace NLangDetect.Core.Extensions
 
       if (!IsValidCodePoint(codePoint))
       {
-        throw new ArgumentException("Argument is not a valid code point.", "ch");
+        throw new ArgumentException("Argument is not a valid code point.", nameof(ch));
       }
 
       int top, bottom, current;
diff --git a/Emby.Server.Implementations/TextEncoding/NLangDetect/Extensions/StringExtensions.cs b/Emby.Server.Implementations/TextEncoding/NLangDetect/Extensions/StringExtensions.cs
index fc6c58a95..c60757c02 100644
--- a/Emby.Server.Implementations/TextEncoding/NLangDetect/Extensions/StringExtensions.cs
+++ b/Emby.Server.Implementations/TextEncoding/NLangDetect/Extensions/StringExtensions.cs
@@ -14,10 +14,10 @@ namespace NLangDetect.Core.Extensions
     /// <exception cref="IndexOutOfRangeException"> if start or end are negative, if end is greater than length(), or if start is greater than end</exception>
     public static string SubSequence(this string s, int start, int end)
     {
-      if (start < 0) throw new ArgumentOutOfRangeException("start", "Argument must not be negative.");
-      if (end < 0) throw new ArgumentOutOfRangeException("end", "Argument must not be negative.");
-      if (end > s.Length) throw new ArgumentOutOfRangeException("end", "Argument must not be greater than the input string's length.");
-      if (start > end) throw new ArgumentOutOfRangeException("start", "Argument must not be greater than the 'end' argument.");
+      if (start < 0) throw new ArgumentOutOfRangeException(nameof(start), "Argument must not be negative.");
+      if (end < 0) throw new ArgumentOutOfRangeException(nameof(end), "Argument must not be negative.");
+      if (end > s.Length) throw new ArgumentOutOfRangeException(nameof(end), "Argument must not be greater than the input string's length.");
+      if (start > end) throw new ArgumentOutOfRangeException(nameof(start), "Argument must not be greater than the 'end' argument.");
       
       return s.Substring(start, end - start);
     }
diff --git a/Emby.Server.Implementations/TextEncoding/NLangDetect/LanguageDetector.cs b/Emby.Server.Implementations/TextEncoding/NLangDetect/LanguageDetector.cs
index fc7d420a9..044c7e759 100644
--- a/Emby.Server.Implementations/TextEncoding/NLangDetect/LanguageDetector.cs
+++ b/Emby.Server.Implementations/TextEncoding/NLangDetect/LanguageDetector.cs
@@ -23,7 +23,7 @@ namespace NLangDetect.Core
 
         public static string DetectLanguage(string plainText)
         {
-            if (string.IsNullOrEmpty(plainText)) { throw new ArgumentException("Argument can't be null nor empty.", "plainText"); }
+            if (string.IsNullOrEmpty(plainText)) { throw new ArgumentException("Argument can't be null nor empty.", nameof(plainText)); }
 
             Detector detector = DetectorFactory.Create(_DefaultAlpha);
 
diff --git a/Emby.Server.Implementations/TextEncoding/TextEncoding.cs b/Emby.Server.Implementations/TextEncoding/TextEncoding.cs
index f30c181a0..8f15d5a7b 100644
--- a/Emby.Server.Implementations/TextEncoding/TextEncoding.cs
+++ b/Emby.Server.Implementations/TextEncoding/TextEncoding.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Text;
 using MediaBrowser.Model.IO;
 using Microsoft.Extensions.Logging;
@@ -27,7 +27,7 @@ namespace Emby.Server.Implementations.TextEncoding
             return Encoding.ASCII;
         }
 
-        private Encoding GetInitialEncoding(byte[] buffer, int count)
+        private static Encoding GetInitialEncoding(byte[] buffer, int count)
         {
             if (count >= 3)
             {
@@ -137,6 +137,7 @@ namespace Emby.Server.Implementations.TextEncoding
             }
             catch (NLangDetectException ex)
             {
+                _logger.LogDebug(ex, "LanguageDetector.DetectLanguage threw a NLangDetectException.");
             }
 
             try
@@ -145,6 +146,7 @@ namespace Emby.Server.Implementations.TextEncoding
             }
             catch (NLangDetectException ex)
             {
+                _logger.LogDebug(ex, "LanguageDetector.DetectLanguage threw a NLangDetectException.");
             }
 
             try
@@ -153,6 +155,7 @@ namespace Emby.Server.Implementations.TextEncoding
             }
             catch (NLangDetectException ex)
             {
+                _logger.LogDebug(ex, "LanguageDetector.DetectLanguage threw a NLangDetectException.");
             }
 
             return null;
@@ -162,7 +165,7 @@ namespace Emby.Server.Implementations.TextEncoding
         {
             if (string.IsNullOrWhiteSpace(charset))
             {
-                throw new ArgumentNullException("charset");
+                throw new ArgumentNullException(nameof(charset));
             }
 
             _logger.LogDebug("Getting encoding object for character set: {0}", charset);
@@ -187,7 +190,7 @@ namespace Emby.Server.Implementations.TextEncoding
             return GetEncodingFromCharset(charset);
         }
 
-        private string GetFileCharacterSetFromLanguage(string language)
+        private static string GetFileCharacterSetFromLanguage(string language)
         {
             // https://developer.xamarin.com/api/type/System.Text.Encoding/
 
@@ -245,7 +248,7 @@ namespace Emby.Server.Implementations.TextEncoding
             }
         }
 
-        private string DetectCharset(byte[] bytes, int index, int count, string language)
+        private static string DetectCharset(byte[] bytes, int index, int count, string language)
         {
             var detector = new CharsetDetector();
             detector.Feed(bytes, index, count);
diff --git a/Emby.Server.Implementations/TextEncoding/TextEncodingDetect.cs b/Emby.Server.Implementations/TextEncoding/TextEncodingDetect.cs
index a0395a21b..7ac4a0b79 100644
--- a/Emby.Server.Implementations/TextEncoding/TextEncodingDetect.cs
+++ b/Emby.Server.Implementations/TextEncoding/TextEncodingDetect.cs
@@ -61,10 +61,7 @@
         /// </summary>
         public bool NullSuggestsBinary
         {
-            set
-            {
-                _nullSuggestsBinary = value;
-            }
+            set => _nullSuggestsBinary = value;
         }
 
         public double Utf16ExpectedNullPercent
diff --git a/Emby.Server.Implementations/TextEncoding/UniversalDetector/CharsetDetector.cs b/Emby.Server.Implementations/TextEncoding/UniversalDetector/CharsetDetector.cs
index 942fda8d1..f2cecd03a 100644
--- a/Emby.Server.Implementations/TextEncoding/UniversalDetector/CharsetDetector.cs
+++ b/Emby.Server.Implementations/TextEncoding/UniversalDetector/CharsetDetector.cs
@@ -101,14 +101,10 @@ namespace UniversalDetector
             base.Reset();
         }
         
-        public string Charset {
-            get { return charset; }
-        }
+        public string Charset => charset;
+
+        public float Confidence => confidence;
 
-        public float Confidence {
-            get { return confidence; }
-        }
-        
         protected override void Report(string charset, float confidence)
         {
             this.charset = charset;
diff --git a/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/CodingStateMachine.cs b/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/CodingStateMachine.cs
index f837dd966..2a0e83b17 100644
--- a/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/CodingStateMachine.cs
+++ b/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/CodingStateMachine.cs
@@ -77,14 +77,8 @@ namespace UniversalDetector.Core
             currentState = SMModel.START; 
         }
 
-        public int CurrentCharLen 
-        { 
-            get { return currentCharLen; } 
-        }
+        public int CurrentCharLen => currentCharLen;
 
-        public string ModelName 
-        { 
-            get { return model.Name; } 
-        }
+        public string ModelName => model.Name;
     }
 }
diff --git a/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/SMModel.cs b/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/SMModel.cs
index 2321ecad2..5b2f38303 100644
--- a/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/SMModel.cs
+++ b/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/SMModel.cs
@@ -55,18 +55,14 @@ namespace UniversalDetector.Core
         
         private string name;
         
-        public string Name {
-            get { return name;  }
-        }
+        public string Name => name;
 
         private int classFactor;
 
-        public int ClassFactor {
-            get { return classFactor;  }
-        }
+        public int ClassFactor => classFactor;
 
         public SMModel(BitPackage classTable, int classFactor,
-            BitPackage stateTable, int[] charLenTable, String name)
+            BitPackage stateTable, int[] charLenTable, string name)
         {
             this.classTable = classTable;
             this.classFactor = classFactor;
diff --git a/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/SequenceModel.cs b/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/SequenceModel.cs
index 9048796b5..32b5df169 100644
--- a/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/SequenceModel.cs
+++ b/Emby.Server.Implementations/TextEncoding/UniversalDetector/Core/SequenceModel.cs
@@ -52,29 +52,23 @@ namespace UniversalDetector.Core
         // freqSeqs / totalSeqs
         protected float typicalPositiveRatio;
         
-        public float TypicalPositiveRatio {
-            get { return typicalPositiveRatio; }
-        }
-        
+        public float TypicalPositiveRatio => typicalPositiveRatio;
+
         // not used            
         protected bool keepEnglishLetter;
         
-        public bool KeepEnglishLetter {
-            get { return keepEnglishLetter; }
-        }
-        
-        protected String charsetName;
+        public bool KeepEnglishLetter => keepEnglishLetter;
+
+        protected string charsetName;
+
+        public string CharsetName => charsetName;
 
-        public string CharsetName {
-            get { return charsetName; }
-        }
-        
         public SequenceModel(
                 byte[] charToOrderMap,
                 byte[] precedenceMatrix,
                 float typicalPositiveRatio,
                 bool keepEnglishLetter,
-                String charsetName)
+                string charsetName)
         {
             this.charToOrderMap = charToOrderMap;
             this.precedenceMatrix = precedenceMatrix;