Mayor code cleanup

Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.

1 files changed, 20 insertions, 129 deletions

diff --git a/Emby.Server.Implementations/ServerApplicationPaths.cs b/Emby.Server.Implementations/ServerApplicationPaths.cs
index 8a0f2671a..933b67291 100644
--- a/Emby.Server.Implementations/ServerApplicationPaths.cs
+++ b/Emby.Server.Implementations/ServerApplicationPaths.cs
@@ -30,174 +30,84 @@ namespace Emby.Server.Implementations
         /// Gets the path to the base root media directory
         /// </summary>
         /// <value>The root folder path.</value>
-        public string RootFolderPath
-        {
-            get
-            {
-                return Path.Combine(ProgramDataPath, "root");
-            }
-        }
+        public string RootFolderPath => Path.Combine(ProgramDataPath, "root");
 
         /// <summary>
         /// Gets the path to the default user view directory.  Used if no specific user view is defined.
         /// </summary>
         /// <value>The default user views path.</value>
-        public string DefaultUserViewsPath
-        {
-            get
-            {
-                return Path.Combine(RootFolderPath, "default");
-            }
-        }
+        public string DefaultUserViewsPath => Path.Combine(RootFolderPath, "default");
 
         /// <summary>
         /// Gets the path to localization data.
         /// </summary>
         /// <value>The localization path.</value>
-        public string LocalizationPath
-        {
-            get
-            {
-                return Path.Combine(ProgramDataPath, "localization");
-            }
-        }
+        public string LocalizationPath => Path.Combine(ProgramDataPath, "localization");
 
         /// <summary>
         /// Gets the path to the People directory
         /// </summary>
         /// <value>The people path.</value>
-        public string PeoplePath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "People");
-            }
-        }
+        public string PeoplePath => Path.Combine(InternalMetadataPath, "People");
 
-        public string ArtistsPath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "artists");
-            }
-        }
+        public string ArtistsPath => Path.Combine(InternalMetadataPath, "artists");
 
         /// <summary>
         /// Gets the path to the Genre directory
         /// </summary>
         /// <value>The genre path.</value>
-        public string GenrePath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "Genre");
-            }
-        }
+        public string GenrePath => Path.Combine(InternalMetadataPath, "Genre");
 
         /// <summary>
         /// Gets the path to the Genre directory
         /// </summary>
         /// <value>The genre path.</value>
-        public string MusicGenrePath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "MusicGenre");
-            }
-        }
+        public string MusicGenrePath => Path.Combine(InternalMetadataPath, "MusicGenre");
 
         /// <summary>
         /// Gets the path to the Studio directory
         /// </summary>
         /// <value>The studio path.</value>
-        public string StudioPath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "Studio");
-            }
-        }
+        public string StudioPath => Path.Combine(InternalMetadataPath, "Studio");
 
         /// <summary>
         /// Gets the path to the Year directory
         /// </summary>
         /// <value>The year path.</value>
-        public string YearPath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "Year");
-            }
-        }
+        public string YearPath => Path.Combine(InternalMetadataPath, "Year");
 
         /// <summary>
         /// Gets the path to the General IBN directory
         /// </summary>
         /// <value>The general path.</value>
-        public string GeneralPath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "general");
-            }
-        }
+        public string GeneralPath => Path.Combine(InternalMetadataPath, "general");
 
         /// <summary>
         /// Gets the path to the Ratings IBN directory
         /// </summary>
         /// <value>The ratings path.</value>
-        public string RatingsPath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "ratings");
-            }
-        }
+        public string RatingsPath => Path.Combine(InternalMetadataPath, "ratings");
 
         /// <summary>
         /// Gets the media info images path.
         /// </summary>
         /// <value>The media info images path.</value>
-        public string MediaInfoImagesPath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "mediainfo");
-            }
-        }
+        public string MediaInfoImagesPath => Path.Combine(InternalMetadataPath, "mediainfo");
 
         /// <summary>
         /// Gets the path to the user configuration directory
         /// </summary>
         /// <value>The user configuration directory path.</value>
-        public string UserConfigurationDirectoryPath
-        {
-            get
-            {
-                return Path.Combine(ConfigurationDirectoryPath, "users");
-            }
-        }
+        public string UserConfigurationDirectoryPath => Path.Combine(ConfigurationDirectoryPath, "users");
 
         private string _defaultTranscodingTempPath;
-        public string DefaultTranscodingTempPath
-        {
-            get
-            {
-                return _defaultTranscodingTempPath ?? (_defaultTranscodingTempPath = Path.Combine(ProgramDataPath, "transcoding-temp"));
-            }
-        }
+        public string DefaultTranscodingTempPath => _defaultTranscodingTempPath ?? (_defaultTranscodingTempPath = Path.Combine(ProgramDataPath, "transcoding-temp"));
 
         private string _transcodingTempPath;
         public string TranscodingTempPath
         {
-            get
-            {
-                return _transcodingTempPath ?? (_transcodingTempPath = DefaultTranscodingTempPath);
-            }
-            set
-            {
-                _transcodingTempPath = value;
-            }
+            get => _transcodingTempPath ?? (_transcodingTempPath = DefaultTranscodingTempPath);
+            set => _transcodingTempPath = value;
         }
 
         public string GetTranscodingTempPath()
@@ -230,35 +140,16 @@ namespace Emby.Server.Implementations
         /// Gets the game genre path.
         /// </summary>
         /// <value>The game genre path.</value>
-        public string GameGenrePath
-        {
-            get
-            {
-                return Path.Combine(InternalMetadataPath, "GameGenre");
-            }
-        }
+        public string GameGenrePath => Path.Combine(InternalMetadataPath, "GameGenre");
 
         private string _internalMetadataPath;
         public string InternalMetadataPath
         {
-            get
-            {
-                return _internalMetadataPath ?? (_internalMetadataPath = Path.Combine(DataPath, "metadata"));
-            }
-            set
-            {
-                _internalMetadataPath = value;
-            }
+            get => _internalMetadataPath ?? (_internalMetadataPath = Path.Combine(DataPath, "metadata"));
+            set => _internalMetadataPath = value;
         }
 
         private const string _virtualInternalMetadataPath = "%MetadataPath%";
-        public string VirtualInternalMetadataPath
-        {
-            get
-            {
-                return _virtualInternalMetadataPath;
-            }
-        }
-
+        public string VirtualInternalMetadataPath => _virtualInternalMetadataPath;
     }
 }