diff options
| author | Rich Lander <rlander@microsoft.com> | 2021-04-12 17:16:26 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-12 17:16:26 -0700 |
| commit | fe54e9ae9de932d2130f15d90df40da9dbc048fe (patch) | |
| tree | 1a6729bfaaaf964ff70b517d51f2d1f5cbf03bc3 | |
| parent | 8a73e19f5e3b39f890b00f32f086325afcaff616 (diff) | |
Remove coupling to distro
- The substring `-buster-slim` isn't useful/correct.
- .NET 6 (from my team) is based exclusively on bullseye.
- If you update just `DOTNET_VERSION` to `6.0`, `docker build` will fail.
- If the goal is to force using `buster` throughout the Dockerfile, then making `DOTNET_VERSION` configurable isn't correct.
- Context: https://github.com/dotnet/dotnet-docker/blob/main/src/runtime-deps/6.0/bullseye-slim/amd64/Dockerfile#L1
Just saw this as a drive by look at your code. Is intended as helpful context.
| -rw-r--r-- | Dockerfile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Dockerfile b/Dockerfile index cafee737a..ebe5eb00c 100644 --- a/Dockerfile +++ b/Dockerfile @@ -8,7 +8,7 @@ RUN apk add curl git zlib zlib-dev autoconf g++ make libpng-dev gifsicle alpine- && npm ci --no-audit \ && mv dist /dist -FROM mcr.microsoft.com/dotnet/sdk:${DOTNET_VERSION}-buster-slim as builder +FROM mcr.microsoft.com/dotnet/sdk:${DOTNET_VERSION} as builder WORKDIR /repo COPY . . ENV DOTNET_CLI_TELEMETRY_OPTOUT=1 |