aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhallacy <Dragoonmac@gmail.com>2019-03-07 03:32:05 -0800
committerPhallacy <Dragoonmac@gmail.com>2019-03-07 03:32:05 -0800
commitdfb1d704edf296a34a6e752f44c9d0f22889b21f (patch)
treec77fb3b4e235cd968bf6ce4ce6324df8035bb302
parent8f4895e8a5bd1549f41bc1d4d2b31d03cff689ad (diff)
made hashset static and readonly
-rw-r--r--Emby.Server.Implementations/Cryptography/CryptographyProvider.cs29
1 files changed, 14 insertions, 15 deletions
diff --git a/Emby.Server.Implementations/Cryptography/CryptographyProvider.cs b/Emby.Server.Implementations/Cryptography/CryptographyProvider.cs
index e27738f69..982bba625 100644
--- a/Emby.Server.Implementations/Cryptography/CryptographyProvider.cs
+++ b/Emby.Server.Implementations/Cryptography/CryptographyProvider.cs
@@ -11,21 +11,7 @@ namespace Emby.Server.Implementations.Cryptography
{
public class CryptographyProvider : ICryptoProvider
{
- private HashSet<string> _supportedHashMethods;
-
- public string DefaultHashMethod => "PBKDF2";
-
- private RandomNumberGenerator _randomNumberGenerator;
-
- private const int _defaultIterations = 1000;
-
- public CryptographyProvider()
- {
- //FIXME: When we get DotNet Standard 2.1 we need to revisit how we do the crypto
- //Currently supported hash methods from https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.cryptoconfig?view=netcore-2.1
- //there might be a better way to autogenerate this list as dotnet updates, but I couldn't find one
- //Please note the default method of PBKDF2 is not included, it cannot be used to generate hashes cleanly as it is actually a pbkdf with sha1
- _supportedHashMethods = new HashSet<string>()
+ private static readonly HashSet<string> _supportedHashMethods = new HashSet<string>()
{
"MD5",
"System.Security.Cryptography.MD5",
@@ -42,6 +28,19 @@ namespace Emby.Server.Implementations.Cryptography
"SHA-512",
"System.Security.Cryptography.SHA512"
};
+
+ public string DefaultHashMethod => "PBKDF2";
+
+ private RandomNumberGenerator _randomNumberGenerator;
+
+ private const int _defaultIterations = 1000;
+
+ public CryptographyProvider()
+ {
+ //FIXME: When we get DotNet Standard 2.1 we need to revisit how we do the crypto
+ //Currently supported hash methods from https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.cryptoconfig?view=netcore-2.1
+ //there might be a better way to autogenerate this list as dotnet updates, but I couldn't find one
+ //Please note the default method of PBKDF2 is not included, it cannot be used to generate hashes cleanly as it is actually a pbkdf with sha1
_randomNumberGenerator = RandomNumberGenerator.Create();
}