diff options
| author | crobibero <cody@robibe.ro> | 2020-12-08 19:33:26 -0700 |
|---|---|---|
| committer | crobibero <cody@robibe.ro> | 2020-12-08 19:33:26 -0700 |
| commit | c955f196341b4dbaf993eecdffb3c994e66b53ec (patch) | |
| tree | 991b3c6d2962a6656071a35d13be4c0b666be730 | |
| parent | 87e13b858a27eee2af6d6cc0d69ed736325ac668 (diff) | |
Serialize GUID without dashes
| -rw-r--r-- | MediaBrowser.Common/Json/Converters/JsonGuidConverter.cs | 3 | ||||
| -rw-r--r-- | tests/Jellyfin.Common.Tests/Json/JsonGuidConverterTests.cs | 11 |
2 files changed, 12 insertions, 2 deletions
diff --git a/MediaBrowser.Common/Json/Converters/JsonGuidConverter.cs b/MediaBrowser.Common/Json/Converters/JsonGuidConverter.cs index ccf214e3c..bd9600110 100644 --- a/MediaBrowser.Common/Json/Converters/JsonGuidConverter.cs +++ b/MediaBrowser.Common/Json/Converters/JsonGuidConverter.cs @@ -1,4 +1,5 @@ using System; +using System.Globalization; using System.Text.Json; using System.Text.Json.Serialization; @@ -19,7 +20,7 @@ namespace MediaBrowser.Common.Json.Converters /// <inheritdoc /> public override void Write(Utf8JsonWriter writer, Guid value, JsonSerializerOptions options) { - writer.WriteStringValue(value); + writer.WriteStringValue(value.ToString("N", CultureInfo.InvariantCulture)); } } } diff --git a/tests/Jellyfin.Common.Tests/Json/JsonGuidConverterTests.cs b/tests/Jellyfin.Common.Tests/Json/JsonGuidConverterTests.cs index 663cc3c78..fc17573fb 100644 --- a/tests/Jellyfin.Common.Tests/Json/JsonGuidConverterTests.cs +++ b/tests/Jellyfin.Common.Tests/Json/JsonGuidConverterTests.cs @@ -1,4 +1,5 @@ using System; +using System.Globalization; using System.Text.Json; using MediaBrowser.Common.Json.Converters; using Xunit; @@ -46,7 +47,15 @@ namespace Jellyfin.Common.Tests.Json [Fact] public void Serialize_EmptyGuid_EmptyGuid() { - Assert.Equal($"\"{Guid.Empty}\"", JsonSerializer.Serialize(Guid.Empty, _options)); + Assert.Equal($"\"{Guid.Empty:N}\"", JsonSerializer.Serialize(Guid.Empty, _options)); + } + + [Fact] + public void Serialize_Valid_NoDash_Success() + { + var guid = new Guid("531797E9-9457-40E0-88BC-B1D6D38752FA"); + var str = JsonSerializer.Serialize(guid, _options); + Assert.Equal($"\"{guid:N}\"", str); } } } |
