aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGary Wilber <Spacetech326@gmail.com>2020-10-16 11:15:42 -0700
committerGitHub <noreply@github.com>2020-10-16 11:15:42 -0700
commitb1f637684dfd3511c2f6be643efa5ff7cecadb17 (patch)
tree955af06a51f85ed7cbff2f5146f613d5f8459914
parent7841378506a04dd02d8e8459a274e740ed5da3f5 (diff)
Apply suggestions from code review (updating comments)
Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
-rw-r--r--MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs8
1 files changed, 4 insertions, 4 deletions
diff --git a/MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs b/MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs
index bf3088aa8..31f0123dc 100644
--- a/MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs
+++ b/MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs
@@ -757,7 +757,7 @@ namespace MediaBrowser.Providers.Music
if (_stopWatchMusicBrainz.ElapsedMilliseconds < _musicBrainzQueryIntervalMs)
{
- // MusicBrainz is extremely adamant about limiting to one request per second
+ // MusicBrainz is extremely adamant about limiting to one request per second.
var delayMs = _musicBrainzQueryIntervalMs - _stopWatchMusicBrainz.ElapsedMilliseconds;
await Task.Delay((int)delayMs, cancellationToken).ConfigureAwait(false);
}
@@ -770,7 +770,7 @@ namespace MediaBrowser.Providers.Music
using var request = new HttpRequestMessage(HttpMethod.Get, requestUrl);
// MusicBrainz request a contact email address is supplied, as comment, in user agent field:
- // https://musicbrainz.org/doc/XML_Web_Service/Rate_Limiting#User-Agent
+ // https://musicbrainz.org/doc/XML_Web_Service/Rate_Limiting#User-Agent .
request.Headers.UserAgent.ParseAdd(string.Format(
CultureInfo.InvariantCulture,
"{0} ( {1} )",
@@ -779,11 +779,11 @@ namespace MediaBrowser.Providers.Music
response = await _httpClientFactory.CreateClient(NamedClient.Default).SendAsync(request).ConfigureAwait(false);
- // We retry a finite number of times, and only whilst MB is indicating 503 (throttling)
+ // We retry a finite number of times, and only whilst MB is indicating 503 (throttling).
}
while (attempts < MusicBrainzQueryAttempts && response.StatusCode == HttpStatusCode.ServiceUnavailable);
- // Log error if unable to query MB database due to throttling
+ // Log error if unable to query MB database due to throttling.
if (attempts == MusicBrainzQueryAttempts && response.StatusCode == HttpStatusCode.ServiceUnavailable)
{
_logger.LogError("GetMusicBrainzResponse: 503 Service Unavailable (throttled) response received {0} times whilst requesting {1}", attempts, requestUrl);