diff options
| author | Joshua M. Boniface <joshua@boniface.me> | 2025-09-28 12:34:21 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-09-28 12:34:21 -0400 |
| commit | 275c1a3cc160ad9d3a4ddae0c65467cdb1bdf1b3 (patch) | |
| tree | ff8dd4ee0754875923d458b4a647d257c477ea74 | |
| parent | 4942b2c15f1fadfe769534bcf3f80c0895a5a2a1 (diff) | |
| parent | b9c96f3d2c722fd210cec0694d257b0296d13964 (diff) | |
Merge pull request #14883 from crobibero/code-analysis
Only include custom code analysis for debug builds
| -rw-r--r-- | .github/workflows/ci-compat.yml | 2 | ||||
| -rw-r--r-- | Directory.Build.props | 2 | ||||
| -rw-r--r-- | src/Jellyfin.CodeAnalysis/Jellyfin.CodeAnalysis.csproj | 18 |
3 files changed, 2 insertions, 20 deletions
diff --git a/.github/workflows/ci-compat.yml b/.github/workflows/ci-compat.yml index 94d54ecee..702dd29b8 100644 --- a/.github/workflows/ci-compat.yml +++ b/.github/workflows/ci-compat.yml @@ -105,7 +105,7 @@ jobs: run: | { echo 'body<<EOF' - for file in Jellyfin.Data.dll MediaBrowser.Common.dll MediaBrowser.Controller.dll MediaBrowser.Model.dll Emby.Naming.dll Jellyfin.Extensions.dll Jellyfin.MediaEncoding.Keyframes.dll Jellyfin.Database.Implementations.dll Jellyfin.CodeAnalysis.dll; do + for file in Jellyfin.Data.dll MediaBrowser.Common.dll MediaBrowser.Controller.dll MediaBrowser.Model.dll Emby.Naming.dll Jellyfin.Extensions.dll Jellyfin.MediaEncoding.Keyframes.dll Jellyfin.Database.Implementations.dll; do COMPAT_OUTPUT="$( { apicompat --left ./abi-base/${file} --right ./abi-head/${file}; } 2>&1 )" if [ "APICompat ran successfully without finding any breaking changes." != "${COMPAT_OUTPUT}" ]; then printf "\n${file}\n${COMPAT_OUTPUT}\n" diff --git a/Directory.Build.props b/Directory.Build.props index 900714171..8400f4c5e 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -20,7 +20,7 @@ </ItemGroup> <!-- Custom Analyzers --> - <ItemGroup Condition=" '$(MSBuildProjectName)' != 'Jellyfin.CodeAnalysis' "> + <ItemGroup Condition=" '$(MSBuildProjectName)' != 'Jellyfin.CodeAnalysis' AND '$(Configuration)' == 'Debug' "> <ProjectReference Include="$(MSBuildThisFileDirectory)src/Jellyfin.CodeAnalysis/Jellyfin.CodeAnalysis.csproj" OutputItemType="Analyzer" /> </ItemGroup> diff --git a/src/Jellyfin.CodeAnalysis/Jellyfin.CodeAnalysis.csproj b/src/Jellyfin.CodeAnalysis/Jellyfin.CodeAnalysis.csproj index 8a9f85ca9..64d20e904 100644 --- a/src/Jellyfin.CodeAnalysis/Jellyfin.CodeAnalysis.csproj +++ b/src/Jellyfin.CodeAnalysis/Jellyfin.CodeAnalysis.csproj @@ -7,24 +7,6 @@ <GeneratePackageOnBuild>false</GeneratePackageOnBuild> <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules> <GenerateDocumentationFile>true</GenerateDocumentationFile> - <GenerateAssemblyInfo>false</GenerateAssemblyInfo> - <PublishRepositoryUrl>true</PublishRepositoryUrl> - <EmbedUntrackedSources>true</EmbedUntrackedSources> - <IncludeSymbols>true</IncludeSymbols> - <SymbolPackageFormat>snupkg</SymbolPackageFormat> - </PropertyGroup> - - <PropertyGroup Condition=" '$(Stability)'=='Unstable'"> - <!-- Include all symbols in the main nupkg until Azure Artifact Feed starts supporting ingesting NuGet symbol packages. --> - <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder> - </PropertyGroup> - - <PropertyGroup> - <Authors>Jellyfin Contributors</Authors> - <PackageId>Jellyfin.CodeAnalysis</PackageId> - <VersionPrefix>10.11.0</VersionPrefix> - <RepositoryUrl>https://github.com/jellyfin/jellyfin</RepositoryUrl> - <PackageLicenseExpression>GPL-3.0-only</PackageLicenseExpression> </PropertyGroup> <ItemGroup> |