diff options
| author | Bond-009 <bond.009@outlook.com> | 2020-06-05 19:25:57 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-06-05 19:25:57 +0200 |
| commit | 258f2ff686abf647f7109e4c64715d04198c37f3 (patch) | |
| tree | 836107a0bd535749ffc59eb537bf68aa06dc847e | |
| parent | 0b0184de2e3da7af817e0217de9d8d4f2de59ba8 (diff) | |
| parent | 2e7d7abe8e68205e0d12da80166fe318c6eb3d3a (diff) | |
Merge pull request #3245 from jellyfin/fix-azure
Fix some issues with the CI
| -rw-r--r-- | Emby.Server.Implementations/Images/ArtistImageProvider.cs | 13 | ||||
| -rw-r--r-- | Emby.Server.Implementations/Images/GenreImageProvider.cs | 28 | ||||
| -rw-r--r-- | Jellyfin.Data/Jellyfin.Data.csproj | 1 |
3 files changed, 37 insertions, 5 deletions
diff --git a/Emby.Server.Implementations/Images/ArtistImageProvider.cs b/Emby.Server.Implementations/Images/ArtistImageProvider.cs index 7fa13a49f..52896720e 100644 --- a/Emby.Server.Implementations/Images/ArtistImageProvider.cs +++ b/Emby.Server.Implementations/Images/ArtistImageProvider.cs @@ -1,3 +1,5 @@ +#pragma warning disable CS1591 + using System; using System.Collections.Generic; using System.Linq; @@ -18,8 +20,14 @@ using MediaBrowser.Model.Querying; namespace Emby.Server.Implementations.Images { + /// <summary> + /// Class ArtistImageProvider. + /// </summary> public class ArtistImageProvider : BaseDynamicImageProvider<MusicArtist> { + /// <summary> + /// The library manager. + /// </summary> private readonly ILibraryManager _libraryManager; public ArtistImageProvider(IFileSystem fileSystem, IProviderManager providerManager, IApplicationPaths applicationPaths, IImageProcessor imageProcessor, ILibraryManager libraryManager) : base(fileSystem, providerManager, applicationPaths, imageProcessor) @@ -27,6 +35,11 @@ namespace Emby.Server.Implementations.Images _libraryManager = libraryManager; } + /// <summary> + /// Get children objects used to create an artist image. + /// </summary> + /// <param name="item">The artist used to create the image.</param> + /// <returns>Any relevant children objects.</returns> protected override IReadOnlyList<BaseItem> GetItemsWithImages(BaseItem item) { return Array.Empty<BaseItem>(); diff --git a/Emby.Server.Implementations/Images/GenreImageProvider.cs b/Emby.Server.Implementations/Images/GenreImageProvider.cs index a184ed4f5..d2aeccdb2 100644 --- a/Emby.Server.Implementations/Images/GenreImageProvider.cs +++ b/Emby.Server.Implementations/Images/GenreImageProvider.cs @@ -1,7 +1,6 @@ -using System; +#pragma warning disable CS1591 + using System.Collections.Generic; -using System.Linq; -using Emby.Server.Implementations.Images; using MediaBrowser.Common.Configuration; using MediaBrowser.Controller.Drawing; using MediaBrowser.Controller.Dto; @@ -10,7 +9,6 @@ using MediaBrowser.Controller.Entities.Audio; using MediaBrowser.Controller.Entities.Movies; using MediaBrowser.Controller.Entities.TV; using MediaBrowser.Controller.Library; -using MediaBrowser.Controller.Playlists; using MediaBrowser.Controller.Providers; using MediaBrowser.Model.Entities; using MediaBrowser.Model.IO; @@ -18,8 +16,14 @@ using MediaBrowser.Model.Querying; namespace Emby.Server.Implementations.Images { + /// <summary> + /// Class MusicGenreImageProvider. + /// </summary> public class MusicGenreImageProvider : BaseDynamicImageProvider<MusicGenre> { + /// <summary> + /// The library manager. + /// </summary> private readonly ILibraryManager _libraryManager; public MusicGenreImageProvider(IFileSystem fileSystem, IProviderManager providerManager, IApplicationPaths applicationPaths, IImageProcessor imageProcessor, ILibraryManager libraryManager) : base(fileSystem, providerManager, applicationPaths, imageProcessor) @@ -27,6 +31,11 @@ namespace Emby.Server.Implementations.Images _libraryManager = libraryManager; } + /// <summary> + /// Get children objects used to create an music genre image. + /// </summary> + /// <param name="item">The music genre used to create the image.</param> + /// <returns>Any relevant children objects.</returns> protected override IReadOnlyList<BaseItem> GetItemsWithImages(BaseItem item) { return _libraryManager.GetItemList(new InternalItemsQuery @@ -42,8 +51,14 @@ namespace Emby.Server.Implementations.Images } } + /// <summary> + /// Class GenreImageProvider. + /// </summary> public class GenreImageProvider : BaseDynamicImageProvider<Genre> { + /// <summary> + /// The library manager. + /// </summary> private readonly ILibraryManager _libraryManager; public GenreImageProvider(IFileSystem fileSystem, IProviderManager providerManager, IApplicationPaths applicationPaths, IImageProcessor imageProcessor, ILibraryManager libraryManager) : base(fileSystem, providerManager, applicationPaths, imageProcessor) @@ -51,6 +66,11 @@ namespace Emby.Server.Implementations.Images _libraryManager = libraryManager; } + /// <summary> + /// Get children objects used to create an genre image. + /// </summary> + /// <param name="item">The genre used to create the image.</param> + /// <returns>Any relevant children objects.</returns> protected override IReadOnlyList<BaseItem> GetItemsWithImages(BaseItem item) { return _libraryManager.GetItemList(new InternalItemsQuery diff --git a/Jellyfin.Data/Jellyfin.Data.csproj b/Jellyfin.Data/Jellyfin.Data.csproj index c2c105917..9157c3ead 100644 --- a/Jellyfin.Data/Jellyfin.Data.csproj +++ b/Jellyfin.Data/Jellyfin.Data.csproj @@ -4,7 +4,6 @@ <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks> <GenerateAssemblyInfo>false</GenerateAssemblyInfo> <GenerateDocumentationFile>true</GenerateDocumentationFile> - <TreatWarningsAsErrors Condition=" '$(Configuration)' == 'Release' ">true</TreatWarningsAsErrors> </PropertyGroup> <PropertyGroup Condition=" '$(Configuration)' == 'Debug' "> |
