aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Rabert <ar@nullsum.net>2026-02-19 23:53:48 -0500
committerAndrew Rabert <ar@nullsum.net>2026-02-19 23:53:48 -0500
commit01eb56f04753381bdc8d4a9d2b16d0901bb69afc (patch)
tree3189f1920a5f0725f6f3d325f58a39aabd43d816
parent6829794aa09f62d1e15a568e31d91d8f81e3ed35 (diff)
Mitigate pull_request_target privilege escalation
Hotfix — replaces pull_request_target with pull_request to stop granting write permissions and secrets to fork PRs. Some workflows will break; can be fixed properly later.
-rw-r--r--.github/workflows/ci-compat.yml4
-rw-r--r--.github/workflows/ci-openapi.yml6
-rw-r--r--.github/workflows/commands.yml2
-rw-r--r--.github/workflows/project-automation.yml2
-rw-r--r--.github/workflows/pull-request-conflict.yml4
5 files changed, 9 insertions, 9 deletions
diff --git a/.github/workflows/ci-compat.yml b/.github/workflows/ci-compat.yml
index 23a82a1b2..8e3717b33 100644
--- a/.github/workflows/ci-compat.yml
+++ b/.github/workflows/ci-compat.yml
@@ -1,6 +1,6 @@
name: ABI Compatibility
on:
- pull_request_target:
+ pull_request:
permissions: {}
@@ -77,7 +77,7 @@ jobs:
pull-requests: write # to create or update comment (peter-evans/create-or-update-comment)
name: ABI - Difference
- if: ${{ github.event_name == 'pull_request_target' }}
+ if: ${{ github.event_name == 'pull_request' }}
runs-on: ubuntu-latest
needs:
- abi-head
diff --git a/.github/workflows/ci-openapi.yml b/.github/workflows/ci-openapi.yml
index 08eedd54f..3d04ac5e0 100644
--- a/.github/workflows/ci-openapi.yml
+++ b/.github/workflows/ci-openapi.yml
@@ -5,7 +5,7 @@ on:
- master
tags:
- 'v*'
- pull_request_target:
+ pull_request:
permissions: {}
@@ -78,7 +78,7 @@ jobs:
pull-requests: write
name: OpenAPI - Difference
- if: ${{ github.event_name == 'pull_request_target' }}
+ if: ${{ github.event_name == 'pull_request' }}
runs-on: ubuntu-latest
needs:
- openapi-head
@@ -109,7 +109,7 @@ jobs:
publish-unstable:
name: OpenAPI - Publish Unstable Spec
- if: ${{ github.event_name != 'pull_request_target' && !startsWith(github.ref, 'refs/tags/v') && contains(github.repository_owner, 'jellyfin') }}
+ if: ${{ github.event_name != 'pull_request' && !startsWith(github.ref, 'refs/tags/v') && contains(github.repository_owner, 'jellyfin') }}
runs-on: ubuntu-latest
needs:
- openapi-head
diff --git a/.github/workflows/commands.yml b/.github/workflows/commands.yml
index 2c4efcc8c..2adb8f101 100644
--- a/.github/workflows/commands.yml
+++ b/.github/workflows/commands.yml
@@ -4,7 +4,7 @@ on:
types:
- created
- edited
- pull_request_target:
+ pull_request:
types:
- labeled
- synchronize
diff --git a/.github/workflows/project-automation.yml b/.github/workflows/project-automation.yml
index 7b29d3c81..9a9f3214a 100644
--- a/.github/workflows/project-automation.yml
+++ b/.github/workflows/project-automation.yml
@@ -4,7 +4,7 @@ on:
push:
branches:
- master
- pull_request_target:
+ pull_request:
issue_comment:
permissions: {}
diff --git a/.github/workflows/pull-request-conflict.yml b/.github/workflows/pull-request-conflict.yml
index e6a9bf0ca..b003636a6 100644
--- a/.github/workflows/pull-request-conflict.yml
+++ b/.github/workflows/pull-request-conflict.yml
@@ -4,7 +4,7 @@ on:
push:
branches:
- master
- pull_request_target:
+ pull_request:
issue_comment:
permissions: {}
@@ -16,7 +16,7 @@ jobs:
steps:
- name: Apply label
uses: eps1lon/actions-label-merge-conflict@1df065ebe6e3310545d4f4c4e862e43bdca146f0 # v3.0.3
- if: ${{ github.event_name == 'push' || github.event_name == 'pull_request_target'}}
+ if: ${{ github.event_name == 'push' || github.event_name == 'pull_request'}}
with:
dirtyLabel: 'merge conflict'
commentOnDirty: 'This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.'