From 507998a4e327ad13d03b4244da967cffb8b03a72 Mon Sep 17 00:00:00 2001
From: Shadowghost <Ghost_of_Stone@web.de>
Date: Sun, 7 Jun 2026 22:37:34 +0200
Subject: Derive version-aware media source names

---
 .../Entities/BaseItemTests.cs                      | 62 ++++++++++++++++++++++
 1 file changed, 62 insertions(+)

(limited to 'tests')

diff --git a/tests/Jellyfin.Controller.Tests/Entities/BaseItemTests.cs b/tests/Jellyfin.Controller.Tests/Entities/BaseItemTests.cs
index 5c187da413..8af176138c 100644
--- a/tests/Jellyfin.Controller.Tests/Entities/BaseItemTests.cs
+++ b/tests/Jellyfin.Controller.Tests/Entities/BaseItemTests.cs
@@ -46,4 +46,66 @@ public class BaseItemTests
         Assert.Equal(name, video.GetMediaSourceName(video));
         Assert.Equal(altName, video.GetMediaSourceName(videoAlt));
     }
+
+    [Theory]
+    // Episode versions share a season folder; the common prefix (not the folder name) yields the label.
+    // Both files carry a suffix (no bare base name), so the shared "- " must be stripped too.
+    [InlineData(
+        "Spider-Noir - S01E02 - Wo ist Flint - Greyscale",
+        "Spider-Noir - S01E02 - Wo ist Flint - Colorized",
+        "Greyscale",
+        "Colorized")]
+    // One version is the bare base name; the other is suffixed.
+    [InlineData(
+        "Spider-Noir - S01E02 - Wo ist Flint",
+        "Spider-Noir - S01E02 - Wo ist Flint - Greyscale",
+        "Spider-Noir - S01E02 - Wo ist Flint",
+        "Greyscale")]
+    // Suffixes share a leading word ("Grey"); the prefix must retreat to the separator, not split it.
+    [InlineData(
+        "Demo - S01E01 - Greyscale",
+        "Demo - S01E01 - Greyish",
+        "Greyscale",
+        "Greyish")]
+    // Underscore separator.
+    [InlineData("Movie (2020)_4K", "Movie (2020)_1080p", "4K", "1080p")]
+    // Dot separator.
+    [InlineData("Movie (2020).UHD", "Movie (2020).1080p", "UHD", "1080p")]
+    // Resolution variants that share leading digits must retreat to the separator, not yield "p"/"i".
+    [InlineData("Movie - 1080p", "Movie - 1080i", "1080p", "1080i")]
+    // Bracketed version labels: the opening bracket is kept in the label.
+    [InlineData(
+        "Blade Runner (1982) [Final Cut] [1080p HEVC AAC]",
+        "Blade Runner (1982) [EE by ADM] [480p HEVC AAC]",
+        "[Final Cut] [1080p HEVC AAC]",
+        "[EE by ADM] [480p HEVC AAC]")]
+    public void GetMediaSourceName_CommonPrefix_Valid(string primaryName, string altName, string expectedPrimary, string expectedAlt)
+    {
+        var primaryPath = "/Shows/Demo/Season 01/" + primaryName + ".mkv";
+        var altPath = "/Shows/Demo/Season 01/" + altName + ".mkv";
+        var commonPrefix = BaseItem.GetCommonVersionPrefix([primaryName, altName]);
+
+        var video = new Video()
+        {
+            Path = primaryPath
+        };
+
+        var videoAlt = new Video()
+        {
+            Path = altPath,
+        };
+
+        var mediaSourceManager = new Mock<IMediaSourceManager>();
+        mediaSourceManager.Setup(x => x.GetPathProtocol(It.IsAny<string>()))
+                .Returns((string x) => MediaProtocol.File);
+        var libraryManager = new Mock<ILibraryManager>();
+        // No local alternate versions: these are linked (separate items), so the folder fallback is unavailable.
+        libraryManager.Setup(x => x.GetLocalAlternateVersionIds(It.IsAny<Video>()))
+                .Returns(Array.Empty<Guid>());
+        BaseItem.MediaSourceManager = mediaSourceManager.Object;
+        BaseItem.LibraryManager = libraryManager.Object;
+
+        Assert.Equal(expectedPrimary, video.GetMediaSourceName(video, commonPrefix));
+        Assert.Equal(expectedAlt, videoAlt.GetMediaSourceName(videoAlt, commonPrefix));
+    }
 }
-- 
cgit v1.2.3