From 85d7eb917f1cd7530e28fb0565564c79ddb910ed Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Mon, 16 Sep 2013 22:44:06 -0400 Subject: made dtoservice synchronous --- MediaBrowser.Server.Implementations/Dto/DtoService.cs | 14 ++++++-------- .../EntryPoints/WebSocketEvents.cs | 6 +++--- .../Library/LibraryManager.cs | 2 +- .../Library/Validators/ArtistsValidator.cs | 2 +- 4 files changed, 11 insertions(+), 13 deletions(-) (limited to 'MediaBrowser.Server.Implementations') diff --git a/MediaBrowser.Server.Implementations/Dto/DtoService.cs b/MediaBrowser.Server.Implementations/Dto/DtoService.cs index eda6d9c13..feadc488f 100644 --- a/MediaBrowser.Server.Implementations/Dto/DtoService.cs +++ b/MediaBrowser.Server.Implementations/Dto/DtoService.cs @@ -19,7 +19,6 @@ using System; using System.Collections.Generic; using System.IO; using System.Linq; -using System.Threading.Tasks; namespace MediaBrowser.Server.Implementations.Dto { @@ -49,7 +48,7 @@ namespace MediaBrowser.Server.Implementations.Dto /// The owner. /// Task{DtoBaseItem}. /// item - public async Task GetBaseItemDto(BaseItem item, List fields, User user = null, BaseItem owner = null) + public BaseItemDto GetBaseItemDto(BaseItem item, List fields, User user = null, BaseItem owner = null) { if (item == null) { @@ -72,7 +71,7 @@ namespace MediaBrowser.Server.Implementations.Dto { try { - await AttachPrimaryImageAspectRatio(dto, item).ConfigureAwait(false); + AttachPrimaryImageAspectRatio(dto, item); } catch (Exception ex) { @@ -189,7 +188,7 @@ namespace MediaBrowser.Server.Implementations.Dto } } - public async Task GetUserDto(User user) + public UserDto GetUserDto(User user) { if (user == null) { @@ -214,7 +213,7 @@ namespace MediaBrowser.Server.Implementations.Dto try { - await AttachPrimaryImageAspectRatio(dto, user).ConfigureAwait(false); + AttachPrimaryImageAspectRatio(dto, user); } catch (Exception ex) { @@ -1132,9 +1131,8 @@ namespace MediaBrowser.Server.Implementations.Dto /// /// The dto. /// The item. - /// The _logger. /// Task. - private async Task AttachPrimaryImageAspectRatio(IItemDto dto, BaseItem item) + private void AttachPrimaryImageAspectRatio(IItemDto dto, BaseItem item) { var path = item.PrimaryImagePath; @@ -1152,7 +1150,7 @@ namespace MediaBrowser.Server.Implementations.Dto try { - size = await Kernel.Instance.ImageManager.GetImageSize(path, dateModified).ConfigureAwait(false); + size = Kernel.Instance.ImageManager.GetImageSize(path, dateModified); } catch (FileNotFoundException) { diff --git a/MediaBrowser.Server.Implementations/EntryPoints/WebSocketEvents.cs b/MediaBrowser.Server.Implementations/EntryPoints/WebSocketEvents.cs index 43c1e53b3..29372a40a 100644 --- a/MediaBrowser.Server.Implementations/EntryPoints/WebSocketEvents.cs +++ b/MediaBrowser.Server.Implementations/EntryPoints/WebSocketEvents.cs @@ -44,7 +44,7 @@ namespace MediaBrowser.Server.Implementations.EntryPoints private readonly ITaskManager _taskManager; private readonly IDtoService _dtoService; - + /// /// Initializes a new instance of the class. /// @@ -134,9 +134,9 @@ namespace MediaBrowser.Server.Implementations.EntryPoints /// /// The sender. /// The e. - async void userManager_UserUpdated(object sender, GenericEventArgs e) + void userManager_UserUpdated(object sender, GenericEventArgs e) { - var dto = await _dtoService.GetUserDto(e.Argument).ConfigureAwait(false); + var dto = _dtoService.GetUserDto(e.Argument); _serverManager.SendWebSocketMessage("UserUpdated", dto); } diff --git a/MediaBrowser.Server.Implementations/Library/LibraryManager.cs b/MediaBrowser.Server.Implementations/Library/LibraryManager.cs index 10fc8a586..5230bb4c3 100644 --- a/MediaBrowser.Server.Implementations/Library/LibraryManager.cs +++ b/MediaBrowser.Server.Implementations/Library/LibraryManager.cs @@ -824,7 +824,7 @@ namespace MediaBrowser.Server.Implementations.Library /// Task. public async Task ValidatePeople(CancellationToken cancellationToken, IProgress progress) { - const int maxTasks = 5; + const int maxTasks = 3; var tasks = new List(); diff --git a/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs b/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs index f41a2e60c..607f32427 100644 --- a/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs +++ b/MediaBrowser.Server.Implementations/Library/Validators/ArtistsValidator.cs @@ -202,7 +202,7 @@ namespace MediaBrowser.Server.Implementations.Library.Validators .Distinct(StringComparer.OrdinalIgnoreCase) .ToList(); - const int maxTasks = 5; + const int maxTasks = 3; var tasks = new List(); -- cgit v1.2.3