From b87f759460490792b7ceaf0513ab0d87a869e73b Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Sun, 29 Jun 2014 13:58:04 -0400 Subject: fixes #857 - Support album subfolders --- .../Library/Resolvers/Audio/MusicAlbumResolver.cs | 45 ++++++++++++++++++---- 1 file changed, 38 insertions(+), 7 deletions(-) (limited to 'MediaBrowser.Server.Implementations/Library') diff --git a/MediaBrowser.Server.Implementations/Library/Resolvers/Audio/MusicAlbumResolver.cs b/MediaBrowser.Server.Implementations/Library/Resolvers/Audio/MusicAlbumResolver.cs index 034894670..24c9b111a 100644 --- a/MediaBrowser.Server.Implementations/Library/Resolvers/Audio/MusicAlbumResolver.cs +++ b/MediaBrowser.Server.Implementations/Library/Resolvers/Audio/MusicAlbumResolver.cs @@ -45,7 +45,7 @@ namespace MediaBrowser.Server.Implementations.Library.Resolvers.Audio { return null; } - + var collectionType = args.GetCollectionType(); // If there's a collection type and it's not music, don't allow it. @@ -54,7 +54,7 @@ namespace MediaBrowser.Server.Implementations.Library.Resolvers.Audio { return null; } - + return IsMusicAlbum(args) ? new MusicAlbum() : null; } @@ -67,7 +67,7 @@ namespace MediaBrowser.Server.Implementations.Library.Resolvers.Audio /// true if [is music album] [the specified data]; otherwise, false. public static bool IsMusicAlbum(string path, IDirectoryService directoryService) { - return ContainsMusic(directoryService.GetFileSystemEntries(path)); + return ContainsMusic(directoryService.GetFileSystemEntries(path), true, directoryService); } /// @@ -81,7 +81,7 @@ namespace MediaBrowser.Server.Implementations.Library.Resolvers.Audio if (args.IsDirectory) { //if (args.Parent is MusicArtist) return true; //saves us from testing children twice - if (ContainsMusic(args.FileSystemChildren)) return true; + if (ContainsMusic(args.FileSystemChildren, true, args.DirectoryService)) return true; } return false; @@ -91,18 +91,26 @@ namespace MediaBrowser.Server.Implementations.Library.Resolvers.Audio /// Determine if the supplied list contains what we should consider music /// /// The list. + /// if set to true [allow subfolders]. + /// The directory service. /// true if the specified list contains music; otherwise, false. - private static bool ContainsMusic(IEnumerable list) + private static bool ContainsMusic(IEnumerable list, bool allowSubfolders, IDirectoryService directoryService) { // If list contains at least 2 audio files or at least one and no video files consider it to contain music var foundAudio = 0; foreach (var fileSystemInfo in list) { - // TODO: Support disc 1, disc 2, etc if ((fileSystemInfo.Attributes & FileAttributes.Directory) == FileAttributes.Directory) { - continue; + if (allowSubfolders && IsAlbumSubfolder(fileSystemInfo, directoryService)) + { + return true; + } + if (!IsAdditionalSubfolderAllowed(fileSystemInfo)) + { + return false; + } } var fullName = fileSystemInfo.FullName; @@ -129,5 +137,28 @@ namespace MediaBrowser.Server.Implementations.Library.Resolvers.Audio // or a single audio file and no video files return foundAudio > 0; } + + private static bool IsAlbumSubfolder(FileSystemInfo directory, IDirectoryService directoryService) + { + var path = directory.FullName; + + if (IsMultiDiscFolder(path)) + { + return ContainsMusic(directoryService.GetFileSystemEntries(path), false, directoryService); + } + + return false; + } + + private static bool IsMultiDiscFolder(string path) + { + return EntityResolutionHelper.IsMultiPartFolder(path); + } + + private static bool IsAdditionalSubfolderAllowed(FileSystemInfo directory) + { + // TOOD: allow some metadata folders like extrafanart, extrathumbs + return false; + } } } -- cgit v1.2.3