From ee1a746031f15bdfc5c5e38fab704f5fcb9b67ee Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Thu, 21 Nov 2013 11:02:49 -0500 Subject: use string.equals --- .../Library/Resolvers/Movies/MovieResolver.cs | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) (limited to 'MediaBrowser.Server.Implementations/Library') diff --git a/MediaBrowser.Server.Implementations/Library/Resolvers/Movies/MovieResolver.cs b/MediaBrowser.Server.Implementations/Library/Resolvers/Movies/MovieResolver.cs index 0f87b9d33..07beabb83 100644 --- a/MediaBrowser.Server.Implementations/Library/Resolvers/Movies/MovieResolver.cs +++ b/MediaBrowser.Server.Implementations/Library/Resolvers/Movies/MovieResolver.cs @@ -345,18 +345,9 @@ namespace MediaBrowser.Server.Implementations.Library.Resolvers.Movies /// true if [is DVD directory] [the specified directory name]; otherwise, false. private bool IsDvdDirectory(string directoryName) { - return directoryName.Equals("video_ts", StringComparison.OrdinalIgnoreCase); + return string.Equals(directoryName, "video_ts", StringComparison.OrdinalIgnoreCase); } - /// - /// Determines whether [is hd DVD directory] [the specified directory name]. - /// - /// Name of the directory. - /// true if [is hd DVD directory] [the specified directory name]; otherwise, false. - private bool IsHdDvdDirectory(string directoryName) - { - return directoryName.Equals("hvdvd_ts", StringComparison.OrdinalIgnoreCase); - } /// /// Determines whether [is blu ray directory] [the specified directory name]. /// @@ -364,7 +355,7 @@ namespace MediaBrowser.Server.Implementations.Library.Resolvers.Movies /// true if [is blu ray directory] [the specified directory name]; otherwise, false. private bool IsBluRayDirectory(string directoryName) { - return directoryName.Equals("bdmv", StringComparison.OrdinalIgnoreCase); + return string.Equals(directoryName, "bdmv", StringComparison.OrdinalIgnoreCase); } } } -- cgit v1.2.3 From 17bacee0890cb03a579f9469e435d922bbdfdd50 Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Thu, 21 Nov 2013 15:48:26 -0500 Subject: consolidate Artist & MusicArtist --- MediaBrowser.Api/BaseApiService.cs | 18 +--- .../DefaultTheme/DefaultThemeService.cs | 15 +--- MediaBrowser.Api/ItemRefreshService.cs | 14 ++-- MediaBrowser.Api/ItemUpdateService.cs | 9 -- MediaBrowser.Api/LibraryService.cs | 16 +--- MediaBrowser.Api/SearchService.cs | 6 +- MediaBrowser.Api/UserLibrary/ArtistsService.cs | 21 +---- MediaBrowser.Controller/Entities/Audio/Artist.cs | 86 ------------------- .../Entities/Audio/MusicArtist.cs | 69 +++++++++++++++- MediaBrowser.Controller/Entities/BaseItem.cs | 5 ++ MediaBrowser.Controller/Entities/Folder.cs | 20 ++--- MediaBrowser.Controller/Entities/IItemByName.cs | 5 ++ MediaBrowser.Controller/Library/ILibraryManager.cs | 15 +++- .../MediaBrowser.Controller.csproj | 1 - MediaBrowser.Providers/FolderProviderFromXml.cs | 2 +- .../MediaBrowser.Providers.csproj | 2 - .../MediaInfo/BaseFFProbeProvider.cs | 4 +- .../Music/ArtistInfoFromSongProvider.cs | 42 ++++++---- .../Music/ArtistProviderFromXml.cs | 13 +-- .../Music/FanArtArtistByNameProvider.cs | 47 ----------- .../Music/LastFmImageProvider.cs | 2 +- .../Music/LastfmArtistByNameProvider.cs | 89 -------------------- .../Music/LastfmArtistProvider.cs | 11 --- MediaBrowser.Providers/Music/LastfmHelper.cs | 20 +---- .../Music/ManualFanartArtistProvider.cs | 2 +- .../Music/ManualLastFmImageProvider.cs | 9 +- MediaBrowser.Providers/Savers/ArtistXmlSaver.cs | 3 +- MediaBrowser.Providers/Savers/FolderXmlSaver.cs | 2 +- .../Dto/DtoService.cs | 4 +- .../Library/LibraryManager.cs | 96 ++++++++++++++++++---- .../Library/LuceneSearchEngine.cs | 16 +--- .../Library/Validators/ArtistsValidator.cs | 73 ++-------------- .../Providers/ImageSaver.cs | 2 +- MediaBrowser.WebDashboard/Api/DashboardService.cs | 1 + .../MediaBrowser.WebDashboard.csproj | 6 ++ 35 files changed, 246 insertions(+), 500 deletions(-) delete mode 100644 MediaBrowser.Controller/Entities/Audio/Artist.cs delete mode 100644 MediaBrowser.Providers/Music/FanArtArtistByNameProvider.cs delete mode 100644 MediaBrowser.Providers/Music/LastfmArtistByNameProvider.cs (limited to 'MediaBrowser.Server.Implementations/Library') diff --git a/MediaBrowser.Api/BaseApiService.cs b/MediaBrowser.Api/BaseApiService.cs index d01e96a5a..ee0721d5e 100644 --- a/MediaBrowser.Api/BaseApiService.cs +++ b/MediaBrowser.Api/BaseApiService.cs @@ -92,7 +92,7 @@ namespace MediaBrowser.Api private readonly char[] _dashReplaceChars = new[] { '?', '/' }; private const char SlugChar = '-'; - protected Artist GetArtist(string name, ILibraryManager libraryManager) + protected MusicArtist GetArtist(string name, ILibraryManager libraryManager) { return libraryManager.GetArtist(DeSlugArtistName(name, libraryManager)); } @@ -147,21 +147,7 @@ namespace MediaBrowser.Api return name; } - return libraryManager.RootFolder.GetRecursiveChildren() - .OfType