From 88a38a61b59c20b64b5d993364dea2e1d7160d9f Mon Sep 17 00:00:00 2001 From: Bond_009 Date: Sun, 28 Apr 2024 15:18:53 +0200 Subject: Improve audio normalization * Move calculation of LUFS to a scheduled task as it's pretty slow * Correctly calculate album LUFS * Don't try to convert replaygain tags to LUFS values --- MediaBrowser.Model/Dto/BaseItemDto.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'MediaBrowser.Model') diff --git a/MediaBrowser.Model/Dto/BaseItemDto.cs b/MediaBrowser.Model/Dto/BaseItemDto.cs index 6d5c84e1d..623e58807 100644 --- a/MediaBrowser.Model/Dto/BaseItemDto.cs +++ b/MediaBrowser.Model/Dto/BaseItemDto.cs @@ -782,10 +782,10 @@ namespace MediaBrowser.Model.Dto public string TimerId { get; set; } /// - /// Gets or sets the LUFS value. + /// Gets or sets the gain required for audio normalization. /// - /// The LUFS Value. - public float? LUFS { get; set; } + /// The gain required for audio normalization.. + public float? NormalizationGain { get; set; } /// /// Gets or sets the current program. -- cgit v1.2.3 From 2ad872001dc1276d71964584a11f4bedc742b3f7 Mon Sep 17 00:00:00 2001 From: Bond_009 Date: Sun, 28 Apr 2024 17:16:33 +0200 Subject: Address comments --- Emby.Server.Implementations/Dto/DtoService.cs | 1 + MediaBrowser.Controller/Entities/BaseItem.cs | 2 +- MediaBrowser.Model/Dto/BaseItemDto.cs | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) (limited to 'MediaBrowser.Model') diff --git a/Emby.Server.Implementations/Dto/DtoService.cs b/Emby.Server.Implementations/Dto/DtoService.cs index a82258bae..19902b26a 100644 --- a/Emby.Server.Implementations/Dto/DtoService.cs +++ b/Emby.Server.Implementations/Dto/DtoService.cs @@ -900,6 +900,7 @@ namespace Emby.Server.Implementations.Dto if (item.LUFS.HasValue) { + // -18 LUFS reference, same as ReplayGain 2.0, compatible with ReplayGain 1.0 dto.NormalizationGain = -18f - item.LUFS; } else if (item.NormalizationGain.HasValue) diff --git a/MediaBrowser.Controller/Entities/BaseItem.cs b/MediaBrowser.Controller/Entities/BaseItem.cs index 3dd4d1e39..adbbbaa03 100644 --- a/MediaBrowser.Controller/Entities/BaseItem.cs +++ b/MediaBrowser.Controller/Entities/BaseItem.cs @@ -140,7 +140,7 @@ namespace MediaBrowser.Controller.Entities /// /// Gets or sets the gain required for audio normalization. /// - /// The gain required for audio normalization.. + /// The gain required for audio normalization. [JsonIgnore] public float? NormalizationGain { get; set; } diff --git a/MediaBrowser.Model/Dto/BaseItemDto.cs b/MediaBrowser.Model/Dto/BaseItemDto.cs index 623e58807..7e8949e1f 100644 --- a/MediaBrowser.Model/Dto/BaseItemDto.cs +++ b/MediaBrowser.Model/Dto/BaseItemDto.cs @@ -784,7 +784,7 @@ namespace MediaBrowser.Model.Dto /// /// Gets or sets the gain required for audio normalization. /// - /// The gain required for audio normalization.. + /// The gain required for audio normalization. public float? NormalizationGain { get; set; } /// -- cgit v1.2.3