From 70771fdcd60ec5d8a9f13713662778c7e57d0633 Mon Sep 17 00:00:00 2001
From: Maxr1998 <max.rumpf1998@gmail.com>
Date: Sat, 1 May 2021 13:06:10 +0200
Subject: Nullability handling for device profile classes

---
 MediaBrowser.Model/Dlna/TranscodingProfile.cs | 27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

(limited to 'MediaBrowser.Model/Dlna/TranscodingProfile.cs')

diff --git a/MediaBrowser.Model/Dlna/TranscodingProfile.cs b/MediaBrowser.Model/Dlna/TranscodingProfile.cs
index f05e31047..ea446b733 100644
--- a/MediaBrowser.Model/Dlna/TranscodingProfile.cs
+++ b/MediaBrowser.Model/Dlna/TranscodingProfile.cs
@@ -1,54 +1,69 @@
-#nullable disable
 #pragma warning disable CS1591
 
+using System.ComponentModel;
+using System.ComponentModel.DataAnnotations;
 using System.Xml.Serialization;
 
 namespace MediaBrowser.Model.Dlna
 {
     public class TranscodingProfile
     {
+        [Required]
         [XmlAttribute("container")]
-        public string Container { get; set; }
+        public string Container { get; set; } = string.Empty;
 
+        [Required]
         [XmlAttribute("type")]
         public DlnaProfileType Type { get; set; }
 
+        [Required]
         [XmlAttribute("videoCodec")]
-        public string VideoCodec { get; set; }
+        public string VideoCodec { get; set; } = string.Empty;
 
+        [Required]
         [XmlAttribute("audioCodec")]
-        public string AudioCodec { get; set; }
+        public string AudioCodec { get; set; } = string.Empty;
 
+        [Required]
         [XmlAttribute("protocol")]
-        public string Protocol { get; set; }
+        public string Protocol { get; set; } = string.Empty;
 
+        [DefaultValue(false)]
         [XmlAttribute("estimateContentLength")]
         public bool EstimateContentLength { get; set; }
 
+        [DefaultValue(false)]
         [XmlAttribute("enableMpegtsM2TsMode")]
         public bool EnableMpegtsM2TsMode { get; set; }
 
+        [DefaultValue(TranscodeSeekInfo.Auto)]
         [XmlAttribute("transcodeSeekInfo")]
         public TranscodeSeekInfo TranscodeSeekInfo { get; set; }
 
+        [DefaultValue(false)]
         [XmlAttribute("copyTimestamps")]
         public bool CopyTimestamps { get; set; }
 
+        [DefaultValue(EncodingContext.Streaming)]
         [XmlAttribute("context")]
         public EncodingContext Context { get; set; }
 
+        [DefaultValue(false)]
         [XmlAttribute("enableSubtitlesInManifest")]
         public bool EnableSubtitlesInManifest { get; set; }
 
         [XmlAttribute("maxAudioChannels")]
-        public string MaxAudioChannels { get; set; }
+        public string? MaxAudioChannels { get; set; }
 
+        [DefaultValue(0)]
         [XmlAttribute("minSegments")]
         public int MinSegments { get; set; }
 
+        [DefaultValue(0)]
         [XmlAttribute("segmentLength")]
         public int SegmentLength { get; set; }
 
+        [DefaultValue(false)]
         [XmlAttribute("breakOnNonKeyFrames")]
         public bool BreakOnNonKeyFrames { get; set; }
 
-- 
cgit v1.2.3


From 1a178e84905c776766c49551f52dc163b93c81b0 Mon Sep 17 00:00:00 2001
From: crobibero <cody@robibe.ro>
Date: Tue, 4 May 2021 19:11:01 -0600
Subject: Remove Required attributes

---
 MediaBrowser.Model/Dlna/ContainerProfile.cs   | 2 --
 MediaBrowser.Model/Dlna/DirectPlayProfile.cs  | 1 -
 MediaBrowser.Model/Dlna/TranscodingProfile.cs | 5 -----
 3 files changed, 8 deletions(-)

(limited to 'MediaBrowser.Model/Dlna/TranscodingProfile.cs')

diff --git a/MediaBrowser.Model/Dlna/ContainerProfile.cs b/MediaBrowser.Model/Dlna/ContainerProfile.cs
index 54d4f7f38..c66ec8bc3 100644
--- a/MediaBrowser.Model/Dlna/ContainerProfile.cs
+++ b/MediaBrowser.Model/Dlna/ContainerProfile.cs
@@ -9,13 +9,11 @@ namespace MediaBrowser.Model.Dlna
 {
     public class ContainerProfile
     {
-        [Required]
         [XmlAttribute("type")]
         public DlnaProfileType Type { get; set; }
 
         public ProfileCondition[]? Conditions { get; set; } = Array.Empty<ProfileCondition>();
 
-        [Required]
         [XmlAttribute("container")]
         public string Container { get; set; } = string.Empty;
 
diff --git a/MediaBrowser.Model/Dlna/DirectPlayProfile.cs b/MediaBrowser.Model/Dlna/DirectPlayProfile.cs
index 7b8cbe181..fa3ad098f 100644
--- a/MediaBrowser.Model/Dlna/DirectPlayProfile.cs
+++ b/MediaBrowser.Model/Dlna/DirectPlayProfile.cs
@@ -16,7 +16,6 @@ namespace MediaBrowser.Model.Dlna
         [XmlAttribute("videoCodec")]
         public string? VideoCodec { get; set; }
 
-        [Required]
         [XmlAttribute("type")]
         public DlnaProfileType Type { get; set; }
 
diff --git a/MediaBrowser.Model/Dlna/TranscodingProfile.cs b/MediaBrowser.Model/Dlna/TranscodingProfile.cs
index ea446b733..214578a85 100644
--- a/MediaBrowser.Model/Dlna/TranscodingProfile.cs
+++ b/MediaBrowser.Model/Dlna/TranscodingProfile.cs
@@ -8,23 +8,18 @@ namespace MediaBrowser.Model.Dlna
 {
     public class TranscodingProfile
     {
-        [Required]
         [XmlAttribute("container")]
         public string Container { get; set; } = string.Empty;
 
-        [Required]
         [XmlAttribute("type")]
         public DlnaProfileType Type { get; set; }
 
-        [Required]
         [XmlAttribute("videoCodec")]
         public string VideoCodec { get; set; } = string.Empty;
 
-        [Required]
         [XmlAttribute("audioCodec")]
         public string AudioCodec { get; set; } = string.Empty;
 
-        [Required]
         [XmlAttribute("protocol")]
         public string Protocol { get; set; } = string.Empty;
 
-- 
cgit v1.2.3