From 6c649a7e723454e94303d95d178e91b820ba6b50 Mon Sep 17 00:00:00 2001
From: nicknsy <20588554+nicknsy@users.noreply.github.com>
Date: Thu, 23 Feb 2023 17:58:34 -0800
Subject: Options
---
.../Configuration/TrickplayScanBehavior.cs | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs
(limited to 'MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs')
diff --git a/MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs b/MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs
new file mode 100644
index 000000000..799794176
--- /dev/null
+++ b/MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs
@@ -0,0 +1,18 @@
+namespace MediaBrowser.Model.Configuration
+{
+ ///
+ /// Enum TrickplayScanBehavior.
+ ///
+ public enum TrickplayScanBehavior
+ {
+ ///
+ /// Starts generation, only return once complete.
+ ///
+ Blocking,
+
+ ///
+ /// Start generation, return immediately.
+ ///
+ NonBlocking
+ }
+}
--
cgit v1.2.3
From 33770322282326304b4b8073f583d6fed2354c0b Mon Sep 17 00:00:00 2001
From: Nick <20588554+nicknsy@users.noreply.github.com>
Date: Mon, 1 May 2023 12:51:05 -0700
Subject: crobibero styling, format, code suggestions
---
.../MediaEncoding/EncodingHelper.cs | 27 +-
.../Trickplay/ITrickplayManager.cs | 77 ++-
MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs | 2 +-
.../Configuration/TrickplayOptions.cs | 109 ++--
.../Configuration/TrickplayScanBehavior.cs | 25 +-
MediaBrowser.Model/Entities/TrickplayTilesInfo.cs | 79 ++-
.../Trickplay/TrickplayImagesTask.cs | 147 +++---
.../Trickplay/TrickplayManager.cs | 569 ++++++++++-----------
.../Trickplay/TrickplayProvider.cs | 181 ++++---
9 files changed, 602 insertions(+), 614 deletions(-)
(limited to 'MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs')
diff --git a/MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs b/MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs
index bcdf2934a..01b6e31e9 100644
--- a/MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs
+++ b/MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs
@@ -90,6 +90,13 @@ namespace MediaBrowser.Controller.MediaEncoding
{ "truehd", 6 },
};
+ private static readonly string _defaultMjpegEncoder = "mjpeg";
+ private static readonly Dictionary _mjpegCodecMap = new(StringComparer.OrdinalIgnoreCase)
+ {
+ { "vaapi", _defaultMjpegEncoder + "_vaapi" },
+ { "qsv", _defaultMjpegEncoder + "_qsv" }
+ };
+
public static readonly string[] LosslessAudioCodecs = new string[]
{
"alac",
@@ -151,32 +158,20 @@ namespace MediaBrowser.Controller.MediaEncoding
private string GetMjpegEncoder(EncodingJobInfo state, EncodingOptions encodingOptions)
{
- var defaultEncoder = "mjpeg";
-
if (state.VideoType == VideoType.VideoFile)
{
var hwType = encodingOptions.HardwareAccelerationType;
- var codecMap = new Dictionary(StringComparer.OrdinalIgnoreCase)
- {
- { "vaapi", defaultEncoder + "_vaapi" },
- { "qsv", defaultEncoder + "_qsv" }
- };
-
if (!string.IsNullOrEmpty(hwType)
&& encodingOptions.EnableHardwareEncoding
- && codecMap.ContainsKey(hwType))
+ && _mjpegCodecMap.TryGetValue(hwType, out var preferredEncoder)
+ && _mediaEncoder.SupportsEncoder(preferredEncoder))
{
- var preferredEncoder = codecMap[hwType];
-
- if (_mediaEncoder.SupportsEncoder(preferredEncoder))
- {
- return preferredEncoder;
- }
+ return preferredEncoder;
}
}
- return defaultEncoder;
+ return _defaultMjpegEncoder;
}
private bool IsVaapiSupported(EncodingJobInfo state)
diff --git a/MediaBrowser.Controller/Trickplay/ITrickplayManager.cs b/MediaBrowser.Controller/Trickplay/ITrickplayManager.cs
index bae458f98..8e82c57d4 100644
--- a/MediaBrowser.Controller/Trickplay/ITrickplayManager.cs
+++ b/MediaBrowser.Controller/Trickplay/ITrickplayManager.cs
@@ -5,50 +5,49 @@ using System.Threading.Tasks;
using MediaBrowser.Controller.Entities;
using MediaBrowser.Model.Entities;
-namespace MediaBrowser.Controller.Trickplay
+namespace MediaBrowser.Controller.Trickplay;
+
+///
+/// Interface ITrickplayManager.
+///
+public interface ITrickplayManager
{
///
- /// Interface ITrickplayManager.
+ /// Generate or replace trickplay data.
///
- public interface ITrickplayManager
- {
- ///
- /// Generate or replace trickplay data.
- ///
- /// The video.
- /// Whether or not existing data should be replaced.
- /// CancellationToken to use for operation.
- /// Task.
- Task RefreshTrickplayData(Video video, bool replace, CancellationToken cancellationToken);
+ /// The video.
+ /// Whether or not existing data should be replaced.
+ /// CancellationToken to use for operation.
+ /// Task.
+ Task RefreshTrickplayDataAsync(Video video, bool replace, CancellationToken cancellationToken);
- ///
- /// Get available trickplay resolutions and corresponding info.
- ///
- /// The item.
- /// Map of width resolutions to trickplay tiles info.
- Dictionary GetTilesResolutions(Guid itemId);
+ ///
+ /// Get available trickplay resolutions and corresponding info.
+ ///
+ /// The item.
+ /// Map of width resolutions to trickplay tiles info.
+ Dictionary GetTilesResolutions(Guid itemId);
- ///
- /// Saves trickplay tiles info.
- ///
- /// The item.
- /// The trickplay tiles info.
- void SaveTilesInfo(Guid itemId, TrickplayTilesInfo tilesInfo);
+ ///
+ /// Saves trickplay tiles info.
+ ///
+ /// The item.
+ /// The trickplay tiles info.
+ void SaveTilesInfo(Guid itemId, TrickplayTilesInfo tilesInfo);
- ///
- /// Gets the trickplay manifest.
- ///
- /// The item.
- /// A map of media source id to a map of tile width to tile info.
- Dictionary> GetTrickplayManifest(BaseItem item);
+ ///
+ /// Gets the trickplay manifest.
+ ///
+ /// The item.
+ /// A map of media source id to a map of tile width to tile info.
+ Dictionary> GetTrickplayManifest(BaseItem item);
- ///
- /// Gets the path to a trickplay tiles image.
- ///
- /// The item.
- /// The width of a single tile.
- /// The tile grid's index.
- /// The absolute path.
- string GetTrickplayTilePath(BaseItem item, int width, int index);
- }
+ ///
+ /// Gets the path to a trickplay tiles image.
+ ///
+ /// The item.
+ /// The width of a single tile.
+ /// The tile grid's index.
+ /// The absolute path.
+ string GetTrickplayTilePath(BaseItem item, int width, int index);
}
diff --git a/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs b/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
index 4692bf504..000831fe2 100644
--- a/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
+++ b/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
@@ -793,7 +793,7 @@ namespace MediaBrowser.MediaEncoding.Encoder
CancellationToken cancellationToken)
{
var options = allowHwAccel ? _configurationManager.GetEncodingOptions() : new EncodingOptions();
- threads = threads ?? _threads;
+ threads ??= _threads;
// A new EncodingOptions instance must be used as to not disable HW acceleration for all of Jellyfin.
// Additionally, we must set a few fields without defaults to prevent null pointer exceptions.
diff --git a/MediaBrowser.Model/Configuration/TrickplayOptions.cs b/MediaBrowser.Model/Configuration/TrickplayOptions.cs
index d89e5f590..1fff1a5ed 100644
--- a/MediaBrowser.Model/Configuration/TrickplayOptions.cs
+++ b/MediaBrowser.Model/Configuration/TrickplayOptions.cs
@@ -1,61 +1,60 @@
using System.Collections.Generic;
using System.Diagnostics;
-namespace MediaBrowser.Model.Configuration
+namespace MediaBrowser.Model.Configuration;
+
+///
+/// Class TrickplayOptions.
+///
+public class TrickplayOptions
{
///
- /// Class TrickplayOptions.
- ///
- public class TrickplayOptions
- {
- ///
- /// Gets or sets a value indicating whether or not to use HW acceleration.
- ///
- public bool EnableHwAcceleration { get; set; } = false;
-
- ///
- /// Gets or sets the behavior used by trickplay provider on library scan/update.
- ///
- public TrickplayScanBehavior ScanBehavior { get; set; } = TrickplayScanBehavior.NonBlocking;
-
- ///
- /// Gets or sets the process priority for the ffmpeg process.
- ///
- public ProcessPriorityClass ProcessPriority { get; set; } = ProcessPriorityClass.BelowNormal;
-
- ///
- /// Gets or sets the interval, in ms, between each new trickplay image.
- ///
- public int Interval { get; set; } = 10000;
-
- ///
- /// Gets or sets the target width resolutions, in px, to generates preview images for.
- ///
- public int[] WidthResolutions { get; set; } = new[] { 320 };
-
- ///
- /// Gets or sets number of tile images to allow in X dimension.
- ///
- public int TileWidth { get; set; } = 10;
-
- ///
- /// Gets or sets number of tile images to allow in Y dimension.
- ///
- public int TileHeight { get; set; } = 10;
-
- ///
- /// Gets or sets the ffmpeg output quality level.
- ///
- public int Qscale { get; set; } = 4;
-
- ///
- /// Gets or sets the jpeg quality to use for image tiles.
- ///
- public int JpegQuality { get; set; } = 90;
-
- ///
- /// Gets or sets the number of threads to be used by ffmpeg.
- ///
- public int ProcessThreads { get; set; } = 0;
- }
+ /// Gets or sets a value indicating whether or not to use HW acceleration.
+ ///
+ public bool EnableHwAcceleration { get; set; } = false;
+
+ ///
+ /// Gets or sets the behavior used by trickplay provider on library scan/update.
+ ///
+ public TrickplayScanBehavior ScanBehavior { get; set; } = TrickplayScanBehavior.NonBlocking;
+
+ ///
+ /// Gets or sets the process priority for the ffmpeg process.
+ ///
+ public ProcessPriorityClass ProcessPriority { get; set; } = ProcessPriorityClass.BelowNormal;
+
+ ///
+ /// Gets or sets the interval, in ms, between each new trickplay image.
+ ///
+ public int Interval { get; set; } = 10000;
+
+ ///
+ /// Gets or sets the target width resolutions, in px, to generates preview images for.
+ ///
+ public int[] WidthResolutions { get; set; } = new[] { 320 };
+
+ ///
+ /// Gets or sets number of tile images to allow in X dimension.
+ ///
+ public int TileWidth { get; set; } = 10;
+
+ ///
+ /// Gets or sets number of tile images to allow in Y dimension.
+ ///
+ public int TileHeight { get; set; } = 10;
+
+ ///
+ /// Gets or sets the ffmpeg output quality level.
+ ///
+ public int Qscale { get; set; } = 4;
+
+ ///
+ /// Gets or sets the jpeg quality to use for image tiles.
+ ///
+ public int JpegQuality { get; set; } = 90;
+
+ ///
+ /// Gets or sets the number of threads to be used by ffmpeg.
+ ///
+ public int ProcessThreads { get; set; } = 0;
}
diff --git a/MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs b/MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs
index 799794176..d0db53218 100644
--- a/MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs
+++ b/MediaBrowser.Model/Configuration/TrickplayScanBehavior.cs
@@ -1,18 +1,17 @@
-namespace MediaBrowser.Model.Configuration
+namespace MediaBrowser.Model.Configuration;
+
+///
+/// Enum TrickplayScanBehavior.
+///
+public enum TrickplayScanBehavior
{
///
- /// Enum TrickplayScanBehavior.
+ /// Starts generation, only return once complete.
///
- public enum TrickplayScanBehavior
- {
- ///
- /// Starts generation, only return once complete.
- ///
- Blocking,
+ Blocking,
- ///
- /// Start generation, return immediately.
- ///
- NonBlocking
- }
+ ///
+ /// Start generation, return immediately.
+ ///
+ NonBlocking
}
diff --git a/MediaBrowser.Model/Entities/TrickplayTilesInfo.cs b/MediaBrowser.Model/Entities/TrickplayTilesInfo.cs
index 84b6b0322..86d37787f 100644
--- a/MediaBrowser.Model/Entities/TrickplayTilesInfo.cs
+++ b/MediaBrowser.Model/Entities/TrickplayTilesInfo.cs
@@ -1,50 +1,49 @@
-namespace MediaBrowser.Model.Entities
+namespace MediaBrowser.Model.Entities;
+
+///
+/// Class TrickplayTilesInfo.
+///
+public class TrickplayTilesInfo
{
///
- /// Class TrickplayTilesInfo.
+ /// Gets or sets width of an individual tile.
///
- public class TrickplayTilesInfo
- {
- ///
- /// Gets or sets width of an individual tile.
- ///
- /// The width.
- public int Width { get; set; }
+ /// The width.
+ public int Width { get; set; }
- ///
- /// Gets or sets height of an individual tile.
- ///
- /// The height.
- public int Height { get; set; }
+ ///
+ /// Gets or sets height of an individual tile.
+ ///
+ /// The height.
+ public int Height { get; set; }
- ///
- /// Gets or sets amount of tiles per row.
- ///
- /// The tile grid's width.
- public int TileWidth { get; set; }
+ ///
+ /// Gets or sets amount of tiles per row.
+ ///
+ /// The tile grid's width.
+ public int TileWidth { get; set; }
- ///
- /// Gets or sets amount of tiles per column.
- ///
- /// The tile grid's height.
- public int TileHeight { get; set; }
+ ///
+ /// Gets or sets amount of tiles per column.
+ ///
+ /// The tile grid's height.
+ public int TileHeight { get; set; }
- ///
- /// Gets or sets total amount of non-black tiles.
- ///
- /// The tile count.
- public int TileCount { get; set; }
+ ///
+ /// Gets or sets total amount of non-black tiles.
+ ///
+ /// The tile count.
+ public int TileCount { get; set; }
- ///
- /// Gets or sets interval in milliseconds between each trickplay tile.
- ///
- /// The interval.
- public int Interval { get; set; }
+ ///
+ /// Gets or sets interval in milliseconds between each trickplay tile.
+ ///
+ /// The interval.
+ public int Interval { get; set; }
- ///
- /// Gets or sets peak bandwith usage in bits per second.
- ///
- /// The bandwidth.
- public int Bandwidth { get; set; }
- }
+ ///
+ /// Gets or sets peak bandwith usage in bits per second.
+ ///
+ /// The bandwidth.
+ public int Bandwidth { get; set; }
}
diff --git a/MediaBrowser.Providers/Trickplay/TrickplayImagesTask.cs b/MediaBrowser.Providers/Trickplay/TrickplayImagesTask.cs
index 8d0d9d5a3..f32557cd1 100644
--- a/MediaBrowser.Providers/Trickplay/TrickplayImagesTask.cs
+++ b/MediaBrowser.Providers/Trickplay/TrickplayImagesTask.cs
@@ -12,98 +12,97 @@ using MediaBrowser.Model.Globalization;
using MediaBrowser.Model.Tasks;
using Microsoft.Extensions.Logging;
-namespace MediaBrowser.Providers.Trickplay
+namespace MediaBrowser.Providers.Trickplay;
+
+///
+/// Class TrickplayImagesTask.
+///
+public class TrickplayImagesTask : IScheduledTask
{
+ private readonly ILogger _logger;
+ private readonly ILibraryManager _libraryManager;
+ private readonly ILocalizationManager _localization;
+ private readonly ITrickplayManager _trickplayManager;
+
///
- /// Class TrickplayImagesTask.
+ /// Initializes a new instance of the class.
///
- public class TrickplayImagesTask : IScheduledTask
+ /// The logger.
+ /// The library manager.
+ /// The localization manager.
+ /// The trickplay manager.
+ public TrickplayImagesTask(
+ ILogger logger,
+ ILibraryManager libraryManager,
+ ILocalizationManager localization,
+ ITrickplayManager trickplayManager)
{
- private readonly ILogger _logger;
- private readonly ILibraryManager _libraryManager;
- private readonly ILocalizationManager _localization;
- private readonly ITrickplayManager _trickplayManager;
-
- ///
- /// Initializes a new instance of the class.
- ///
- /// The logger.
- /// The library manager.
- /// The localization manager.
- /// The trickplay manager.
- public TrickplayImagesTask(
- ILogger logger,
- ILibraryManager libraryManager,
- ILocalizationManager localization,
- ITrickplayManager trickplayManager)
- {
- _libraryManager = libraryManager;
- _logger = logger;
- _localization = localization;
- _trickplayManager = trickplayManager;
- }
+ _libraryManager = libraryManager;
+ _logger = logger;
+ _localization = localization;
+ _trickplayManager = trickplayManager;
+ }
- ///
- public string Name => _localization.GetLocalizedString("TaskRefreshTrickplayImages");
+ ///
+ public string Name => _localization.GetLocalizedString("TaskRefreshTrickplayImages");
- ///
- public string Description => _localization.GetLocalizedString("TaskRefreshTrickplayImagesDescription");
+ ///
+ public string Description => _localization.GetLocalizedString("TaskRefreshTrickplayImagesDescription");
- ///
- public string Key => "RefreshTrickplayImages";
+ ///
+ public string Key => "RefreshTrickplayImages";
- ///
- public string Category => _localization.GetLocalizedString("TasksLibraryCategory");
+ ///
+ public string Category => _localization.GetLocalizedString("TasksLibraryCategory");
- ///
- public IEnumerable GetDefaultTriggers()
+ ///
+ public IEnumerable GetDefaultTriggers()
+ {
+ return new[]
{
- return new[]
+ new TaskTriggerInfo
{
- new TaskTriggerInfo
- {
- Type = TaskTriggerInfo.TriggerDaily,
- TimeOfDayTicks = TimeSpan.FromHours(3).Ticks
- }
- };
- }
+ Type = TaskTriggerInfo.TriggerDaily,
+ TimeOfDayTicks = TimeSpan.FromHours(3).Ticks
+ }
+ };
+ }
- ///
- public async Task ExecuteAsync(IProgress progress, CancellationToken cancellationToken)
+ ///
+ public async Task ExecuteAsync(IProgress progress, CancellationToken cancellationToken)
+ {
+ var items = _libraryManager.GetItemList(new InternalItemsQuery
{
- var items = _libraryManager.GetItemList(new InternalItemsQuery
- {
- MediaTypes = new[] { MediaType.Video },
- IsVirtualItem = false,
- IsFolder = false,
- Recursive = true
- }).OfType