From 6ce8cce12c8d24cc0a49aac7a0d371e5ebf1b3a3 Mon Sep 17 00:00:00 2001
From: Joe Rogers <1337joe@gmail.com>
Date: Wed, 6 Oct 2021 01:13:08 +0200
Subject: Add handling for embedded background and logo

---
 .../Probing/ProbeResultNormalizer.cs                      | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

(limited to 'MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs')

diff --git a/MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs b/MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs
index fee3bf12e..5f6539495 100644
--- a/MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs
+++ b/MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs
@@ -735,14 +735,15 @@ namespace MediaBrowser.MediaEncoding.Probing
                 else if (string.Equals(stream.Codec, "mjpeg", StringComparison.OrdinalIgnoreCase))
                 {
                     // How to differentiate between video and embedded image?
-                    // The only difference I've seen thus far is presence of codec tag, also embedded images have high (unusual) framerates
-                    if (!string.IsNullOrWhiteSpace(stream.CodecTag))
+                    // check disposition, alternately: presence of codec tag, also embedded images have high (unusual) framerates
+                    if ((streamInfo.Disposition != null && streamInfo.Disposition.GetValueOrDefault("attached_pic") == 1) ||
+                        string.IsNullOrWhiteSpace(stream.CodecTag))
                     {
-                        stream.Type = MediaStreamType.Video;
+                        stream.Type = MediaStreamType.EmbeddedImage;
                     }
                     else
                     {
-                        stream.Type = MediaStreamType.EmbeddedImage;
+                        stream.Type = MediaStreamType.Video;
                     }
                 }
                 else
@@ -811,6 +812,12 @@ namespace MediaBrowser.MediaEncoding.Probing
                 {
                     stream.ColorPrimaries = streamInfo.ColorPrimaries;
                 }
+
+                // workaround for mkv attached_pics losing filename due to being classified as video based on codec
+                if (stream.Type == MediaStreamType.EmbeddedImage && streamInfo.Tags != null && string.IsNullOrEmpty(stream.Comment))
+                {
+                    stream.Comment = GetDictionaryValue(streamInfo.Tags, "filename");
+                }
             }
             else
             {
-- 
cgit v1.2.3