From 8104e739d5b83d0d6563bb685f910697e60d6c12 Mon Sep 17 00:00:00 2001
From: PloughPuff <ploughpuff@protonmail.com>
Date: Wed, 27 Feb 2019 16:33:08 +0000
Subject: Address review comments from Bond

---
 MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

(limited to 'MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs')

diff --git a/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs b/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
index 9aad67ec7..265c043b9 100644
--- a/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
+++ b/MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
@@ -282,12 +282,18 @@ namespace MediaBrowser.MediaEncoding.Encoder
             }
         }
 
+        /// <summary>
+        /// With the given path string, replaces the filename with ffprobe, taking case
+        /// of any file extension (like .exe on windows).
+        /// </summary>
+        /// <param name="appPath"></param>
+        /// <returns></returns>
         private string GetProbePathFromEncoderPath(string appPath)
         {
             if (!string.IsNullOrEmpty(appPath))
             {
-                string pattern = @"[^\/\\]+?(\.[^\/\\\n.]+)?$";
-                string substitution = @"ffprobe$1";
+                const string pattern = @"[^\/\\]+?(\.[^\/\\\n.]+)?$";
+                const string substitution = @"ffprobe$1";
 
                 return Regex.Replace(appPath, pattern, substitution);
             }
-- 
cgit v1.2.3