From 160baa02fd9a2e7b4e2b3dcc28769274d0588413 Mon Sep 17 00:00:00 2001
From: Joe Rogers <1337joe@gmail.com>
Date: Mon, 6 Mar 2023 22:18:26 -0500
Subject: Remove some BaseItem references to make ItemResolveArgs more usable
for testing.
---
MediaBrowser.Controller/Library/ItemResolveArgs.cs | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
(limited to 'MediaBrowser.Controller/Library')
diff --git a/MediaBrowser.Controller/Library/ItemResolveArgs.cs b/MediaBrowser.Controller/Library/ItemResolveArgs.cs
index 01986d303..730d89356 100644
--- a/MediaBrowser.Controller/Library/ItemResolveArgs.cs
+++ b/MediaBrowser.Controller/Library/ItemResolveArgs.cs
@@ -23,6 +23,7 @@ namespace MediaBrowser.Controller.Library
///
private readonly IServerApplicationPaths _appPaths;
+ private readonly ILibraryManager _libraryManager;
private LibraryOptions _libraryOptions;
///
@@ -30,10 +31,12 @@ namespace MediaBrowser.Controller.Library
///
/// The app paths.
/// The directory service.
- public ItemResolveArgs(IServerApplicationPaths appPaths, IDirectoryService directoryService)
+ /// The library manager.
+ public ItemResolveArgs(IServerApplicationPaths appPaths, IDirectoryService directoryService, ILibraryManager libraryManager)
{
_appPaths = appPaths;
DirectoryService = directoryService;
+ _libraryManager = libraryManager;
}
// TODO remove dependencies as properties, they should be injected where it makes sense
@@ -47,7 +50,7 @@ namespace MediaBrowser.Controller.Library
public LibraryOptions LibraryOptions
{
- get => _libraryOptions ??= Parent is null ? new LibraryOptions() : BaseItem.LibraryManager.GetLibraryOptions(Parent);
+ get => _libraryOptions ??= Parent is null ? new LibraryOptions() : _libraryManager.GetLibraryOptions(Parent);
set => _libraryOptions = value;
}
@@ -231,21 +234,15 @@ namespace MediaBrowser.Controller.Library
///
/// Gets the configured content type for the path.
///
- ///
- /// This is subject to future refactoring as it relies on a static property in BaseItem.
- ///
/// The configured content type.
public string GetConfiguredContentType()
{
- return BaseItem.LibraryManager.GetConfiguredContentType(Path);
+ return _libraryManager.GetConfiguredContentType(Path);
}
///
/// Gets the file system children that do not hit the ignore file check.
///
- ///
- /// This is subject to future refactoring as it relies on a static property in BaseItem.
- ///
/// The file system children that are not ignored.
public IEnumerable GetActualFileSystemChildren()
{
@@ -253,7 +250,7 @@ namespace MediaBrowser.Controller.Library
for (var i = 0; i < numberOfChildren; i++)
{
var child = FileSystemChildren[i];
- if (BaseItem.LibraryManager.IgnoreFile(child, Parent))
+ if (_libraryManager.IgnoreFile(child, Parent))
{
continue;
}
--
cgit v1.2.3