From 30d6e2cd6ce0702faaec73b7ffb59d9844fb6967 Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Mon, 15 Apr 2013 11:10:12 -0400 Subject: made library scan a bit more conservative --- MediaBrowser.Controller/Entities/Folder.cs | 89 ++++++++++++++++++------------ 1 file changed, 54 insertions(+), 35 deletions(-) (limited to 'MediaBrowser.Controller/Entities') diff --git a/MediaBrowser.Controller/Entities/Folder.cs b/MediaBrowser.Controller/Entities/Folder.cs index 5816b23f8..b7508a641 100644 --- a/MediaBrowser.Controller/Entities/Folder.cs +++ b/MediaBrowser.Controller/Entities/Folder.cs @@ -542,6 +542,7 @@ namespace MediaBrowser.Controller.Entities var options = new ParallelOptions { + MaxDegreeOfParallelism = 50 }; Parallel.ForEach(nonCachedChildren, options, child => @@ -606,6 +607,12 @@ namespace MediaBrowser.Controller.Entities _children.Add(item); } + if (saveTasks.Count > 50) + { + await Task.WhenAll(saveTasks).ConfigureAwait(false); + saveTasks.Clear(); + } + saveTasks.Add(LibraryManager.SaveItem(item, CancellationToken.None)); } @@ -642,65 +649,77 @@ namespace MediaBrowser.Controller.Entities /// The cancellation token. /// if set to true [recursive]. /// Task. - private Task RefreshChildren(IEnumerable> children, IProgress progress, CancellationToken cancellationToken, bool? recursive) + private async Task RefreshChildren(IEnumerable> children, IProgress progress, CancellationToken cancellationToken, bool? recursive) { var list = children.ToList(); var percentages = new ConcurrentDictionary(list.Select(i => new KeyValuePair(i.Item1.Id, 0))); - var tasks = list.Select(tuple => Task.Run(async () => + var tasks = new List(); + + foreach (var tuple in list) { - cancellationToken.ThrowIfCancellationRequested(); + if (tasks.Count > 50) + { + await Task.WhenAll(tasks).ConfigureAwait(false); + } - var child = tuple.Item1; + Tuple currentTuple = tuple; - //refresh it - await child.RefreshMetadata(cancellationToken, resetResolveArgs: child.IsFolder).ConfigureAwait(false); + tasks.Add(Task.Run(async () => + { + cancellationToken.ThrowIfCancellationRequested(); - // Refresh children if a folder and the item changed or recursive is set to true - var refreshChildren = child.IsFolder && (tuple.Item2 || (recursive.HasValue && recursive.Value)); + var child = currentTuple.Item1; - if (refreshChildren) - { - // Don't refresh children if explicitly set to false - if (recursive.HasValue && recursive.Value == false) + //refresh it + await child.RefreshMetadata(cancellationToken, resetResolveArgs: child.IsFolder).ConfigureAwait(false); + + // Refresh children if a folder and the item changed or recursive is set to true + var refreshChildren = child.IsFolder && (currentTuple.Item2 || (recursive.HasValue && recursive.Value)); + + if (refreshChildren) { - refreshChildren = false; + // Don't refresh children if explicitly set to false + if (recursive.HasValue && recursive.Value == false) + { + refreshChildren = false; + } } - } - if (refreshChildren) - { - cancellationToken.ThrowIfCancellationRequested(); + if (refreshChildren) + { + cancellationToken.ThrowIfCancellationRequested(); - var innerProgress = new ActionableProgress(); + var innerProgress = new ActionableProgress(); - innerProgress.RegisterAction(p => + innerProgress.RegisterAction(p => + { + percentages.TryUpdate(child.Id, p / 100, percentages[child.Id]); + + var percent = percentages.Values.Sum(); + percent /= list.Count; + + progress.Report((90 * percent) + 10); + }); + + await ((Folder)child).ValidateChildren(innerProgress, cancellationToken, recursive).ConfigureAwait(false); + } + else { - percentages.TryUpdate(child.Id, p / 100, percentages[child.Id]); + percentages.TryUpdate(child.Id, 1, percentages[child.Id]); var percent = percentages.Values.Sum(); percent /= list.Count; progress.Report((90 * percent) + 10); - }); - - await ((Folder) child).ValidateChildren(innerProgress, cancellationToken, recursive).ConfigureAwait(false); - } - else - { - percentages.TryUpdate(child.Id, 1, percentages[child.Id]); - - var percent = percentages.Values.Sum(); - percent /= list.Count; - - progress.Report((90 * percent) + 10); - } - })); + } + })); + } cancellationToken.ThrowIfCancellationRequested(); - return Task.WhenAll(tasks); + await Task.WhenAll(tasks).ConfigureAwait(false); } /// -- cgit v1.2.3