From 0835b26889e1b26d3bd00abfb076da3b6eb4424e Mon Sep 17 00:00:00 2001
From: cvium <clausvium@gmail.com>
Date: Mon, 31 May 2021 13:55:54 +0200
Subject: review

---
 .../Extensions/StringBuilderExtensions.cs          | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 MediaBrowser.Common/Extensions/StringBuilderExtensions.cs

(limited to 'MediaBrowser.Common/Extensions/StringBuilderExtensions.cs')

diff --git a/MediaBrowser.Common/Extensions/StringBuilderExtensions.cs b/MediaBrowser.Common/Extensions/StringBuilderExtensions.cs
new file mode 100644
index 000000000..0e0bc4282
--- /dev/null
+++ b/MediaBrowser.Common/Extensions/StringBuilderExtensions.cs
@@ -0,0 +1,34 @@
+using System.Collections.Generic;
+using System.Text;
+
+namespace MediaBrowser.Common.Extensions
+{
+    /// <summary>
+    /// Extension methods for the <see cref="StringBuilder"/> class.
+    /// </summary>
+    public static class StringBuilderExtensions
+    {
+        /// <summary>
+        /// Concatenates and appends the members of a collection in single quotes using the specified delimiter.
+        /// </summary>
+        /// <param name="builder">The string builder.</param>
+        /// <param name="delimiter">The character delimiter.</param>
+        /// <param name="values">The collection of strings to concatenate.</param>
+        /// <returns>The updated string builder.</returns>
+        public static StringBuilder AppendJoinInSingleQuotes(this StringBuilder builder, char delimiter, IReadOnlyList<string> values)
+        {
+            for (var i = 0; i < values.Count; i++)
+            {
+                builder.Append('\'')
+                    .Append(values[i])
+                    .Append('\'')
+                    .Append(delimiter);
+            }
+
+            // remove last ,
+            builder.Length--;
+
+            return builder;
+        }
+    }
+}
-- 
cgit v1.2.3


From 9111730a0a836e2c0753c5fe00a8fac87a173584 Mon Sep 17 00:00:00 2001
From: cvium <clausvium@gmail.com>
Date: Sat, 5 Jun 2021 20:16:04 +0200
Subject: More review

---
 Emby.Server.Implementations/Data/SqliteItemRepository.cs  | 5 +----
 MediaBrowser.Common/Extensions/StringBuilderExtensions.cs | 3 ++-
 2 files changed, 3 insertions(+), 5 deletions(-)

(limited to 'MediaBrowser.Common/Extensions/StringBuilderExtensions.cs')

diff --git a/Emby.Server.Implementations/Data/SqliteItemRepository.cs b/Emby.Server.Implementations/Data/SqliteItemRepository.cs
index 15a4ab318..3ae28fadf 100644
--- a/Emby.Server.Implementations/Data/SqliteItemRepository.cs
+++ b/Emby.Server.Implementations/Data/SqliteItemRepository.cs
@@ -1073,10 +1073,7 @@ namespace Emby.Server.Implementations.Data
             }
 
             // Extremely unlikely, but somehow one or more of the image strings were malformed. Cut the array.
-            var newResult = new ItemImageInfo[position];
-            Array.Copy(result, newResult, position);
-
-            return newResult;
+            return result[..position];
         }
 
         private void AppendItemImageInfo(StringBuilder bldr, ItemImageInfo image)
diff --git a/MediaBrowser.Common/Extensions/StringBuilderExtensions.cs b/MediaBrowser.Common/Extensions/StringBuilderExtensions.cs
index 0e0bc4282..75d654f23 100644
--- a/MediaBrowser.Common/Extensions/StringBuilderExtensions.cs
+++ b/MediaBrowser.Common/Extensions/StringBuilderExtensions.cs
@@ -17,7 +17,8 @@ namespace MediaBrowser.Common.Extensions
         /// <returns>The updated string builder.</returns>
         public static StringBuilder AppendJoinInSingleQuotes(this StringBuilder builder, char delimiter, IReadOnlyList<string> values)
         {
-            for (var i = 0; i < values.Count; i++)
+            var len = values.Count;
+            for (var i = 0; i < len; i++)
             {
                 builder.Append('\'')
                     .Append(values[i])
-- 
cgit v1.2.3