From e2dcddc5ac43846baea0f9b1a0fc62844dd9ee1d Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Sat, 23 Mar 2013 22:45:00 -0400 Subject: made compression and caching available to plugin api endpoints --- .../Progressive/BaseProgressiveStreamingService.cs | 59 +++++++++++++--------- 1 file changed, 36 insertions(+), 23 deletions(-) (limited to 'MediaBrowser.Api/Playback/Progressive/BaseProgressiveStreamingService.cs') diff --git a/MediaBrowser.Api/Playback/Progressive/BaseProgressiveStreamingService.cs b/MediaBrowser.Api/Playback/Progressive/BaseProgressiveStreamingService.cs index 90c233e90b..3773a2a1c5 100644 --- a/MediaBrowser.Api/Playback/Progressive/BaseProgressiveStreamingService.cs +++ b/MediaBrowser.Api/Playback/Progressive/BaseProgressiveStreamingService.cs @@ -1,11 +1,12 @@ -using System; -using MediaBrowser.Common.IO; +using MediaBrowser.Common.IO; using MediaBrowser.Common.Net; using MediaBrowser.Controller; using MediaBrowser.Controller.Entities; using MediaBrowser.Controller.Entities.Audio; using MediaBrowser.Controller.Library; using MediaBrowser.Model.Dto; +using System; +using System.Collections.Generic; using System.IO; using System.Threading.Tasks; @@ -16,7 +17,7 @@ namespace MediaBrowser.Api.Playback.Progressive /// public abstract class BaseProgressiveStreamingService : BaseStreamingService { - protected BaseProgressiveStreamingService(IServerApplicationPaths appPaths, IUserManager userManager, ILibraryManager libraryManager, IIsoManager isoManager) : + protected BaseProgressiveStreamingService(IServerApplicationPaths appPaths, IUserManager userManager, ILibraryManager libraryManager, IIsoManager isoManager) : base(appPaths, userManager, libraryManager, isoManager) { } @@ -85,18 +86,21 @@ namespace MediaBrowser.Api.Playback.Progressive /// /// Adds the dlna headers. /// - private bool AddDlnaHeaders(StreamState state) + /// The state. + /// The response headers. + /// true if XXXX, false otherwise + private void AddDlnaHeaders(StreamState state, IDictionary responseHeaders) { var timeSeek = RequestContext.GetHeader("TimeSeekRange.dlna.org"); if (!string.IsNullOrEmpty(timeSeek)) { - Response.StatusCode = 406; - return false; + ResultFactory.ThrowError(406, "Time seek not supported during encoding.", responseHeaders); + return; } var transferMode = RequestContext.GetHeader("transferMode.dlna.org"); - Response.AddHeader("transferMode.dlna.org", string.IsNullOrEmpty(transferMode) ? "Streaming" : transferMode); + responseHeaders["transferMode.dlna.org"] = string.IsNullOrEmpty(transferMode) ? "Streaming" : transferMode; var contentFeatures = string.Empty; var extension = GetOutputFileExtension(state); @@ -140,10 +144,8 @@ namespace MediaBrowser.Api.Playback.Progressive if (!string.IsNullOrEmpty(contentFeatures)) { - Response.AddHeader("ContentFeatures.DLNA.ORG", contentFeatures); + responseHeaders["ContentFeatures.DLNA.ORG"] = contentFeatures; } - - return true; } /// @@ -165,45 +167,45 @@ namespace MediaBrowser.Api.Playback.Progressive { var state = GetState(request); - if (!AddDlnaHeaders(state)) - { - return null; - } + var responseHeaders = new Dictionary(); + + AddDlnaHeaders(state, responseHeaders); if (request.Static) { - return ToStaticFileResult(state.Item.Path, isHeadRequest); + return ResultFactory.GetStaticFileResult(RequestContext, state.Item.Path, responseHeaders, isHeadRequest); } var outputPath = GetOutputFilePath(state); if (File.Exists(outputPath) && !ApiEntryPoint.Instance.HasActiveTranscodingJob(outputPath, TranscodingJobType.Progressive)) { - return ToStaticFileResult(outputPath, isHeadRequest); + return ResultFactory.GetStaticFileResult(RequestContext, outputPath, responseHeaders, isHeadRequest); } - Response.AddHeader("Accept-Ranges", "none"); - - return GetStreamResult(state, isHeadRequest).Result; + return GetStreamResult(state, responseHeaders, isHeadRequest).Result; } /// /// Gets the stream result. /// /// The state. + /// The response headers. /// if set to true [is head request]. /// Task{System.Object}. - private async Task GetStreamResult(StreamState state, bool isHeadRequest) + private async Task GetStreamResult(StreamState state, IDictionary responseHeaders, bool isHeadRequest) { // Use the command line args with a dummy playlist path var outputPath = GetOutputFilePath(state); - Response.ContentType = MimeTypes.GetMimeType(outputPath); + var contentType = MimeTypes.GetMimeType(outputPath); // Headers only if (isHeadRequest) { - return null; + responseHeaders["Accept-Ranges"] = "none"; + + return ResultFactory.GetResult(null, contentType, responseHeaders); } if (!File.Exists(outputPath)) @@ -215,7 +217,18 @@ namespace MediaBrowser.Api.Playback.Progressive ApiEntryPoint.Instance.OnTranscodeBeginRequest(outputPath, TranscodingJobType.Progressive); } - return new ProgressiveStreamWriter(outputPath, state, Logger); + var result = new ProgressiveStreamWriter(outputPath, state, Logger); + + result.Options["Accept-Ranges"] = "none"; + result.Options["Content-Type"] = contentType; + + // Add the response headers to the result object + foreach (var item in responseHeaders) + { + result.Options[item.Key] = item.Value; + } + + return result; } /// -- cgit v1.2.3