From cea8e8bbf601b97119c8b0b0a2e666414b53050c Mon Sep 17 00:00:00 2001 From: Shadowghost Date: Thu, 21 Jul 2022 19:17:44 +0200 Subject: Fix logging output --- Jellyfin.Networking/Manager/NetworkManager.cs | 33 +++++++++++++++------------ 1 file changed, 19 insertions(+), 14 deletions(-) (limited to 'Jellyfin.Networking/Manager/NetworkManager.cs') diff --git a/Jellyfin.Networking/Manager/NetworkManager.cs b/Jellyfin.Networking/Manager/NetworkManager.cs index b1112626c4..12edb0e55c 100644 --- a/Jellyfin.Networking/Manager/NetworkManager.cs +++ b/Jellyfin.Networking/Manager/NetworkManager.cs @@ -933,22 +933,27 @@ namespace Jellyfin.Networking.Manager .OrderBy(x => x.Index) .ToList(); - if (isInExternalSubnet && externalInterfaces.Any()) + if (isInExternalSubnet) { - // Check to see if any of the external bind interfaces are in the same subnet as the source. - // If none exists, this will select the first external interface if there is one. - bindAddress = externalInterfaces - .OrderByDescending(x => x.Subnet.Contains(source)) - .ThenBy(x => x.Index) - .Select(x => x.Address) - .FirstOrDefault(); - - if (bindAddress != null) + if (externalInterfaces.Any()) { - result = NetworkExtensions.FormatIpString(bindAddress); - _logger.LogDebug("{Source}: GetBindInterface: Has source, found a matching external bind interface. {Result}", source, result); - return true; + // Check to see if any of the external bind interfaces are in the same subnet as the source. + // If none exists, this will select the first external interface if there is one. + bindAddress = externalInterfaces + .OrderByDescending(x => x.Subnet.Contains(source)) + .ThenBy(x => x.Index) + .Select(x => x.Address) + .FirstOrDefault(); + + if (bindAddress != null) + { + result = NetworkExtensions.FormatIpString(bindAddress); + _logger.LogDebug("{Source}: GetBindInterface: Has source, found a matching external bind interface. {Result}", source, result); + return true; + } } + + _logger.LogWarning("{Source}: External request received, no external interface bind found, trying internal interfaces.", source); } else { @@ -963,7 +968,7 @@ namespace Jellyfin.Networking.Manager if (bindAddress != null) { result = NetworkExtensions.FormatIpString(bindAddress); - _logger.LogWarning("{Source}: External request received, only an internal interface bind found. {Result}", source, result); + _logger.LogWarning("{Source}: Request received, matching internal interface bind found. {Result}", source, result); return true; } } -- cgit v1.2.3