From a3b2b9c07fb22f5de0bbe8cb67adbecbc344d9cf Mon Sep 17 00:00:00 2001 From: PCEWLKR Date: Fri, 29 May 2026 22:07:31 -0400 Subject: Remove the unused NowPlayingQueueFullItems session property from session DTOs and associated references --- CONTRIBUTORS.md | 1 + Emby.Server.Implementations/Session/SessionManager.cs | 13 ------------- MediaBrowser.Controller/Session/SessionInfo.cs | 9 +-------- MediaBrowser.Model/Dto/SessionInfoDto.cs | 8 +------- 4 files changed, 3 insertions(+), 28 deletions(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 09a7198afe..d70ffddfd7 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -114,6 +114,7 @@ - [oddstr13](https://github.com/oddstr13) - [olsh](https://github.com/olsh) - [orryverducci](https://github.com/orryverducci) + - [PCEWLKR](https://github.com/PCEWLKR) - [petermcneil](https://github.com/petermcneil) - [Phlogi](https://github.com/Phlogi) - [pjeanjean](https://github.com/pjeanjean) diff --git a/Emby.Server.Implementations/Session/SessionManager.cs b/Emby.Server.Implementations/Session/SessionManager.cs index 5148b62655..18811ef3a9 100644 --- a/Emby.Server.Implementations/Session/SessionManager.cs +++ b/Emby.Server.Implementations/Session/SessionManager.cs @@ -453,18 +453,6 @@ namespace Emby.Server.Implementations.Session session.PlayState.RepeatMode = info.RepeatMode; session.PlayState.PlaybackOrder = info.PlaybackOrder; session.PlaylistItemId = info.PlaylistItemId; - - var nowPlayingQueue = info.NowPlayingQueue; - - if (nowPlayingQueue?.Length > 0 && !nowPlayingQueue.SequenceEqual(session.NowPlayingQueue)) - { - session.NowPlayingQueue = nowPlayingQueue; - - var itemIds = Array.ConvertAll(nowPlayingQueue, queue => queue.Id); - session.NowPlayingQueueFullItems = _dtoService.GetBaseItemDtos( - _libraryManager.GetItemList(new InternalItemsQuery { ItemIds = itemIds }), - new DtoOptions(true)); - } } /// @@ -1217,7 +1205,6 @@ namespace Emby.Server.Implementations.Session SupportsMediaControl = sessionInfo.SupportsMediaControl, SupportsRemoteControl = sessionInfo.SupportsRemoteControl, NowPlayingQueue = sessionInfo.NowPlayingQueue, - NowPlayingQueueFullItems = sessionInfo.NowPlayingQueueFullItems, HasCustomDeviceName = sessionInfo.HasCustomDeviceName, PlaylistItemId = sessionInfo.PlaylistItemId, ServerId = sessionInfo.ServerId, diff --git a/MediaBrowser.Controller/Session/SessionInfo.cs b/MediaBrowser.Controller/Session/SessionInfo.cs index 96783f6073..fb68bfb770 100644 --- a/MediaBrowser.Controller/Session/SessionInfo.cs +++ b/MediaBrowser.Controller/Session/SessionInfo.cs @@ -45,7 +45,6 @@ namespace MediaBrowser.Controller.Session PlayState = new PlayerStateInfo(); SessionControllers = []; NowPlayingQueue = []; - NowPlayingQueueFullItems = []; } /// @@ -271,16 +270,10 @@ namespace MediaBrowser.Controller.Session /// The now playing queue. public IReadOnlyList NowPlayingQueue { get; set; } - /// - /// Gets or sets the now playing queue full items. - /// - /// The now playing queue full items. - public IReadOnlyList NowPlayingQueueFullItems { get; set; } - /// /// Gets or sets a value indicating whether the session has a custom device name. /// - /// true if this session has a custom device name; otherwise, false. + /// true if the session has a custom device name; otherwise, false. public bool HasCustomDeviceName { get; set; } /// diff --git a/MediaBrowser.Model/Dto/SessionInfoDto.cs b/MediaBrowser.Model/Dto/SessionInfoDto.cs index d727cd8741..16b201de9d 100644 --- a/MediaBrowser.Model/Dto/SessionInfoDto.cs +++ b/MediaBrowser.Model/Dto/SessionInfoDto.cs @@ -149,13 +149,7 @@ public class SessionInfoDto public IReadOnlyList? NowPlayingQueue { get; set; } /// - /// Gets or sets the now playing queue full items. - /// - /// The now playing queue full items. - public IReadOnlyList? NowPlayingQueueFullItems { get; set; } - - /// - /// Gets or sets a value indicating whether the session has a custom device name. + /// Gets or sets a value indicating whether this session has a custom device name. /// /// true if this session has a custom device name; otherwise, false. public bool HasCustomDeviceName { get; set; } -- cgit v1.2.3