From 43dc604e8739614752a0c4e8a4ff00af5d74085d Mon Sep 17 00:00:00 2001
From: Vasily <just.one.man@yandex.ru>
Date: Fri, 15 May 2020 21:49:45 +0300
Subject: Fixed compilation, added backing db before removing extras

---
 Jellyfin.Server/Migrations/MigrationRunner.cs      |  2 +-
 .../Migrations/Routines/RemoveBuggedExtras.cs      | 50 ---------------
 .../Migrations/Routines/RemoveDuplicateExtras.cs   | 71 ++++++++++++++++++++++
 3 files changed, 72 insertions(+), 51 deletions(-)
 delete mode 100644 Jellyfin.Server/Migrations/Routines/RemoveBuggedExtras.cs
 create mode 100644 Jellyfin.Server/Migrations/Routines/RemoveDuplicateExtras.cs

diff --git a/Jellyfin.Server/Migrations/MigrationRunner.cs b/Jellyfin.Server/Migrations/MigrationRunner.cs
index 7a881be0f..394170065 100644
--- a/Jellyfin.Server/Migrations/MigrationRunner.cs
+++ b/Jellyfin.Server/Migrations/MigrationRunner.cs
@@ -18,7 +18,7 @@ namespace Jellyfin.Server.Migrations
         {
             typeof(Routines.DisableTranscodingThrottling),
             typeof(Routines.CreateUserLoggingConfigFile),
-            typeof(Routines.RemoveBuggedExtras)
+            typeof(Routines.RemoveDuplicateExtras)
         };
 
         /// <summary>
diff --git a/Jellyfin.Server/Migrations/Routines/RemoveBuggedExtras.cs b/Jellyfin.Server/Migrations/Routines/RemoveBuggedExtras.cs
deleted file mode 100644
index 512bec0bf..000000000
--- a/Jellyfin.Server/Migrations/Routines/RemoveBuggedExtras.cs
+++ /dev/null
@@ -1,50 +0,0 @@
-using System;
-using System.IO;
-
-using MediaBrowser.Controller;
-using Microsoft.Extensions.Logging;
-using SQLitePCL.pretty;
-
-namespace Jellyfin.Server.Migrations.Routines
-{
-    /// <summary>
-    /// Remove duplicate entries which were caused by a bug where a file was considered to be an "Extra" to itself.
-    /// </summary>
-    internal class RemoveDuplicateExtras : IMigrationRoutine
-    {
-        private const string DbFilename = "library.db";
-        private readonly ILogger _logger;
-        private readonly IServerApplicationPaths _paths;
-
-        public RemoveBuggedExtras(ILogger<RemoveBuggedExtras> logger, IServerApplicationPaths paths)
-        {
-            _logger = logger;
-            _paths = paths;
-        }
-
-        /// <inheritdoc/>
-        public Guid Id => Guid.Parse("{ACBE17B7-8435-4A83-8B64-6FCF162CB9BD}");
-
-        /// <inheritdoc/>
-        public string Name => "RemoveBuggedExtras";
-
-        /// <inheritdoc/>
-        public void Perform()
-        {
-            var dataPath = _paths.DataPath;
-            using (var connection = SQLite3.Open(
-                Path.Combine(dataPath, DbFilename),
-                ConnectionFlags.ReadWrite,
-                null))
-            {
-                var queryResult = connection.Query("SELECT t1.Path FROM TypedBaseItems AS t1, TypedBaseItems AS t2 WHERE t1.Path=t2.Path AND t1.Type!=t2.Type AND t1.Type='MediaBrowser.Controller.Entities.Video'");
-                var bads = string.Join(", ", queryResult.SelectScalarString());
-                if (bads.Length != 0)
-                {
-                    _logger.LogInformation("Removing found duplicated extras for the following items: {DuplicateExtras}", bads);
-                    connection.Execute("DELETE FROM TypedBaseItems WHERE rowid IN (SELECT t1.rowid FROM TypedBaseItems AS t1, TypedBaseItems AS t2 WHERE t1.Path=t2.Path AND t1.Type!=t2.Type AND t1.Type='MediaBrowser.Controller.Entities.Video')");
-                }
-            }
-        }
-    }
-}
diff --git a/Jellyfin.Server/Migrations/Routines/RemoveDuplicateExtras.cs b/Jellyfin.Server/Migrations/Routines/RemoveDuplicateExtras.cs
new file mode 100644
index 000000000..46de2d5c3
--- /dev/null
+++ b/Jellyfin.Server/Migrations/Routines/RemoveDuplicateExtras.cs
@@ -0,0 +1,71 @@
+using System;
+using System.Globalization;
+using System.IO;
+
+using MediaBrowser.Controller;
+using Microsoft.Extensions.Logging;
+using SQLitePCL.pretty;
+
+namespace Jellyfin.Server.Migrations.Routines
+{
+    /// <summary>
+    /// Remove duplicate entries which were caused by a bug where a file was considered to be an "Extra" to itself.
+    /// </summary>
+    internal class RemoveDuplicateExtras : IMigrationRoutine
+    {
+        private const string DbFilename = "library.db";
+        private readonly ILogger _logger;
+        private readonly IServerApplicationPaths _paths;
+
+        public RemoveDuplicateExtras(ILogger<RemoveDuplicateExtras> logger, IServerApplicationPaths paths)
+        {
+            _logger = logger;
+            _paths = paths;
+        }
+
+        /// <inheritdoc/>
+        public Guid Id => Guid.Parse("{ACBE17B7-8435-4A83-8B64-6FCF162CB9BD}");
+
+        /// <inheritdoc/>
+        public string Name => "RemoveDuplicateExtras";
+
+        /// <inheritdoc/>
+        public void Perform()
+        {
+            var dataPath = _paths.DataPath;
+            var dbPath = Path.Combine(dataPath, DbFilename);
+            using (var connection = SQLite3.Open(
+                dbPath,
+                ConnectionFlags.ReadWrite,
+                null))
+            {
+                var queryResult = connection.Query("SELECT t1.Path FROM TypedBaseItems AS t1, TypedBaseItems AS t2 WHERE t1.Path=t2.Path AND t1.Type!=t2.Type AND t1.Type='MediaBrowser.Controller.Entities.Video'");
+                var bads = string.Join(", ", queryResult.SelectScalarString());
+                if (bads.Length != 0)
+                {
+                    _logger.LogInformation("Found duplicate extras, making {Library} backup", DbFilename);
+                    for (int i = 1; ; i++)
+                    {
+                        var bakPath = string.Format(CultureInfo.InvariantCulture, "{0}.bak{1}", dbPath, i);
+                        if (!File.Exists(bakPath))
+                        {
+                            try
+                            {
+                                File.Copy(dbPath, bakPath);
+                                break;
+                            }
+                            catch (Exception ex)
+                            {
+                                _logger.LogError(ex, "Cannot make a backup of {Library}", DbFilename);
+                                throw;
+                            }
+                        }
+                    }
+
+                    _logger.LogInformation("Removing found duplicated extras for the following items: {DuplicateExtras}", bads);
+                    connection.Execute("DELETE FROM TypedBaseItems WHERE rowid IN (SELECT t1.rowid FROM TypedBaseItems AS t1, TypedBaseItems AS t2 WHERE t1.Path=t2.Path AND t1.Type!=t2.Type AND t1.Type='MediaBrowser.Controller.Entities.Video')");
+                }
+            }
+        }
+    }
+}
-- 
cgit v1.2.3