aboutsummaryrefslogtreecommitdiff
path: root/MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs
AgeCommit message (Collapse)Author
2025-06-07Use string.IsNullOrEmpty instead of regular null check.Carsten Braun
2025-06-07When subtitle is embedded in the main video file, the path will be null.Carsten Braun
2025-06-07Do not attempt to extract internal subtitles if there are only MKS subtitles.Carsten Braun
2025-06-07Skip early if subtitle is in MKS to avoid unnecessary function calls.Carsten Braun
2025-06-07If subtitles are part of an MKS, it is not an error. Just log for debug ↵Carsten Braun
purpose and continue.
2025-06-07Fixed formattingCarsten Braun
2025-06-07Also extract subtitles of MKS aux files if they're extractable.Carsten Braun
2025-04-03Cleanup extracted files (#13760)Tim Eisele
* Cleanup extracted files * Pagination and fixes * Add migration for attachments to MigrateLibraryDb * Unify attachment handling * Don't extract again if files were already extracted * Fix MKS attachment extraction * Always run full extraction on mks * Don't try to extract mjpeg streams as attachments * Fallback to check if attachments were extracted to cache folder * Fixup
2024-09-11Solve CodeQL issueoxixes
2024-09-11Use subtitle cache when burning-in subsjaina heartles
2024-09-07Backport pull request #12575 from jellyfin/release-10.9.zdmitrylyzo
Fix subtitle and attachment extraction when input path contains quotes Original-merge: 3c3ebe834462bbb7630ca4fc0c106cc51ca80e50 Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-07-15Allow streaming of raw PGS subtitles without transcoding (#12056)David Schulte
2024-05-05Clean up synchronization (#11458)Mark Cilia Vincenti
2024-04-17fix: don't extract external sub (#11373)gnattu
2024-02-10Escape subtitle extraction input path (#10992)felix920506
2024-02-03Merge changesMark Cilia Vincenti
2024-01-31Add alltilla to CONTRIBUTORS.mdAttila Szakacs
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
2024-01-18Extract all subtitle streams simultaneouslyAttila Szakacs
Extracting a subtitle stream is a disk I/O bottlenecked operation as ffmpeg has to read through the whole file, but usually there is nothing CPU intensive to do. If a file has multiple subtitle streams, and we want to extract more of them, extracting them one-by-one results in reading the whole file again and again. However ffmpeg can extract multiple streams at once. We can optimize this by extracting the subtitle streams all at once when only one of them gets queried, then we will have all of them cached for later use. It is useful for people switching subtitles during playback. It is even more useful for people who extract all the subtitle streams in advance, for example with the "Subtitle Extract" plugin. In this case we reduce the extraction time significantly based on the number of subtitle streams in the files, which can be 5-10 in many cases. Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
2024-01-03AsyncKeyedLock migrationMark Cilia Vincenti
2023-11-14Revert "Use System.Net.IPNetwork"Bond_009
This reverts commit 117d05d288da1d412159a29c0cb8d5c8259e48ae.
2023-11-05Add IDisposableAnalyzers to more projectsBond_009
2023-10-10Use Process.WaitForExitAsync added in .NET 5Bond_009
2023-08-02Fix subtitle encoder if webvtt is requestedsleepycatcoding
2023-04-06Remove redundant 'else' keywordsStepan Goremykin
2023-04-06Fix argument is not used in message template warningStepan Goremykin
2023-01-11Fix all warnings in MediaBrowser.MediaEncoding (#9073)Bond-009
2022-12-07Use ArgumentException.ThrowIfNullOrEmptyBond_009
2022-12-07Fix build errorsBond_009
2022-12-05Replace != null with is not nullBond_009
2022-10-06Use ArgumentNullException.ThrowIfNull helper methodBond_009
Did a simple search/replace on the whole repo (except the RSSDP project) This reduces LOC and should improve performance (methods containing a throw statement don't get inlined) ``` if \((\w+) == null\) \s+\{ \s+throw new ArgumentNullException\((.*)\); \s+\} ``` ``` ArgumentNullException.ThrowIfNull($1); ```
2022-09-09Fix build errors from new warningsCody Robibero
2022-08-16Merge pull request #8259 from RealGreenDragon/subtitle-extraction-timeoutCody Robibero
2022-08-14increased subtitle extraction timeout to 30 minMagicGreenDragon
2022-08-13Backport pull request #8182 from jellyfin/release-10.8.zShadowghost
Extract external subs from container before determining characterset Original-merge: 1faee43b1103428392d305cb0d1b46ff3ab6b5fc Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Joshua Boniface <joshua@boniface.me>
2022-08-01Backport pull request #8087 from jellyfin/release-10.8.zJoshua Boniface
feat: make subtitleeditparser generic Authored-by: Claus Vium <cvium@users.noreply.github.com> Merged-by: Bond-009 <bond.009@outlook.com> Original-merge: 7323ccfc232d31797af3ceb8bad93cae1ea0898d
2022-06-29Merge pull request #7984 from crobibero/dotnet-6.0.6Joshua M. Boniface
Upgrade to dotnet 6.0.6, update remaining dependencies (cherry picked from commit 56e7b323de3e993ba79ed86ef7e9a10f79693156) Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29Merge pull request #7960 from Shadowghost/subrip-encoder-fixJoshua M. Boniface
(cherry picked from commit ae79bbc34cb3ecc297b0f21fcf474b6c359a3a33) Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-06Merge pull request #7810 from Bond-009/unaccpatternCody Robibero
(cherry picked from commit 5e343d30e198ca57926a13e1a6b05ae232091d86) Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20Merge pull request #7529 from Shadowghost/strm-ffprobe-external-fixCody Robibero
(cherry picked from commit 60affd096595d68728506149d0ffce6e84b6b015) Signed-off-by: crobibero <cody@robibe.ro>
2022-02-14Increase timeout for subtitle extraction to 30min (#7153)Victor Gambier
2022-02-06Merge pull request #7241 from Bond-009/async5Cody Robibero
2022-02-02Fix #7147: Don't return subtitles in mismatched format (#7149)SenorSmartyPants
2022-01-22Flush to disk async where possibleBond_009
2021-12-27Remove more warningsCody Robibero
2021-11-09Fix some warningsBond_009
down to 580
2021-10-10Move FfmpegException to MediaBrowser.CommonDmitry Lyzo
2021-10-03Remove workaround for dotnet/runtime#42790Bond_009
2021-09-25Remove sync FileStream hackBond_009
2021-09-18Fix SubtitleEncoder and add regression testsBond_009
2021-09-02Use async FileStreams where it makes senseBond_009