aboutsummaryrefslogtreecommitdiff
path: root/MediaBrowser.Controller/Drawing/ImageHelper.cs
AgeCommit message (Collapse)Author
40 hoursUpdate MediaBrowser.Controller/Drawing/ImageHelper.csCody Robibero
Co-authored-by: Tim Eisele <Tim_Eisele@web.de>
5 daysStop image endpoints from upscaling beyond the source resolutionvavallee
ImageHelper.GetNewImageSize passed the caller-supplied width/height straight through to SkiaEncoder.EncodeImage, which allocates an SKImageInfo of exactly that size. Nothing bounded those values against the source image, so a request like Items/<id>/Images/Primary?width=23100&height=23100 made the server allocate and resample a 23100x23100 surface from, say, a 600x336 poster: the reporter measured 100% of a core for 10-15 minutes and 6-12 GB resident per request. The item images endpoints do not require authentication, so any caller who knows an item id can trigger this, and varying the size by one pixel misses the cache every time. Add DrawingUtils.ScaleDownToFit, which scales a size down uniformly until it fits inside a bounding box and returns it unchanged if it already does, and apply it in GetNewImageSize against the original image dimensions. Requests that ask for more pixels than the source now get the source resolution back, scaled to the requested aspect ratio. Downscaling paths are untouched, and DrawingUtils.Resize keeps its existing behaviour for the transcoding callers in EncodingJobInfo and StreamInfo, which legitimately size video output. ResizeFill already refused to upscale; this makes width/height consistent with fillWidth/fillHeight. Fixes #17056.
2021-06-11Remove useless nullable directivesBond_009
2021-05-07Enable nullable reference types for MediaBrowser.ControllerBond_009
2021-04-17Remove unused using directivesBaronGreenback
2021-04-11Remove GetSizeEstimate & GetEstimatedAspectRatioOdd Stråbø
from MediaBrowser.Controller.Drawing.ImageHelper Rework GetCacheFilePath to take requested with and height parameters in stead of using estimated output size
2021-04-11Add Resize to fill box alternative to image endpointsOdd Stråbø
2020-08-22Enable TreatWarningsAsErrors for MediaBrowser.Controller in ReleaseBond_009
2020-06-16fix SA1513/SA1516telans
2020-05-20Fix profile images.Patrick Barron
2020-01-21Simplify image processing by removing image enhancersBond_009
2019-01-28Fix default aspect ratioClaus Vium
2019-01-26Change image dimentions from double to intBond_009
Rename ImageSize -> ImageDimensions
2019-01-13Find+Sed BOM removal *.cs: Jellyfin.Server-MediaBrowser.ControllerErwin de Haan
2019-01-13Visual Studio Reformat: MediaBrowser.ControllerErwin de Haan
2018-12-27Add GPL modulesAndrew Rabert
2018-09-12Update to 3.5.2 and .net core 2.1stefan
2017-09-22add fixes for dng imagesLuke Pulverenti
2017-08-07consolidate interfacesLuke Pulverenti
2017-05-17update image encodingLuke Pulverenti
2017-05-14update image processingLuke Pulverenti