aboutsummaryrefslogtreecommitdiff
path: root/Emby.Server.Implementations
AgeCommit message (Collapse)Author
10 daysMerge branch 'master' into fix/create_library_thumbs_on_first_scanCody Robibero
11 daysMerge pull request #17395 from paoloantinori/fix/userdata-null-user-nre-masterCody Robibero
Avoid NRE when sorting by user-dependent keys without a user
11 daysTranslated using Weblate (Faroese)krvi
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/fo/
11 daysTranslated using Weblate (Hindi)Suyash Mittal
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/hi/
11 daysRemove added comments (#17395 review)Paolo Antinori
11 daysMerge pull request #17411 from mbastian77/perf/session-manager-tolistCody Robibero
perf: avoid unnecessary list allocation in CheckForIdlePlayback
12 daysReduce correlated subqueries to improve performanceShadowghost
13 daysAllow duplicate LinkedChildren for PlaylistsShadowghost
13 daysAvoid unnecessary list allocation in CheckForIdlePlaybackmbastian77
14 daysPrefer null checks over HasValue everywhereShadowghost
14 daysfix: avoid NRE when sorting by user-dependent keys without a userPaolo Antinori
A query sorted by a user-dependent key (PlayCount, IsFavoriteOrLiked, DatePlayed, IsPlayed, IsUnplayed) but carrying no User caused a NullReferenceException inside UserDataManager.GetUserData, surfacing as "Failed to compare two elements in the array" (InvalidOperationException wrapping the NRE from the LINQ sort) and 500-ing the /Items request. Root cause: LibraryManager.GetComparer assigned comparer.User = user without a null guard, so PlayCountComparer.GetValue called UserDataManager.GetUserData(null, item), dereferencing user.Id. Two-part fix: - LibraryManager.GetComparer: when user is null and the sort key requires a user (IUserBaseItemComparer), substitute the SortName comparer so the result stays deterministic instead of 500-ing. SortName is the project's canonical tiebreaker (ItemsController injects it for album-by-artist). - UserDataManager.GetUserData: ArgumentNullException.ThrowIfNull(user) as defense in depth (matches the existing guards on the SaveUserData overloads in the same file). On master this overload was rewritten to use ResolveUserDataRow, so the NRE dereferences user.Id rather than user.InternalId as on the release branch — same bug, different line. Also fixes DateLastMediaAddedComparer being statically mis-tagged as IUserBaseItemComparer: its GetDate is static and never reads User, so it does not need one. Without this, the SortName fallback above would wrongly engage for DateLastContentAdded on anonymous queries (returning SortName order instead of date order). Re-tagged to IBaseItemComparer and dropped the unused User/UserManager/UserDataManager properties. Tests: - UserDataManagerTests.GetUserData_NullUser_ThrowsArgumentNullException: reproduces the crash (NRE -> now ArgumentNullException). Added to master's existing UserDataManagerTests. - LibraryManagerSortTests.Sort_UserDependentKey_NullUser_FallsBackToSortNameWithoutThrowing: Sort with a user-dependent key + null user no longer throws and returns items ordered by the SortName fallback (direction preserved). - LibraryManagerSortTests.Sort_DateLastContentAdded_NullUser_OrdersByDateNotSortName: guards that DateLastContentAdded still sorts by date with no user (fixture chosen so date-desc and SortName-desc disagree, so a revert is caught). Full Jellyfin.Server.Implementations.Tests suite: 642 passed, 0 failed. Fixes #17393
2026-07-21Merge pull request #16980 from ↵Cody Robibero
TheMelmacian/feature/library_specific_language_filter_values Improve language filters to only fetch language codes that match the requested items/libraries (follow up to #9787)
2026-07-21Merge pull request #17369 from Shadowghost/harden-startup-wizardCody Robibero
Prevent unauthenticated re-run of the startup wizard on misconfiguration
2026-07-21Fix incorrect year on local trailersShadowghost
2026-07-21Merge pull request #17160 from 854562/truncate-language-stringsCody Robibero
Truncate ISO-639-2 language display names at first delimiter
2026-07-21Translated using Weblate (Latvian)aivarsse
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/lv/
2026-07-21Merge remote-tracking branch 'upstream/master' into ↵Shadowghost
security-path-traversal-fixes # Conflicts: # Jellyfin.Api/Controllers/HlsSegmentController.cs # Jellyfin.Api/Controllers/PluginsController.cs
2026-07-21Translated using Weblate (Icelandic)Shed Shedson
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/is/
2026-07-20Merge pull request #17320 from TaterTechStudios/fix/item-correct-selectorCody Robibero
Fix: Fetch the correct row matching the most up to date file
2026-07-20Merge pull request #17254 from sjakub/attribute_aliasesCody Robibero
Add additional attribute aliases and improve attribute detection
2026-07-20Extract truncation logic to helper and add tests854562
2026-07-20Add TVDB provider ID support for movies (#17255)theguymadmax
Add TVDB provider ID support for movies
2026-07-20Merge pull request #17252 from theguymadmax/fix-alubms-and-artistsBond-009
Fix artists being displayed with albums
2026-07-20Translated using Weblate (Faroese)krvi
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/fo/
2026-07-20Translated using Weblate (Croatian)Milo Ivir
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/hr/
2026-07-20Merge pull request #17365 from Shadowghost/fix-resume-perfBond-009
Fix Resume query performance
2026-07-18Translated using Weblate (Faroese)krvi
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/fo/
2026-07-18Translated using Weblate (Faroese)krvi
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/fo/
2026-07-18Translated using Weblate (Chinese (Traditional Han script))CHO-HSUN-TE
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/zh_Hant/
2026-07-17Merge pull request #17288 from nyanmisaka/ffmpeg-log-utf8Bond-009
Fix potential garbled text in FFmpeg logs on Windows
2026-07-17Merge pull request #17327 from ↵Bond-009
Shadowghost/remove-playbackpositionticks-mediasourceinfo Remove PlaybackPositionTicks from MediaSourceInfo
2026-07-17Merge pull request #17280 from Shadowghost/remove-image-override-hackBond-009
Remove episode image override hack
2026-07-17Prevent unauthenticated re-run of the startup wizard on misconfigurationShadowghost
2026-07-17Sanitize media attachment and lyric paths against traversalShadowghost
2026-07-17Merge pull request #17338 from mbastian77/docs/deviceid-xml-docsBond-009
2026-07-17Translated using Weblate (Spanish (Latin America))Fabián Sanhueza
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/es_419/
2026-07-16Fix user data batch query perfShadowghost
2026-07-15Move GetUserDataBatch to use ResolveUserDataRow when item.UserData isn't ↵Jordan Rushing
preloaded
2026-07-15Add XML docs to DeviceId and remove CS1591 suppressionmbastian77
2026-07-15Limit similar items to user accessible librariesShadowghost
2026-07-14remove PlaybackPositionTicks from MediaSourceInfoShadowghost
2026-07-13Fix: Fetch the correct row matching the most up to date fileJordan Rushing
2026-07-13Merge pull request #17273 from theguymadmax/ratigs-numerical-scoreBond-009
2026-07-13Translated using Weblate (Hebrew)DrummingBird1
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/he/
2026-07-12Apply review feedbacktheguymadmax
2026-07-10Fix host and port handling for published server URI overridesWizardOfYendor1
2026-07-10Fix potential garbled text in FFmpeg logs on Windowsnyanmisaka
Explicitly set StandardErrorEncoding and StandardOutputEncoding to Encoding.UTF8 when invoking the FFmpeg subprocess. This prevents log encoding issues and character corruption on Windows environments that default to non-UTF8 ANSI code pages. This fixes garbled metadata and font names in the FFmpeg logs. Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2026-07-09Cleanup PreferEpisodeParentPoster)Shadowghost
2026-07-09Remove episode image override hackShadowghost
2026-07-08Check numeric rating value after splitting country codetheguymadmax
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-05 04:13:47 +0000