aboutsummaryrefslogtreecommitdiff
path: root/Emby.Server.Implementations/Library
AgeCommit message (Collapse)Author
2021-04-12Fix possible ArgumentNullExceptionBond_009
``` Error Message: System.ArgumentNullException : Value cannot be null. (Parameter 'source') Stack Trace: at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument) at System.Linq.Enumerable.Select[TSource,TResult](IEnumerable`1 source, Func`2 selector) at Emby.Server.Implementations.Library.LibraryManager.ResolveItem(ItemResolveArgs args, IItemResolver[] resolvers) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 475 at Emby.Server.Implementations.Library.LibraryManager.ResolvePath(FileSystemMetadata fileInfo, IDirectoryService directoryService, IItemResolver[] resolvers, Folder parent, String collectionType, LibraryOptions libraryOptions) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 618 at Emby.Server.Implementations.Library.LibraryManager.ResolvePath(FileSystemMetadata fileInfo, Folder parent) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 536 at Emby.Server.Implementations.Library.LibraryManager.GetUserRootFolder() in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 812 at Emby.Server.Implementations.Library.LibraryManager.GetCollectionFolders(BaseItem item) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 2080 at Emby.Server.Implementations.Library.LibraryManager.GetLibraryOptions(BaseItem item) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 2116 at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in /home/vsts/work/1/s/MediaBrowser.Providers/Manager/ProviderManager.cs:line 672 at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in /home/vsts/work/1/s/MediaBrowser.Providers/Manager/ProviderManager.cs:line 655 at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 2017 at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 1975 at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 775 at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 180 at Emby.Server.Implementations.IO.LibraryMonitor.Start() in /home/vsts/work/1/s/Emby.Server.Implementations/IO/LibraryMonitor.cs:line 135 at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in /home/vsts/work/1/s/Emby.Server.Implementations/IO/LibraryMonitorStartup.cs:line 26 at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in /home/vsts/work/1/s/Emby.Server.Implementations/ApplicationHost.cs:line 518 at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks) at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in /home/vsts/work/1/s/Emby.Server.Implementations/ApplicationHost.cs:line 502 at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in /home/vsts/work/1/s/tests/Jellyfin.Server.Integration.Tests/JellyfinApplicationFactory.cs:line 101 at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer() at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers) at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers) at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options) at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient() at Jellyfin.Server.Integration.Tests.Controllers.ActivityLogControllerTests.ActivityLog_GetEntries_Ok() in /home/vsts/work/1/s/tests/Jellyfin.Server.Integration.Tests/Controllers/ActivityLogControllerTests.cs:line 21 --- End of stack trace from previous location --- ```
2021-04-11Merge pull request #5748 from cvium/playlist-audio-typeJoshua M. Boniface
Set mediatype to Audio for playlists in a music library
2021-04-10Set mediatype to Audio for playlists in a music librarycvium
2021-04-09catch ioexception and include stack tracecvium
2021-04-09fetching images should not kill the scannerClaus Vium
2021-04-01Update Emby.Server.Implementations/Library/Resolvers/TV/SeriesResolver.csBond-009
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-04-01Remove useless codeBond_009
2021-03-30Merge pull request #5467 from Ullmie02/nfo-fixesBond-009
2021-03-26Rename methods and optimize allocationsDavid
2021-03-24Fix possible null ref exceptionBond-009
2021-03-16Use Helper Methods for provider url parsingDavid
2021-03-15add unit testscvium
2021-03-14do not resolve episode-like files if they are in extras folderscvium
2021-03-13FxCop -> Net Analyzers (part 2)Bond_009
2021-03-09Add code analysis attributes where appropriateBond_009
2021-03-08Merge pull request #5409 from ikomhoog/masterJoshua M. Boniface
2021-03-08Merge pull request #5407 from Bond-009/hackClaus Vium
2021-03-08Call ToLower on CollectionTypeOptions.ToStringBond_009
2021-03-08Changed string.Length == 0 to string.IsNullOrEmpty in case of nullIkomhoog
2021-03-06Remove redundant checkcvium
2021-03-06Remove redundant checkscvium
2021-03-06rider is a prickcvium
2021-03-06simplifycvium
2021-03-05make sure network path substitution matches correctlycvium
2021-02-24CollectionType can be nullBond_009
2021-02-24Fix buildBond_009
2021-02-24Fix unchecked inputBond_009
2021-02-12remove deprecated settings from server configdkanada
2021-01-12Use JsonSerializer.SerializeToUtf8Bytes when doing a round tripBond_009
This test uses a very small object (CountryInfo), using a bigger object would increase the difference in allocated memory. ``` BenchmarkDotNet=v0.12.1, OS=fedora 32 Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores .NET Core SDK=5.0.100 [Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:| | RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B | | RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B | ```
2021-01-08Merge pull request #4906 from Spacetech/library_scan_ignore_inaccessibleBond-009
Ignore inaccessible files & folders during library scans
2021-01-06Fix 3169 and 2879 by making MusicArtistResolver run ahead of MusicAlbumResolverIan
2020-12-31Ignore inaccessible files during library scansGary Wilber
2020-12-30Merge pull request #4890 from nielsvanvelzen/4888-fix-search-hintsJoshua M. Boniface
Fix search hint endpoint error
2020-12-30Update Emby.Server.Implementations/Library/UserDataManager.csartiume
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-12-30Update Emby.Server.Implementations/Library/UserDataManager.csartiume
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-12-30Update Emby.Server.Implementations/Library/UserDataManager.csartiume
Co-authored-by: Bond-009 <bond.009@outlook.com>
2020-12-30Split resume function for Audiobooksartiume
2020-12-30Fix limit parameter error for search hints endpointNiels van Velzen
2020-12-24Put json serializer options in private fieldDavid
2020-12-23Add missing FileStreamsDavid
2020-12-23Use streams instead of stringsDavid
2020-12-23Remove custom Json serializer from Emby.Server.ImplementationsDavid
2020-12-16Merge pull request #4771 from crobibero/typed-get-preferenceClaus Vium
Use typed UserManager GetPreference
2020-12-13Use a more descriptive function namecrobibero
2020-12-11remove opf extension for book typesartiume
2020-12-11Use typed UserManager GetPreferencecrobibero
2020-12-10Simplifycvium
2020-12-10Remove ImageFetcherPostScanTaskcvium
2020-12-08fix custom library ordernyanmisaka
2020-12-01Use GetParentItem where applicablecrobibero