aboutsummaryrefslogtreecommitdiff
path: root/MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs
diff options
context:
space:
mode:
authorBond_009 <bond.009@outlook.com>2019-09-29 13:41:24 +0200
committerBond_009 <bond.009@outlook.com>2019-09-29 13:43:47 +0200
commit3e1aab6b29621db741ecfb469189322c907b673f (patch)
tree655b4a6aafd29a65be037410ab2e43fc4dded040 /MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs
parent61f2c41b76445a3808dfe87fdcde8eac49a99379 (diff)
Fix ffmpeg version check for unknown versions
Diffstat (limited to 'MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs')
-rw-r--r--MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs19
1 files changed, 11 insertions, 8 deletions
diff --git a/MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs b/MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs
index da0b7693e..3620abfee 100644
--- a/MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs
+++ b/MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs
@@ -118,15 +118,18 @@ namespace MediaBrowser.MediaEncoding.Encoder
_logger.LogInformation("Found ffmpeg version {0}", version != null ? version.ToString() : "unknown");
- if (version == null && MinVersion != null && MaxVersion != null) // Version is unknown
+ if (version == null)
{
- if (MinVersion == MaxVersion)
+ if (MinVersion != null && MaxVersion != null) // Version is unknown
{
- _logger.LogWarning("FFmpeg validation: We recommend ffmpeg version {0}", MinVersion);
- }
- else
- {
- _logger.LogWarning("FFmpeg validation: We recommend a minimum of {0} and maximum of {1}", MinVersion, MaxVersion);
+ if (MinVersion == MaxVersion)
+ {
+ _logger.LogWarning("FFmpeg validation: We recommend ffmpeg version {0}", MinVersion);
+ }
+ else
+ {
+ _logger.LogWarning("FFmpeg validation: We recommend a minimum of {0} and maximum of {1}", MinVersion, MaxVersion);
+ }
}
return false;
@@ -161,7 +164,7 @@ namespace MediaBrowser.MediaEncoding.Encoder
internal static Version GetFFmpegVersion(string output)
{
// For pre-built binaries the FFmpeg version should be mentioned at the very start of the output
- var match = Regex.Match(output, @"ffmpeg version ((?:\d+\.?)+)");
+ var match = Regex.Match(output, @"^ffmpeg version n?((?:\d+\.?)+)");
if (match.Success)
{