diff options
| author | Joshua M. Boniface <joshua@boniface.me> | 2020-07-31 09:23:55 -0400 |
|---|---|---|
| committer | Joshua M. Boniface <joshua@boniface.me> | 2020-08-02 20:37:11 -0400 |
| commit | 43ade73be480b0ae29ce1b98c4054a5badbed6cc (patch) | |
| tree | 97d0cb7e9fcfeeb949eda17d7061e6983fdad7cb /Jellyfin.Server | |
| parent | f88e9b2678b329d2ccc2900dc8a97d4e52795358 (diff) | |
Merge pull request #3761 from cvium/fix_mem_leak
Fix DI memory leak
(cherry picked from commit 9bf6222597117f0a589dbce6a9e091eabc547c7b)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Diffstat (limited to 'Jellyfin.Server')
| -rw-r--r-- | Jellyfin.Server/CoreAppHost.cs | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/Jellyfin.Server/CoreAppHost.cs b/Jellyfin.Server/CoreAppHost.cs index 207eaa98d..b136bc655 100644 --- a/Jellyfin.Server/CoreAppHost.cs +++ b/Jellyfin.Server/CoreAppHost.cs @@ -63,11 +63,12 @@ namespace Jellyfin.Server Logger.LogWarning($"Skia not available. Will fallback to {nameof(NullImageEncoder)}."); } - // TODO: Set up scoping and use AddDbContextPool - serviceCollection.AddDbContext<JellyfinDb>( - options => options - .UseSqlite($"Filename={Path.Combine(ApplicationPaths.DataPath, "jellyfin.db")}"), - ServiceLifetime.Transient); + // TODO: Set up scoping and use AddDbContextPool, + // can't register as Transient since tracking transient in GC is funky + // serviceCollection.AddDbContext<JellyfinDb>( + // options => options + // .UseSqlite($"Filename={Path.Combine(ApplicationPaths.DataPath, "jellyfin.db")}"), + // ServiceLifetime.Transient); serviceCollection.AddSingleton<JellyfinDbProvider>(); |