aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBond_009 <bond.009@outlook.com>2020-04-21 10:21:20 +0200
committerBond_009 <bond.009@outlook.com>2020-04-21 10:21:20 +0200
commite21d6160c1e77843620c70551256a386ae53072c (patch)
tree82ab9b7aca6a6223b8e2c1b40ed086ad9d5c5f0d
parenta8b59c5d216c5a79972162dd13b8319fa8986cc3 (diff)
Address comments
-rw-r--r--tests/Jellyfin.Model.Tests/Extensions/StringHelperTests.cs4
-rw-r--r--tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs6
2 files changed, 5 insertions, 5 deletions
diff --git a/tests/Jellyfin.Model.Tests/Extensions/StringHelperTests.cs b/tests/Jellyfin.Model.Tests/Extensions/StringHelperTests.cs
index 7b37b49a9..51633e157 100644
--- a/tests/Jellyfin.Model.Tests/Extensions/StringHelperTests.cs
+++ b/tests/Jellyfin.Model.Tests/Extensions/StringHelperTests.cs
@@ -11,9 +11,9 @@ namespace Jellyfin.Model.Tests.Extensions
[InlineData("banana", "Banana")]
[InlineData("Banana", "Banana")]
[InlineData("ä", "Ä")]
- public void StringHelper_ValidArgs_Success(string str, string result)
+ public void StringHelper_ValidArgs_Success(string input, string expectedResult)
{
- Assert.Equal(result, StringHelper.FirstToUpper(str));
+ Assert.Equal(expectedResult, StringHelper.FirstToUpper(input));
}
}
}
diff --git a/tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs b/tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs
index a438318ca..40d80607c 100644
--- a/tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs
+++ b/tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs
@@ -17,7 +17,7 @@ namespace Jellyfin.Naming.Tests.Subtitles
[InlineData("The Skin I Live In (2011).eng.foreign.srt", "eng", false, true)]
[InlineData("The Skin I Live In (2011).eng.default.foreign.srt", "eng", true, true)]
[InlineData("The Skin I Live In (2011).default.foreign.eng.srt", "eng", true, true)]
- public void SubtitleParser_ValidFileNames_Parses(string input, string language, bool isDefault, bool isForced)
+ public void SubtitleParser_ValidFileName_Parses(string input, string language, bool isDefault, bool isForced)
{
var parser = new SubtitleParser(_namingOptions);
@@ -30,7 +30,7 @@ namespace Jellyfin.Naming.Tests.Subtitles
[Theory]
[InlineData("The Skin I Live In (2011).mp4")]
- public void SubtitleParser_InvalidFileNames_ReturnsNull(string input)
+ public void SubtitleParser_InvalidFileName_ReturnsNull(string input)
{
var parser = new SubtitleParser(_namingOptions);
@@ -38,7 +38,7 @@ namespace Jellyfin.Naming.Tests.Subtitles
}
[Fact]
- public void SubtitleParser_EmptyFileNames_ThrowsArgumentException()
+ public void SubtitleParser_EmptyFileName_ThrowsArgumentException()
{
Assert.Throws<ArgumentException>(() => new SubtitleParser(_namingOptions).ParseFile(string.Empty));
}